summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Markwalder <tmark@isc.org>2019-06-06 13:31:08 -0400
committerThomas Markwalder <tmark@isc.org>2019-06-06 13:31:08 -0400
commit5df5813d20c9fe323357ed72b5db9a79dc269fce (patch)
tree21a27bb15596e736dca8dbf8b31cafb65e535e1e
parent1c779d3b51f3ab9031b30d370ec398e1b5819137 (diff)
downloadisc-dhcp-5df5813d20c9fe323357ed72b5db9a79dc269fce.tar.gz
[#16,!9] Addressed review comments
Added comments on #endif statements
-rw-r--r--client/dhclient.c16
-rw-r--r--includes/omapip/isclib.h3
2 files changed, 12 insertions, 7 deletions
diff --git a/client/dhclient.c b/client/dhclient.c
index 313394f3..6828c676 100644
--- a/client/dhclient.c
+++ b/client/dhclient.c
@@ -123,7 +123,8 @@ static int check_option_values(struct universe *universe, unsigned int opt,
#if defined(NSUPDATE)
static void dhclient_ddns_cb_free(dhcp_ddns_cb_t *ddns_cb,
char* file, int line);
-#endif
+#endif /* defined NSUPDATE */
+
/*!
*
@@ -1575,7 +1576,8 @@ void bind_lease (client)
#if defined (NSUPDATE)
if (client->config->do_forward_update)
dhclient_schedule_updates(client, &client->active->address, 1);
-#endif
+#endif /* defined NSUPDATE */
+
}
/* state_bound is called when we've successfully bound to a particular
@@ -4801,7 +4803,8 @@ client_dns_remove(struct client_state *client,
}
}
}
-#endif
+#endif /* defined NSUPDATE */
+
isc_result_t dhcp_set_control_state (control_object_state_t oldstate,
control_object_state_t newstate)
@@ -4842,7 +4845,8 @@ isc_result_t dhcp_set_control_state (control_object_state_t oldstate,
client_dns_remove(client,
&client->active->address);
}
-#endif
+#endif /* defined NSUPDATE */
+
do_release (client);
}
break;
@@ -5189,7 +5193,7 @@ dhclient_schedule_updates(struct client_state *client,
piaddr(*addr));
}
}
-#endif
+#endif /* defined NSUPDATE */
void
dhcpv4_client_assignments(void)
@@ -5398,7 +5402,7 @@ dhclient_ddns_cb_free(dhcp_ddns_cb_t *ddns_cb, char* file, int line) {
ddns_cb_free(ddns_cb, file, line);
}
}
-#endif
+#endif /* defined NSUPDATE */
#if defined(DHCPv6) && defined(DHCP4o6)
/*
diff --git a/includes/omapip/isclib.h b/includes/omapip/isclib.h
index 7c807863..a93117c9 100644
--- a/includes/omapip/isclib.h
+++ b/includes/omapip/isclib.h
@@ -143,6 +143,7 @@ extern int shutdown_signal;
#if defined (NSUPDATE)
isc_result_t dns_client_init();
-#endif
+#endif /* defined NSUPDATE */
+
#endif /* ISCLIB_H */