| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use modern name resolution functions and use them in a consistent
manner.
* Avoid obsolete `gethostbyname()`, `gethostbyname2()` and `gethostbyaddr()`
* Maintain consistency in variable names and error messages
* Leave IDN handling up to name resolution functions
Note: This patch provides a primitive translation of calls to obsolete
functions to calls to modern functions but more changes are needed to
process the whole result lists instead of using just the first result.
Note: This patch skips functions that use jumps to avoid making more
damage than benefits.
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
|
|
|
|
|
|
|
|
|
| |
| ni_ifaddrs.c: In function ‘ni_ifaddrs’:
| ni_ifaddrs.c:389:14: warning: variable ‘nlm_scope’ set but not used [-Wunused-but-set-variable]
| ni_ifaddrs.c:353:13: warning: variable ‘ifflist’ set but not used [-Wunused-but-set-variable]
| ni_ifaddrs.c:322:6: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Jan Synacek <jsynacek@redhat.com>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
| |
- Do real work outside the signal handler.
- Setup logfile early.
- Do not try unlinking pid file if filename is NULL (this is not a
bug, because filename is alway set non-NULL by default.)
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
|
| |
This is safe because we return an error to the caller, and the
caller does not use the buffer. But it is better not to expose
such a invalid pointer to caller.
Bug noticed by Jan Synacek <jsynacek@redhat.com>.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was once fixed by commit 70bcae85 ("ninfod: Fix off-by-one
error to check possible programming error."), but unfotunately, it was
re-introduced by commit 9a2a2664 ("ninfod: Introduce ARRAY_SIZE macro
for counting number of elements in an array.").
Bug noticed by Jan Synacek <jsynacek@redhat.com>.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
| |
Bug noticed by Jan Synacek <jsynacek@redhat.com>.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
| ninfod_core.c: In function 'pr_nodeinfo_noop':
| ninfod_core.c:244:25: warning: unused variable 'replybuf' [-Wunused-variable]
| ninfod_core.c: In function 'pr_nodeinfo_suptypes':
| ninfod_core.c:273:9: warning: unused variable 'replylen' [-Wunused-variable]
| ninfod.c: In function 'init_sock':
| ninfod.c:255:6: warning: unused variable 'i' [-Wunused-variable]
| ninfod.c: In function 'main':
| ninfod.c:636:6: warning: unused variable 'c' [-Wunused-variable]
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
| |
| ninfod.c: In function 'do_daemonize':
| ninfod.c:419:6: warning: too many arguments for format [-Wformat-extra-args]
Patch based on iputils-20121125-ninfod-minor.patch from Fedora.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
| |
| ninfod.c: In function 'ni_send':
| ninfod.c:363:4: warning: implicit declaration of function 'nanosleep' [-Wimplicit-function-declaration]
Patch based on iputils-20121125-ninfod-minor.patch from Fedora.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
|
| |
Fixes following warning:
| ninfod_name.c: In function 'nodeinfo_group':
| ninfod_name.c:270:2: warning: pointer targets in passing argument 1 of 'MD5_Final' differ in signedness [-Wpointer-sign]
| /usr/include/openssl/md5.h:113:5: note: expected 'unsigned char *' but argument is of type 'char *'
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
|
| |
- setbuf(stderr, NULL)
- write a line at once (by vsnprintf + fputs);
- No expcicit locks.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
| |
-d means debug, not daemonize.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
| |
Note that we will not write pid file as root anymore, even if ninfod is
suid-root'ed or if ninfod is run by root (with -u option).
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
| |
13e5b391.. ("ninfod: Attatch configure and renew config.h.in.")
did not introduce configure in fact.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
| |
ninfod.sh is generated by configure, so clean by "make distclean",
not by "make clean".
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
| |
Unused, but to suppress warning message from autoconf.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
|
|
|
| |
This bug is not fatal at all because this check is only for
possible programming error (which is not the case so far).
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
|
|
| |
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|
|
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
|