summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Update ipmtool version to 1.8.14-cvsIPMITOOL_1_8_14RC1Jim Mankovich2014-03-281-1/+1
|
* Update For 1.8.14 ReleaseJim Mankovich2014-03-281-0/+32
|
* ID: 299 - openipmi plugin writes zero to wrong byteZdenek Styblik2014-03-271-1/+1
| | | | | | The intent is to zero the byte that no longer contains valid data (because the data was shifted one byte to the left). However, the wrong byte is being zeroed. One way this shows up is when displaying the descriptions with hpm compprop.
* ID: 301 - Add OS/Hypervisor installation status eventsZdenek Styblik2014-03-271-0/+4
| | | | | | | Add OS/Hypervisor installation status event types to SEL as noted in table-24 in section 42.2. Commit-for: Charles Rose
* ID: 298 - fix LANplus retryZdenek Styblik2014-03-231-38/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``I had submitted a patch back on Nov 19, 2013 regarding a fix to lanplus retry. This had resolved a problem whereby a retry of a payload type of IPMI_PAYLOAD_TYPE_IPMI first removed the request from the queue before going back for a retry of the message. I have been able to determine why this fix works correctly. More importantly I have been able to resolve other retry problems in lanplus where assertion panics were hitting on certain retry operations. A new, replacement patch for resolving both of these types of retry bugs follows. The first bug,where the ipmi_lanplus_send_payload() is sending a payload type of IPMI_PAYLOAD_TYPE_IPMI is retryable, however I found in testing that it did not remove the previous request entry from the list of requests chain. If the original message had timed out, a second message sent, the second reply would not match up to the right entry on the list as the req command and sequence numbers are the same. By first removing the first request from the chain this resolves it. The consequence of not removing the stale entry was random errors. The second bug is when waiting for a message response times out during the ipmi_lanplus_send_payload types IPMI_PAYLOAD_TYPE(s) RCMP_OPEN_REQUEST, RAKP1, RAKP_3. In various testing where the message timed out on either of these three payload types, ipmitool would assertion panic upon retry as the session_state was wrong. The timeout could be due to the message never getting to the BMC, the BMC never acting/responding to the message, or the reply message packet dropped (it is UDP after all). If the BMC had acted on the message but the reply was not received, the BMC state would had advanced, and a retry of any of these three commands would error. It is not knowable at retry time if the BMC had acted on the message or not. The solution is upon message timeout failure, retry all three commands in the sequence. This has shown to be reliable and does not result in assertions or any unexpected BMC behaviors. Should the original message response eventually arrive very late, it is just discarded. The testing for these problems was elusive until we found a moderately slow BMC and had separate sessions direct a fusillade of nmap operations on the BMC, then run simple ipmitool commands. This caused sufficient loading of the network and BMC to cause lengthy delays and outright packet drops. The general approach on the second fix is to return a timeout error code back through ipmi_lanplus_open where the sequence can be retried.'' Patch-by: Pat Donlin
* ID: 295 - inform user if SOL session disconnectedZdenek Styblik2014-03-231-1/+1
| | | | | | | | Currently if we are connected to ipmitool sol session and if service processor goes down due to reset/reload, then user has no way to know that sol session has been disconnected. Commit aims to fix such case. Patch-by: Mamatha Inamdar
* ID: 297 - don't print-out SEL entry if ID not presentZdenek Styblik2014-03-231-1/+5
| | | | | | Don't print-out SEL log entry if SEL Record ID isn't present. Patch-by: Mamatha Inamdar
* ID:296 - Fix PSD size decodingZdenek Styblik2014-03-231-3/+11
| | | | | | | | Commit replaces size decoding code with code ported from "decode-dimms" Perl script found in i2c-tools 3.0.3. Former code has reported incorrect size of DDR2 modules. Patch-by: Alexander Amelkin
* Add options to chassis bootparam set bootflagJim Mankovich2014-03-112-17/+255
|
* ID: 293 - Use of uninitialized variable in ipmi_main()Zdenek Styblik2014-02-271-1/+2
| | | | | | | The variable addr is used uninitialized on line 918 of ipmi_main(). Commit ensures it is initialized to 0 before being used. Reported-by: NUXI
* Properly handle plugin non-zero target adddress with -t specification Bug 292Jim Mankovich2014-02-101-7/+9
|
* Move all files one level up in the file hierarcy, to avoid the useless ↵Petter Reinholdtsen2014-02-05171-0/+0
| | | | ipmitool directory.
* Add myself to AUTHORS to test git commit emails.Petter Reinholdtsen2014-01-311-0/+1
|
* Add link to commit archive to test git commit emails.Petter Reinholdtsen2014-01-311-0/+2
|
* Typo, missing semicolon.Petter Reinholdtsen2014-01-312-2/+2
|
* Use TIOCFLUSH if TCFLSH is missing to get the serial plugin building on Hurd.Petter Reinholdtsen2014-01-302-1/+14
|
* Disable imb and open plugins by default on Hurd. The platform lack the ↵Petter Reinholdtsen2014-01-301-0/+5
| | | | required kernel support.
* Change serial plugin to only try to disable the IUCLC serial line flag on ↵Petter Reinholdtsen2014-01-302-2/+13
| | | | platforms supporting it. Fixes build problem on Hurd and FreeBSD.
* Add missing break; in switch block (Coverity CID 1149010).Petter Reinholdtsen2014-01-151-0/+1
|
* Add missing format string placeholder (Coverity CID 1149038).Petter Reinholdtsen2014-01-151-1/+1
|
* Add missing format string placeholder (Coverity CID 1149037).Petter Reinholdtsen2014-01-151-1/+1
|
* Add missing format string placeholder (Coverity CID 1149036).Petter Reinholdtsen2014-01-151-1/+1
|
* Set pointer to NULL just after free() two other places too.Petter Reinholdtsen2014-01-111-0/+2
|
* Make sure to set free()ed pointer to NULL immediately, as specified byPetter Reinholdtsen2014-01-111-0/+1
| | | | <URL: http://sourceforge.net/p/ipmitool/wiki/coding_standards/ >.
* Make sure blockId buffer is never overflown (Coverity CID 1149058).Petter Reinholdtsen2014-01-111-1/+4
|
* Fix incorrect printf() arguments (Coverity CID 1149035).Petter Reinholdtsen2014-01-111-1/+1
|
* Make sure to release malloc()-ed data when fread() fail to read boardPetter Reinholdtsen2014-01-111-0/+1
| | | | type data (Coverity CID 1149052).
* Check return value from open() in ipmi_start_daemon() (Coverity CID CID ↵Petter Reinholdtsen2014-01-111-3/+5
| | | | 1148983).
* Make sure input_file is not used if it is NULL (Coverity CID 1149055).Petter Reinholdtsen2014-01-111-1/+2
|
* ID: 278 - Error in sol looptestZdenek Styblik2013-12-171-1/+1
| | | | Commit fixes use of uninitialized variable in SOL "looptest".
* ID: 290 - ipmi_sol.c needs a clean-upZdenek Styblik2013-12-171-30/+28
| | | | ipmi_sol_payload_access() - change formatting and simplify.
* ID: 85 - Supermicro memory ecc error displayZdenek Styblik2013-12-173-4/+196
| | | | | Commit adds memory ECC error display for Supermicro boards and adds a Supermicro oem sensor type for SEL.
* ID: 85 - Supermicro memory ECC error displayZdenek Styblik2013-12-172-0/+30
| | | | Commit adds ipmi_get_oem_id() function.
* ID: 290 - ipmi_sol.c needs a clean-upZdenek Styblik2013-12-081-113/+54
| | | | Clean up code formatting in ipmi_sol_main().
* ID: 286 - Open session retries hit assert in ipmi_lanplus_send_payloadZdenek Styblik2013-12-081-1/+2
| | | | | | | | | | If we have to retry an open session request, we hit an assert that assumes we can only be in LANPLUS_STATE_PRESESSION state. Add LANPLUS_STATE_OPEN_SESSION_SENT so we don't abort if we retry. Commit for Anton Blanchard
* ID: 285 - Fix SEGV in ipmi_lanplus_open_sessionZdenek Styblik2013-12-081-1/+4
| | | | | | | | If ipmi_lanplus_send_payload fails we get a NULL pointer returned. Error out straight away instead of continuing on and getting a SEGV when we dereference rsp. Commit for Anton Blanchard
* ID: 284 - Fix SEGV in ipmi_mainZdenek Styblik2013-12-081-3/+5
| | | | | | | | Check the return code of ipmi_main_intf->open(), and take the error path if it fails. Right now we continue on blindly which results in a SEGV. Commit for Anton Blanchard
* ID: 283 - ipmi_intf_socket_connect fails with IPv4 hostsZdenek Styblik2013-12-081-1/+1
| | | | | | | A recent IPv6 patch broke IPv4 connections. Fix the incorrect conditional to get it going again. Commit for Anton Blanchard
* Fix code formatting, at least a bit.Zdenek Styblik2013-12-082-23/+20
|
* Reverting commit ``Add support for enabling/disabling PEF policy entries'' asZdenek Styblik2013-11-262-90/+3
| | | | there is no ticket/ticket number missing and no code review.
* Add support for enabling/disabling PEF policy entriesJordan Hargrave2013-11-252-3/+90
|
* PA: 83 - Revised IPv6 patchAles Ledvinka2013-11-147-121/+218
| | | | | | Author: Holger Liebig Deduplicated socket connection shared among lan and lanplus. Allows IPv6 address and tries to pick correct scope ID.
* FR: 24 - Exchange OS Name Hostname BMC URL during startupAles Ledvinka2013-11-052-3/+4
| | | | Correct sysconfig defaults in comment. Systemd dependencies.
* FR: 24 - Exchange OS Name Hostname BMC URL during startupAles Ledvinka2013-11-054-0/+366
| | | | Add service, systemd unit, sysconfig in contrib
* ID: 46 - ipmi_fwum needs some re-workZdenek Styblik2013-10-281-1/+202
| | | | Commit changes to 'include/ipmitool/ipmi_fwum.h'.
* ID: 46 - ipmi_fwum needs some re-workZdenek Styblik2013-10-261-212/+46
| | | | Move 'struct' and 'enum' into header file
* ID: 46 - ipmi_fwum needs some re-workZdenek Styblik2013-10-261-95/+91
| | | | | | | | Replace tKFWUM_Status with int Commit replaces tKFWUM_Status with int. tKFWUM_Status is all nice and neat, but if int can do, why would you use something that makes your lines unnecessarily longer?
* ID: 46 - ipmi_fwum needs some re-workZdenek Styblik2013-10-261-28/+28
| | | | | | Remove keyword 'static' Commit removes ``static'' as I see no point, no point at all to have it here.
* ID: 46 - ipmi_fwum needs some re-workZdenek Styblik2013-10-261-16/+16
| | | | Rename saveFirmwareInfo -> save_fw_nfo
* ID: 46 - ipmi_fwum needs some re-workZdenek Styblik2013-10-261-7/+7
| | | | | | | File name is no longer ``uchar *'' - remove casts File name is no longer ``unsigned char *'', therefore remove pointless casts to ``char *''.