summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Amelkin <alexander@amelkin.msk.ru>2019-08-29 12:23:43 +0300
committerAlexander Amelkin <alexander@amelkin.msk.ru>2019-08-29 12:26:40 +0300
commit1724b031b3c9d011082a69525ad527e15e54bfc5 (patch)
treee4d93925a45e917e24166c86588381714a2e3f9a
parent9006f2b26d10401ccd493b4b7084a616e33c51f1 (diff)
downloadipmitool-1724b031b3c9d011082a69525ad527e15e54bfc5.tar.gz
intf: Add missing function declarations
ipmi_intf.h was missing a couple of declarations for the functions used by fru, sdr and hpmfwupg modules. Add those declarations to ipmi_intf.h and remove local declarations. This fixes a couple of compilation warnings. Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
-rw-r--r--include/ipmitool/ipmi_intf.h3
-rw-r--r--lib/ipmi_fru.c6
-rw-r--r--lib/ipmi_hpmfwupg.c4
-rw-r--r--lib/ipmi_sdr.c4
4 files changed, 3 insertions, 14 deletions
diff --git a/include/ipmitool/ipmi_intf.h b/include/ipmitool/ipmi_intf.h
index 2ca409f..5ae252e 100644
--- a/include/ipmitool/ipmi_intf.h
+++ b/include/ipmitool/ipmi_intf.h
@@ -241,6 +241,9 @@ struct ipmi_intf {
void (*set_max_response_data_size)(struct ipmi_intf * intf, uint16_t size);
};
+uint16_t ipmi_intf_get_max_request_data_size(struct ipmi_intf *intf);
+uint16_t ipmi_intf_get_max_response_data_size(struct ipmi_intf *intf);
+
struct ipmi_intf * ipmi_intf_load(char * name);
void ipmi_intf_print(struct ipmi_intf_support * intflist);
diff --git a/lib/ipmi_fru.c b/lib/ipmi_fru.c
index c9e64fc..c2a139d 100644
--- a/lib/ipmi_fru.c
+++ b/lib/ipmi_fru.c
@@ -111,12 +111,6 @@ static inline bool fru_cc_rq2big(int code) {
int
ipmi_spd_print_fru(struct ipmi_intf * intf, uint8_t id);
-/* From src/plugins/ipmi_intf.c: */
-void
-ipmi_intf_set_max_request_data_size(struct ipmi_intf * intf, uint16_t size);
-void
-ipmi_intf_set_max_response_data_size(struct ipmi_intf * intf, uint16_t size);
-
extern int verbose;
static void ipmi_fru_read_to_bin(struct ipmi_intf * intf, char * pFileName, uint8_t fruId);
diff --git a/lib/ipmi_hpmfwupg.c b/lib/ipmi_hpmfwupg.c
index 12671ce..4aa8cec 100644
--- a/lib/ipmi_hpmfwupg.c
+++ b/lib/ipmi_hpmfwupg.c
@@ -48,10 +48,6 @@
# include <config.h>
#endif
-/* From src/plugins/ipmi_intf.c: */
-uint16_t
-ipmi_intf_get_max_request_data_size(struct ipmi_intf * intf);
-
extern int verbose;
int HpmfwupgUpgrade(struct ipmi_intf *intf, char *imageFilename,
diff --git a/lib/ipmi_sdr.c b/lib/ipmi_sdr.c
index b43765a..c24a387 100644
--- a/lib/ipmi_sdr.c
+++ b/lib/ipmi_sdr.c
@@ -219,10 +219,6 @@ static const char *sensor_type_desc[] = {
void printf_sdr_usage();
-/* From src/plugins/ipmi_intf.c: */
-uint16_t
-ipmi_intf_get_max_response_data_size(struct ipmi_intf * intf);
-
/** ipmi_sdr_get_unit_string - return units for base/modifier
*
* @param[in] pct Indicates that units are a percentage