diff options
| author | Chrostoper Ertl <chertl@microsoft.com> | 2019-11-28 16:51:49 +0000 |
|---|---|---|
| committer | Alexander Amelkin <alexander@amelkin.msk.ru> | 2020-02-04 14:59:49 +0300 |
| commit | 41d7026946fafbd4d1ec0bcaca3ea30a6e8eed22 (patch) | |
| tree | ef24702d8f46a8f87ecf1694c73a8763a4d6fef5 | |
| parent | 840fb1cbb4fb365cb9797300e3374d4faefcdb10 (diff) | |
| download | ipmitool-41d7026946fafbd4d1ec0bcaca3ea30a6e8eed22.tar.gz | |
session: Fix buffer overflow in ipmi_get_session_info
Partial fix for CVE-2020-5208, see
https://github.com/ipmitool/ipmitool/security/advisories/GHSA-g659-9qxw-p7cp
The `ipmi_get_session_info` function does not properly check the
response `data_len`, which is used as a copy size, allowing stack buffer
overflow.
| -rw-r--r-- | lib/ipmi_session.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/lib/ipmi_session.c b/lib/ipmi_session.c index ecf4afc..b282d6d 100644 --- a/lib/ipmi_session.c +++ b/lib/ipmi_session.c @@ -309,8 +309,10 @@ ipmi_get_session_info(struct ipmi_intf * intf, } else { - memcpy(&session_info, rsp->data, rsp->data_len); - print_session_info(&session_info, rsp->data_len); + memcpy(&session_info, rsp->data, + __min(rsp->data_len, sizeof(session_info))); + print_session_info(&session_info, + __min(rsp->data_len, sizeof(session_info))); } break; @@ -341,8 +343,10 @@ ipmi_get_session_info(struct ipmi_intf * intf, break; } - memcpy(&session_info, rsp->data, rsp->data_len); - print_session_info(&session_info, rsp->data_len); + memcpy(&session_info, rsp->data, + __min(rsp->data_len, sizeof(session_info))); + print_session_info(&session_info, + __min(rsp->data_len, sizeof(session_info))); } while (i <= session_info.session_slot_count); break; |