diff options
| author | Zdenek Styblik <zdenek.styblik@gmail.com> | 2013-10-26 19:29:05 +0000 |
|---|---|---|
| committer | Zdenek Styblik <zdenek.styblik@gmail.com> | 2013-10-26 19:29:05 +0000 |
| commit | cd524c2d25afe5a9bb46bc41fd5e66dea9e71a4f (patch) | |
| tree | 09150c3d8244b005aeec1044f4b4e40224a6e714 | |
| parent | e24c7f75f2653f478be60bf1b7400ada95157582 (diff) | |
| download | ipmitool-cd524c2d25afe5a9bb46bc41fd5e66dea9e71a4f.tar.gz | |
ID: 46 - ipmi_fwum needs some re-work
File name is no longer ``uchar *'' - remove casts
File name is no longer ``unsigned char *'', therefore remove pointless casts to
``char *''.
| -rw-r--r-- | ipmitool/lib/ipmi_fwum.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/ipmitool/lib/ipmi_fwum.c b/ipmitool/lib/ipmi_fwum.c index ddf9421..0d67a78 100644 --- a/ipmitool/lib/ipmi_fwum.c +++ b/ipmitool/lib/ipmi_fwum.c @@ -110,9 +110,9 @@ extern int verbose; static unsigned char firmBuf[1024*512]; static tKFWUM_SaveFirmwareInfo saveFirmwareInfo; -static tKFWUM_Status KfwumGetFileSize(unsigned char *pFileName, +static tKFWUM_Status KfwumGetFileSize(const char *pFileName, unsigned long *pFileSize); -static tKFWUM_Status KfwumSetupBuffersFromFile(unsigned char *pFileName, +static tKFWUM_Status KfwumSetupBuffersFromFile(const char *pFileName, unsigned long fileSize); void KfwumShowProgress(const char *task, unsigned long current, unsigned long total); @@ -324,10 +324,10 @@ ipmi_fwum_fwupgrade(struct ipmi_intf *intf, char *file, int action) * returns KFWUM_STATUS_OK or KFWUM_STATUS_ERROR */ static tKFWUM_Status -KfwumGetFileSize(unsigned char *pFileName, unsigned long *pFileSize) +KfwumGetFileSize(const char *pFileName, unsigned long *pFileSize) { FILE *pFileHandle = NULL; - pFileHandle = fopen((const char *)pFileName, "rb"); + pFileHandle = fopen(pFileName, "rb"); if (pFileHandle == NULL) { return KFWUM_STATUS_ERROR; } @@ -349,7 +349,7 @@ KfwumGetFileSize(unsigned char *pFileName, unsigned long *pFileSize) * returns KFWUM_STATUS_OK or KFWUM_STATUS_ERROR */ static tKFWUM_Status -KfwumSetupBuffersFromFile(unsigned char * pFileName, unsigned long fileSize) +KfwumSetupBuffersFromFile(const char *pFileName, unsigned long fileSize) { tKFWUM_Status status = KFWUM_STATUS_ERROR; FILE *pFileHandle = NULL; @@ -357,10 +357,10 @@ KfwumSetupBuffersFromFile(unsigned char * pFileName, unsigned long fileSize) int modulus; int qty = 0; - pFileHandle = fopen((const char *)pFileName, "rb"); + pFileHandle = fopen(pFileName, "rb"); if (pFileHandle == NULL) { lprintf(LOG_ERR, "Failed to open '%s' for reading.", - (char *)pFileName); + pFileName); return KFWUM_STATUS_ERROR; } count = fileSize / MAX_BUFFER_SIZE; |