summaryrefslogtreecommitdiff
path: root/utils
diff options
context:
space:
mode:
authorDuncan Coutts <duncan@well-typed.com>2014-08-19 01:00:54 +0100
committerEdward Z. Yang <ezyang@cs.stanford.edu>2014-08-29 12:39:03 +0100
commit69e9f6e48f938ce62a885a9086392ffd6a579c29 (patch)
treee8e7e36ed09ed814e4e9849ab0ca489f0306ba7e /utils
parentb2affa0f213f08acd1c0bb0f2a5e8b2a70272a0b (diff)
downloadhaskell-69e9f6e48f938ce62a885a9086392ffd6a579c29.tar.gz
Simplify conversion in binary serialisation of ghc-pkg db
We can serialise directly, without having to convert some fields to string first. (Part of preparitory work for removing the compiler's dep on Cabal)
Diffstat (limited to 'utils')
-rw-r--r--utils/ghc-pkg/Main.hs7
1 files changed, 3 insertions, 4 deletions
diff --git a/utils/ghc-pkg/Main.hs b/utils/ghc-pkg/Main.hs
index c88b814a71..554640e7e5 100644
--- a/utils/ghc-pkg/Main.hs
+++ b/utils/ghc-pkg/Main.hs
@@ -706,8 +706,7 @@ readParseDatabase verbosity mb_user_conf use_cache path
when (verbosity > Normal) $
infoLn ("using cache: " ++ cache)
pkgs <- myReadBinPackageDB cache
- let pkgs' = map convertPackageInfoIn pkgs
- mkPackageDB pkgs'
+ mkPackageDB pkgs
else do
when (verbosity >= Normal) $ do
warn ("WARNING: cache is out of date: "
@@ -735,7 +734,7 @@ readParseDatabase verbosity mb_user_conf use_cache path
-- bytestring 0.9.0.x (fixed in 0.9.1.x) where the file wasn't closed
-- after it has been completely read, leading to a sharing violation
-- later.
-myReadBinPackageDB :: FilePath -> IO [InstalledPackageInfoString]
+myReadBinPackageDB :: FilePath -> IO [InstalledPackageInfo]
myReadBinPackageDB filepath = do
h <- openBinaryFile filepath ReadMode
sz <- hFileSize h
@@ -1021,7 +1020,7 @@ updateDBCache verbosity db = do
let filename = location db </> cachefilename
when (verbosity > Normal) $
infoLn ("writing cache " ++ filename)
- writeBinaryFileAtomic filename (map convertPackageInfoOut (packages db))
+ writeBinaryFileAtomic filename (packages db)
`catchIO` \e ->
if isPermissionError e
then die (filename ++ ": you don't have permission to modify this file")