summaryrefslogtreecommitdiff
path: root/rts/Threads.c
diff options
context:
space:
mode:
authorÖmer Sinan Ağacan <omeragacan@gmail.com>2019-02-22 10:44:27 +0300
committerBen Gamari <ben@smart-cactus.org>2019-02-22 11:38:57 -0500
commit6698bbadb99695e97f0f07b36f57dd06193074ae (patch)
tree41f75effa2f1802a60cc8364d50d2bd4b46d8aba /rts/Threads.c
parenta4f7fc5e8a3002f19b78d7982735a2d42dd744b1 (diff)
downloadhaskell-wip/nonmoving-gc.tar.gz
Remove origin arguments from write barrier functionswip/nonmoving-gc
Write barriers push old values of updated field, e.g. when we have *q = p; we do updateRemembSetPushClosure(*q, q); *q = p; Here the second argument ("origin") is not useful because by the time we do the update we invalidate "origin" (`q` is no longer origin of old `*q`). In general it doesn't make sense to record origins in write barriers so we remove all origin arguments from write barriers. Fixes #170.
Diffstat (limited to 'rts/Threads.c')
-rw-r--r--rts/Threads.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/rts/Threads.c b/rts/Threads.c
index 33cf907633..408304a6a6 100644
--- a/rts/Threads.c
+++ b/rts/Threads.c
@@ -717,9 +717,7 @@ threadStackUnderflow (Capability *cap, StgTSO *tso)
// necessarily form a full closure so we need to handle them
// specially.
for (unsigned int i = 0; i < retvals; i++) {
- updateRemembSetPushClosure(cap,
- (StgClosure *) old_stack->sp[i],
- NULL);
+ updateRemembSetPushClosure(cap, (StgClosure *) old_stack->sp[i]);
}
}