diff options
author | Ömer Sinan Ağacan <omeragacan@gmail.com> | 2019-02-22 10:44:27 +0300 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2019-02-22 11:38:57 -0500 |
commit | 6698bbadb99695e97f0f07b36f57dd06193074ae (patch) | |
tree | 41f75effa2f1802a60cc8364d50d2bd4b46d8aba /rts/STM.c | |
parent | a4f7fc5e8a3002f19b78d7982735a2d42dd744b1 (diff) | |
download | haskell-wip/nonmoving-gc.tar.gz |
Remove origin arguments from write barrier functionswip/nonmoving-gc
Write barriers push old values of updated field, e.g. when we have
*q = p;
we do
updateRemembSetPushClosure(*q, q);
*q = p;
Here the second argument ("origin") is not useful because by the time we
do the update we invalidate "origin" (`q` is no longer origin of old
`*q`).
In general it doesn't make sense to record origins in write barriers so
we remove all origin arguments from write barriers.
Fixes #170.
Diffstat (limited to 'rts/STM.c')
-rw-r--r-- | rts/STM.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -298,7 +298,7 @@ static StgClosure *lock_tvar(Capability *cap, (StgWord)result, (StgWord)trec) != (StgWord)result); if (nonmoving_write_barrier_enabled && result) { - updateRemembSetPushClosure(cap, result, NULL); + updateRemembSetPushClosure(cap, result); } return result; } @@ -324,7 +324,7 @@ static StgBool cond_lock_tvar(Capability *cap, w = cas((void *)&(s -> current_value), (StgWord)expected, (StgWord)trec); result = (StgClosure *)w; if (nonmoving_write_barrier_enabled && result) { - updateRemembSetPushClosure(cap, expected, NULL); + updateRemembSetPushClosure(cap, expected); } TRACE("%p : %s", trec, result ? "success" : "failure"); return (result == expected); |