diff options
| author | Ömer Sinan Ağacan <omeragacan@gmail.com> | 2019-02-22 10:44:27 +0300 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2019-02-22 11:38:57 -0500 |
| commit | 6698bbadb99695e97f0f07b36f57dd06193074ae (patch) | |
| tree | 41f75effa2f1802a60cc8364d50d2bd4b46d8aba /includes/Cmm.h | |
| parent | a4f7fc5e8a3002f19b78d7982735a2d42dd744b1 (diff) | |
| download | haskell-wip/nonmoving-gc.tar.gz | |
Remove origin arguments from write barrier functionswip/nonmoving-gc
Write barriers push old values of updated field, e.g. when we have
*q = p;
we do
updateRemembSetPushClosure(*q, q);
*q = p;
Here the second argument ("origin") is not useful because by the time we
do the update we invalidate "origin" (`q` is no longer origin of old
`*q`).
In general it doesn't make sense to record origins in write barriers so
we remove all origin arguments from write barriers.
Fixes #170.
Diffstat (limited to 'includes/Cmm.h')
| -rw-r--r-- | includes/Cmm.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/Cmm.h b/includes/Cmm.h index b8440204ad..b21c5d1773 100644 --- a/includes/Cmm.h +++ b/includes/Cmm.h @@ -840,9 +840,9 @@ * object `origin` has been overwritten. This implements the nonmoving collector's * update remembered set write barrier. */ -#define recordMutatedPtr(p, origin) \ +#define recordMutatedPtr(p) \ if (nonmoving_write_barrier_enabled != 0) (likely: False) { \ - ccall updateRemembSetPushClosure_(BaseReg "ptr", (p) "ptr", (origin) "ptr"); \ + ccall updateRemembSetPushClosure_(BaseReg "ptr", (p) "ptr"); \ } /* ----------------------------------------------------------------------------- |