diff options
author | simonmar <unknown> | 2000-04-12 17:33:17 +0000 |
---|---|---|
committer | simonmar <unknown> | 2000-04-12 17:33:17 +0000 |
commit | 313a61d546f55bb2c098ecd0ebb42e15d943201e (patch) | |
tree | 313c27ee549972fb4d9ef886e27c1708d45af9a0 /ghc/lib/std/cbits/writeFile.c | |
parent | f016aea1357b8ce5a4f3cd866b32761cfd25f841 (diff) | |
download | haskell-313a61d546f55bb2c098ecd0ebb42e15d943201e.tar.gz |
[project @ 2000-04-12 17:33:16 by simonmar]
This commit fixes the trace/stderr problem, and also fixes some other
problems with the I/O library.
- handles now contain a list of free buffers, which are
guaranteed to be the same size as the primary handle buffer.
- hPutStr now doesn't evaluate any part of the input string with
the handle locked. Instead, it acquires a buffer from the handle
copies characters into it, then commits the buffer. This is
better for concurrency too, because the handle is only locked
while we're actually reading/writing, not while evaluating.
- there were an even number of off-by-one errors in the I/O system
which compensated for each other. This has been fixed.
- made the I/O subsystem a little more exception-safe. It still
isn't totally exception-safe, but I can't face doing that
without a complete rewrite of this thing in Haskell.
- add hPutBufFull and hGetBufFull. The compiler probably needs to
be updated to use these too.
Diffstat (limited to 'ghc/lib/std/cbits/writeFile.c')
-rw-r--r-- | ghc/lib/std/cbits/writeFile.c | 46 |
1 files changed, 39 insertions, 7 deletions
diff --git a/ghc/lib/std/cbits/writeFile.c b/ghc/lib/std/cbits/writeFile.c index eed60e9baf..383ec52459 100644 --- a/ghc/lib/std/cbits/writeFile.c +++ b/ghc/lib/std/cbits/writeFile.c @@ -1,7 +1,7 @@ /* * (c) The GRASP/AQUA Project, Glasgow University, 1994-1998 * - * $Id: writeFile.c,v 1.13 2000/03/10 15:23:40 simonmar Exp $ + * $Id: writeFile.c,v 1.14 2000/04/12 17:33:16 simonmar Exp $ * * hPutStr Runtime Support */ @@ -41,13 +41,13 @@ writeBuffer(StgForeignPtr ptr, StgInt bytes) int count; IOFileObject* fo = (IOFileObject*)ptr; - char *pBuf = (char *) fo->buf + fo->bufStart; + char *pBuf = (char *) fo->buf + fo->bufRPtr; - bytes -= fo->bufStart; + bytes -= fo->bufRPtr; /* Disallow short writes */ if (bytes == 0 || fo->buf == NULL) { - fo->bufStart = 0; + fo->bufRPtr = 0; return 0; } @@ -72,12 +72,12 @@ writeBuffer(StgForeignPtr ptr, StgInt bytes) else { bytes -= count; pBuf += count; - fo->bufStart += count; + fo->bufRPtr += count; } } /* Signal that we've emptied the buffer */ - fo->bufStart = 0; - fo->bufWPtr = 0; + fo->bufRPtr = 0; + fo->bufWPtr = 0; return 0; } @@ -164,3 +164,35 @@ writeBufBA(StgForeignPtr ptr, StgByteArray buf, StgInt off, StgInt len) { return (writeBuf(ptr,(StgAddr)buf, off, len)); } + +/* ----------------------------------------------------------------------------- + * write_ is just a simple wrapper around write/2 that restarts + * on EINTR and returns FILEOBJ_BLOCKED_WRITE on EAGAIN. + * -------------------------------------------------------------------------- */ + +StgInt +write_(StgForeignPtr ptr, StgAddr buf, StgInt len) +{ + IOFileObject* fo = (IOFileObject*)ptr; + int rc; + + while ((rc = + ( +#ifdef USE_WINSOCK + fo->flags & FILEOBJ_WINSOCK ? + send(fo->fd, buf, (int)len, 0) : + write(fo->fd, buf, (int)len))) < 0 ) { +#else + write(fo->fd, buf, (int)len))) < 0 ) { +#endif + if ( errno == EAGAIN ) { + errno = 0; + return FILEOBJ_BLOCKED_WRITE; + } else if ( errno != EINTR ) { + cvtErrno(); + stdErrno(); + return -1; + } + } + return rc; +} |