diff options
author | Ryan Scott <ryan.gl.scott@gmail.com> | 2017-08-22 09:29:07 -0400 |
---|---|---|
committer | Ryan Scott <ryan.gl.scott@gmail.com> | 2017-08-22 09:29:07 -0400 |
commit | 8fd959998e900dffdb7f752fcd42df7aaedeae6e (patch) | |
tree | cddc1e31d91e2a0b1aa6f4a020a6fddd7578f84b /docs/users_guide/flags.py | |
parent | 8476097609a2044e965157380aeb5d4882a71248 (diff) | |
download | haskell-8fd959998e900dffdb7f752fcd42df7aaedeae6e.tar.gz |
Make the Read instance for Proxy (and friends) ignore precedence
Summary:
The `Read` instance for `Proxy`, as well as a handful of other data
types in `base` which only have a single constructor, are doing something
skeevy: they're requiring that they be surrounded by parentheses if the parsing
precedence is sufficiently high. This means that `"Thing (Proxy)"` would parse,
but not `"Thing Proxy"`. But the latter really ought to parse, since there's no
need to surround a single constructor with parentheses. Indeed, that's the
output of `show (Thing Proxy)`, so the current `Read` instance for `Proxy`
violates `read . show = id`.
The simple solution is to change `readParen (d > 10)` to `readParen False` in
the `Read` instance for `Proxy`. But given that a derived `Read` instance would
essentially accomplish the same thing, but with even fewer characters, I've
opted to just replace the hand-rolled `Read` instance with a derived one.
Test Plan: make test TEST=T12874
Reviewers: ekmett, austin, hvr, goldfire, bgamari
Reviewed By: bgamari
Subscribers: rwbarton, thomie
GHC Trac Issues: #12874
Differential Revision: https://phabricator.haskell.org/D3871
Diffstat (limited to 'docs/users_guide/flags.py')
0 files changed, 0 insertions, 0 deletions