diff options
| author | Andreas Klebinger <klebinger.andreas@gmx.at> | 2019-10-20 02:30:01 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2019-10-23 05:59:04 -0400 |
| commit | 6beea836094383eea96b15e526f31b5426aea630 (patch) | |
| tree | eedb44be3fa4f86d085f3cfa2bb905b13cefccf4 /compiler/nativeGen | |
| parent | 9c1f0f7c384eb2e38911b9a9b083ecda0970a060 (diff) | |
| download | haskell-6beea836094383eea96b15e526f31b5426aea630.tar.gz | |
Make dynflag argument for withTiming pure.
19 times out of 20 we already have dynflags in scope.
We could just always use `return dflags`. But this is in fact not free.
When looking at some STG code I noticed that we always allocate a
closure for this expression in the heap. Clearly a waste in these cases.
For the other cases we can either just modify the callsite to
get dynflags or use the _D variants of withTiming I added which
will use getDynFlags under the hood.
Diffstat (limited to 'compiler/nativeGen')
| -rw-r--r-- | compiler/nativeGen/AsmCodeGen.hs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/compiler/nativeGen/AsmCodeGen.hs b/compiler/nativeGen/AsmCodeGen.hs index c21d3e52f6..7d830d0337 100644 --- a/compiler/nativeGen/AsmCodeGen.hs +++ b/compiler/nativeGen/AsmCodeGen.hs @@ -335,7 +335,7 @@ finishNativeGen :: Instruction instr -> NativeGenAcc statics instr -> IO UniqSupply finishNativeGen dflags modLoc bufh@(BufHandle _ _ h) us ngs - = withTimingSilent (return dflags) (text "NCG") (`seq` ()) $ do + = withTimingSilent dflags (text "NCG") (`seq` ()) $ do -- Write debug data and finish let emitDw = debugLevel dflags > 0 us' <- if not emitDw then return us else do @@ -404,7 +404,7 @@ cmmNativeGenStream dflags this_mod modLoc ncgImpl h us cmm_stream ngs Right (cmms, cmm_stream') -> do (us', ngs'') <- withTimingSilent - (return dflags) + dflags ncglabel (\(a, b) -> a `seq` b `seq` ()) $ do -- Generate debug information let debugFlag = debugLevel dflags > 0 |