diff options
| author | Andreas Klebinger <klebinger.andreas@gmx.at> | 2019-10-20 02:30:01 +0200 |
|---|---|---|
| committer | Andreas Klebinger <klebinger.andreas@gmx.at> | 2019-10-21 16:06:10 +0200 |
| commit | 11f53e604ac6f7029ae8a9e8f4247576490839d4 (patch) | |
| tree | f07df8a51d7514d29b5df8a11896b8f32093f45a /compiler/llvmGen | |
| parent | c4c9904b324736dc5d190a91418e8d8f564d4104 (diff) | |
| download | haskell-wip/andreask/withTimingRefactor.tar.gz | |
Make dynflag argument for withTiming pure.wip/andreask/withTimingRefactor
19 times out of 20 we already have dynflags in scope.
We could just always use `return dflags`. But this is in fact not free.
When looking at some STG code I noticed that we always allocate a
closure for this expression in the heap. Clearly a waste in these cases.
For the other cases we can either just modify the callsite to
get dynflags or use the _D variants of withTiming I added which
will use getDynFlags under the hood.
Diffstat (limited to 'compiler/llvmGen')
| -rw-r--r-- | compiler/llvmGen/LlvmCodeGen.hs | 2 | ||||
| -rw-r--r-- | compiler/llvmGen/LlvmMangler.hs | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/compiler/llvmGen/LlvmCodeGen.hs b/compiler/llvmGen/LlvmCodeGen.hs index b566b99a1f..49b24e8885 100644 --- a/compiler/llvmGen/LlvmCodeGen.hs +++ b/compiler/llvmGen/LlvmCodeGen.hs @@ -45,7 +45,7 @@ llvmCodeGen :: DynFlags -> Handle -> UniqSupply -> Stream.Stream IO RawCmmGroup a -> IO a llvmCodeGen dflags h us cmm_stream - = withTiming (pure dflags) (text "LLVM CodeGen") (const ()) $ do + = withTiming dflags (text "LLVM CodeGen") (const ()) $ do bufh <- newBufHandle h -- Pass header diff --git a/compiler/llvmGen/LlvmMangler.hs b/compiler/llvmGen/LlvmMangler.hs index 114951946c..8215781860 100644 --- a/compiler/llvmGen/LlvmMangler.hs +++ b/compiler/llvmGen/LlvmMangler.hs @@ -25,7 +25,7 @@ import System.IO -- | Read in assembly file and process llvmFixupAsm :: DynFlags -> FilePath -> FilePath -> IO () llvmFixupAsm dflags f1 f2 = {-# SCC "llvm_mangler" #-} - withTiming (pure dflags) (text "LLVM Mangler") id $ + withTiming dflags (text "LLVM Mangler") id $ withBinaryFile f1 ReadMode $ \r -> withBinaryFile f2 WriteMode $ \w -> do go r w hClose r |