diff options
| author | Vladislav Zavialov <vlad.z.4096@gmail.com> | 2019-12-05 03:06:40 +0300 |
|---|---|---|
| committer | Vladislav Zavialov <vlad.z.4096@gmail.com> | 2020-07-20 12:10:03 +0300 |
| commit | 4bda699ce3a3f86486409b3f45f1eb761e3b8265 (patch) | |
| tree | e06ebbafa831b6af7c806b4ef77234b8bdbf95e8 /compiler/flattening-notes | |
| parent | c26e81d116a653b5259aeb290fb1e697efe3382a (diff) | |
| download | haskell-wip/haddock-accum.tar.gz | |
Accumulate Haddock comments in P (#17544, #17561, #8944)wip/haddock-accum
Haddock comments are, first and foremost, comments. It's very annoying
to incorporate them into the grammar. We can take advantage of an
important property: adding a Haddock comment does not change the parse
tree in any way other than wrapping some nodes in HsDocTy and the like
(and if it does, that's a bug).
This patch implements the following:
* Accumulate Haddock comments with their locations in the P monad.
This is handled in the lexer.
* After parsing, do a pass over the AST to associate Haddock comments
with AST nodes using location info.
* Report the leftover comments to the user as a warning (-Winvalid-haddock).
Diffstat (limited to 'compiler/flattening-notes')
0 files changed, 0 insertions, 0 deletions