diff options
| author | Simon Peyton Jones <simonpj@microsoft.com> | 2019-11-29 17:43:58 +0000 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2019-12-05 16:05:43 -0500 |
| commit | c782ce17354cb3a07df0538ecbe42848b8f1dc53 (patch) | |
| tree | 6f7dd7a354913525b14f5fc62d47b78b655b735b /compiler/coreSyn/CorePrep.hs | |
| parent | 1a2ea01946e4318bcc3e1c7d3e16ab9275b6b483 (diff) | |
| download | haskell-wip/T17515.tar.gz | |
Split up coercionKindwip/T17515
This patch implements the idea in #17515, splitting `coercionKind` into:
* `coercion{Left,Right}Kind`, which computes the left/right side of the
pair
* `coercionKind`, which computes the pair of coercible types
This is reduces allocation since we frequently only need only one side
of the pair. Specifically, we see the following improvements on x86-64
Debian 9:
| test | new | old | relative chg. |
| :------- | ---------: | ------------: | ------------: |
| T5030 | 695537752 | 747641152.0 | -6.97% |
| T5321Fun | 449315744 | 474009040.0 | -5.21% |
| T9872a | 2611071400 | 2645040952.0 | -1.28% |
| T9872c | 2957097904 | 2994260264.0 | -1.24% |
| T12227 | 773435072 | 812367768.0 | -4.79% |
| T12545 | 3142687224 | 3215714752.0 | -2.27% |
| T14683 | 9392407664 | 9824775000.0 | -4.40% |
Metric Decrease:
T12545
T9872a
T14683
T5030
T12227
T9872c
T5321Fun
T9872b
Diffstat (limited to 'compiler/coreSyn/CorePrep.hs')
| -rw-r--r-- | compiler/coreSyn/CorePrep.hs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/compiler/coreSyn/CorePrep.hs b/compiler/coreSyn/CorePrep.hs index 4a5891a013..3ce2afc6b8 100644 --- a/compiler/coreSyn/CorePrep.hs +++ b/compiler/coreSyn/CorePrep.hs @@ -51,7 +51,6 @@ import OrdList import ErrUtils import DynFlags import Util -import Pair import Outputable import GHC.Platform import FastString @@ -932,7 +931,7 @@ cpeApp top_env expr (fs, arg') <- cpeArg top_env ss1 arg arg_ty rebuild_app as (App fun' arg') res_ty (fs `appendFloats` floats) ss_rest CpeCast co -> - let Pair _ty1 ty2 = coercionKind co + let ty2 = coercionRKind co in rebuild_app as (Cast fun' co) ty2 floats ss CpeTick tickish -> -- See [Floating Ticks in CorePrep] |