diff options
| author | Simon Marlow <marlowsd@gmail.com> | 2010-03-25 11:03:28 +0000 |
|---|---|---|
| committer | Simon Marlow <marlowsd@gmail.com> | 2010-03-25 11:03:28 +0000 |
| commit | 5c3ea9fb995233c31163d65bee64ab1dca663df4 (patch) | |
| tree | 393573c3b44f28fc478d8829eb4ff50fb2fe4e96 /compiler/codeGen/Bitmap.hs | |
| parent | 813f208a7c04bc740a43cb29ee248b9599415b40 (diff) | |
| download | haskell-5c3ea9fb995233c31163d65bee64ab1dca663df4.tar.gz | |
do_checks: do not set HpAlloc if the stack check fails
This fixes a very rare heap corruption bug, whereby
- a context switch is requested, which sets HpLim to zero
(contextSwitchCapability(), called by the timer signal or
another Capability).
- simultaneously a stack check fails, in a code fragment that has
both a stack and a heap check.
The RTS then assumes that a heap-check failure has occurred and
subtracts HpAlloc from Hp, although in fact it was a stack-check
failure and retreating Hp will overwrite valid heap objects. The bug
is that HpAlloc should only be set when Hp has been incremented by the
heap check. See comments in rts/HeapStackCheck.cmm for more details.
This bug is probably incredibly rare in practice, but I happened to be
working on a test that triggers it reliably:
concurrent/should_run/throwto001, compiled with -O -threaded, args 30
300 +RTS -N2, run repeatedly in a loop.
Diffstat (limited to 'compiler/codeGen/Bitmap.hs')
0 files changed, 0 insertions, 0 deletions