diff options
| author | Joachim Breitner <mail@joachim-breitner.de> | 2015-03-09 16:04:42 +0100 |
|---|---|---|
| committer | Joachim Breitner <mail@joachim-breitner.de> | 2015-03-09 20:22:02 +0100 |
| commit | d01844f145263a038235684900bc7228a799ca6d (patch) | |
| tree | 47399502efe27e29e1bee7b306fd14ab50873724 /compiler/cmm | |
| parent | c439af5f5baa2c8af3434652554135230edbf5c3 (diff) | |
| download | haskell-d01844f145263a038235684900bc7228a799ca6d.tar.gz | |
Remove obsolete comment in cmmOffset
Summary:
as obviously, the code does _not_ adhere to the comment, and yet the
compiler does _not_ go into an infinite loop.
Test Plan: Run validate
Reviewers: austin
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D719
Diffstat (limited to 'compiler/cmm')
| -rw-r--r-- | compiler/cmm/CmmUtils.hs | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/compiler/cmm/CmmUtils.hs b/compiler/cmm/CmmUtils.hs index 65d633e6b7..3ddb9ec002 100644 --- a/compiler/cmm/CmmUtils.hs +++ b/compiler/cmm/CmmUtils.hs @@ -205,13 +205,6 @@ cmmOffsetExpr :: DynFlags -> CmmExpr -> CmmExpr -> CmmExpr cmmOffsetExpr dflags e (CmmLit (CmmInt n _)) = cmmOffset dflags e (fromInteger n) cmmOffsetExpr dflags e byte_off = CmmMachOp (MO_Add (cmmExprWidth dflags e)) [e, byte_off] --- NB. Do *not* inspect the value of the offset in these smart constructors!!! --- because the offset is sometimes involved in a loop in the code generator --- (we don't know the real Hp offset until we've generated code for the entire --- basic block, for example). So we cannot eliminate zero offsets at this --- stage; they're eliminated later instead (either during printing or --- a later optimisation step on Cmm). --- cmmOffset :: DynFlags -> CmmExpr -> Int -> CmmExpr cmmOffset _ e 0 = e cmmOffset _ (CmmReg reg) byte_off = cmmRegOff reg byte_off |