summaryrefslogtreecommitdiff
path: root/compiler/GHC/Unit/Module/Deps.hs
diff options
context:
space:
mode:
authorZubin Duggal <zubin.duggal@gmail.com>2022-02-09 17:01:38 +0530
committerMatthew Pickering <matthewtpickering@gmail.com>2022-02-17 10:35:43 +0000
commit0afa19da629c6f2852e77e134902304b82a91e84 (patch)
tree418f657b01ccac353815a94172c840d3c27fef4d /compiler/GHC/Unit/Module/Deps.hs
parent4127e86dfdfcfce60e5029c716c98c244851779a (diff)
downloadhaskell-wip/th-recomp.tar.gz
Track object file dependencies for TH accurately (#20604)wip/th-recomp
`hscCompileCoreExprHook` is changed to return a list of `Module`s required by a splice. These modules are accumulated in the TcGblEnv (tcg_th_needed_mods). Dependencies on the object files of these modules are recording in the interface. The data structures in `LoaderState` are replaced with more efficient versions to keep track of all the information required. The MultiLayerModulesTH_Make allocations increase slightly but runtime is faster. Fixes #20604 ------------------------- Metric Increase: MultiLayerModulesTH_Make -------------------------
Diffstat (limited to 'compiler/GHC/Unit/Module/Deps.hs')
-rw-r--r--compiler/GHC/Unit/Module/Deps.hs3
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler/GHC/Unit/Module/Deps.hs b/compiler/GHC/Unit/Module/Deps.hs
index 0bab72763b..0da8a06979 100644
--- a/compiler/GHC/Unit/Module/Deps.hs
+++ b/compiler/GHC/Unit/Module/Deps.hs
@@ -52,10 +52,13 @@ import Data.Bifunctor
data Dependencies = Deps
{ dep_direct_mods :: Set (UnitId, ModuleNameWithIsBoot)
-- ^ All home-package modules which are directly imported by this one.
+ -- This may include modules from other units when using multiple home units
, dep_direct_pkgs :: Set UnitId
-- ^ All packages directly imported by this module
-- I.e. packages to which this module's direct imports belong.
+ -- Does not include other home units when using multiple home units.
+ -- Modules from these units will go in `dep_direct_mods`
, dep_plugin_pkgs :: Set UnitId
-- ^ All units needed for plugins