diff options
| author | Finley McIlwaine <finleymcilwaine@gmail.com> | 2023-05-17 13:43:54 -0600 |
|---|---|---|
| committer | Finley McIlwaine <finleymcilwaine@gmail.com> | 2023-05-17 13:43:54 -0600 |
| commit | bc57ee2686dfe011a631bec9f64cb86f03545d3d (patch) | |
| tree | c3727116a88ebd3cc71c32f0c3321f142493f36b /compiler/GHC/Parser/PostProcess/Haddock.hs | |
| parent | 2972fd66f91cb51426a1df86b8166a067015e231 (diff) | |
| download | haskell-wip/haddock-mem-fixes.tar.gz | |
Memory usage fixes for Haddockwip/haddock-mem-fixes
- Do not include `mi_globals` in the `NoBackend` backend. It was only included
for Haddock, but Haddock does not actually need it. This causes a 200MB
reduction in max residency when generating haddocks on the Agda codebase
(roughly 1GB to 800MB).
- Strictly evaluate some SrcSpans in mkDoc{Next,Prev} to avoid thunks
- Strictly evaluate names in rnHsDoc to avoid retaining entire GlobalRdrEnv
- Update Haddock submodule
Diffstat (limited to 'compiler/GHC/Parser/PostProcess/Haddock.hs')
| -rw-r--r-- | compiler/GHC/Parser/PostProcess/Haddock.hs | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/compiler/GHC/Parser/PostProcess/Haddock.hs b/compiler/GHC/Parser/PostProcess/Haddock.hs index 706423c099..82af8bbb03 100644 --- a/compiler/GHC/Parser/PostProcess/Haddock.hs +++ b/compiler/GHC/Parser/PostProcess/Haddock.hs @@ -1360,11 +1360,15 @@ mkDocIE (L l_comment hdk_comment) = span = mkSrcSpanPs l_comment mkDocNext :: PsLocated HdkComment -> Maybe (Located HsDocString) -mkDocNext (L l (HdkCommentNext doc)) = Just (L (mkSrcSpanPs l) doc) +mkDocNext (L l (HdkCommentNext doc)) = + let !src_span = mkSrcSpanPs l + in Just (L src_span doc) mkDocNext _ = Nothing mkDocPrev :: PsLocated HdkComment -> Maybe (Located HsDocString) -mkDocPrev (L l (HdkCommentPrev doc)) = Just (L (mkSrcSpanPs l) doc) +mkDocPrev (L l (HdkCommentPrev doc)) = + let !src_span = mkSrcSpanPs l + in Just (L src_span doc) mkDocPrev _ = Nothing |