diff options
| author | Sylvain Henry <sylvain@haskus.fr> | 2021-08-09 11:29:45 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-08-13 07:54:32 -0400 |
| commit | c367b39e5236b86b4923d826ab0395b33211d30a (patch) | |
| tree | 658e595a18356bcda04f3f72b168eb86bc51bf99 /compiler/GHC/Driver/CodeOutput.hs | |
| parent | 7ad813a480c9ed383fe1fea11a57f90d4f6f9b71 (diff) | |
| download | haskell-c367b39e5236b86b4923d826ab0395b33211d30a.tar.gz | |
Refactoring module dependencies
* Make mkDependencies pure
* Use Sets instead of sorted lists
Notable perf changes:
MultiLayerModules(normal) ghc/alloc 4130851520.0 2981473072.0 -27.8%
T13719(normal) ghc/alloc 4313296052.0 4151647512.0 -3.7%
Metric Decrease:
MultiLayerModules
T13719
Diffstat (limited to 'compiler/GHC/Driver/CodeOutput.hs')
| -rw-r--r-- | compiler/GHC/Driver/CodeOutput.hs | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/compiler/GHC/Driver/CodeOutput.hs b/compiler/GHC/Driver/CodeOutput.hs index 7382ec9a10..87b3af42df 100644 --- a/compiler/GHC/Driver/CodeOutput.hs +++ b/compiler/GHC/Driver/CodeOutput.hs @@ -57,6 +57,8 @@ import GHC.Types.Unique.Supply ( mkSplitUniqSupply ) import System.Directory import System.FilePath import System.IO +import Data.Set (Set) +import qualified Data.Set as Set {- ************************************************************************ @@ -77,7 +79,7 @@ codeOutput -> (a -> ForeignStubs) -> [(ForeignSrcLang, FilePath)] -- ^ additional files to be compiled with the C compiler - -> [UnitId] + -> Set UnitId -- ^ Dependencies -> Stream IO RawCmmGroup a -- Compiled C-- -> IO (FilePath, (Bool{-stub_h_exists-}, Maybe FilePath{-stub_c_exists-}), @@ -134,11 +136,11 @@ outputC :: Logger -> DynFlags -> FilePath -> Stream IO RawCmmGroup a - -> [UnitId] + -> Set UnitId -> IO a -outputC logger dflags filenm cmm_stream packages = +outputC logger dflags filenm cmm_stream unit_deps = withTiming logger (text "C codegen") (\a -> seq a () {- FIXME -}) $ do - let pkg_names = map unitIdString packages + let pkg_names = map unitIdString (Set.toAscList unit_deps) doOutput filenm $ \ h -> do hPutStr h ("/* GHC_PACKAGES " ++ unwords pkg_names ++ "\n*/\n") hPutStr h "#include \"Stg.h\"\n" |