diff options
| author | Krzysztof Gogolewski <krzysztof.gogolewski@tweag.io> | 2021-06-17 10:44:05 +0200 |
|---|---|---|
| committer | Krzysztof Gogolewski <krzysztof.gogolewski@tweag.io> | 2021-06-18 21:43:53 +0200 |
| commit | 86f58f59fca3b2540ddcc301cb955683be8e907b (patch) | |
| tree | 7b7bb5ec5f8a79224c7bb9e752e6ecafb97fa5a3 /compiler/GHC/Core/Lint.hs | |
| parent | a0622459f1d9a7068e81b8a707ffc63e153444f8 (diff) | |
| download | haskell-wip/minor-comments.tar.gz | |
Typos, minor comment fixeswip/minor-comments
- Remove fstName, sndName, fstIdKey, sndIdKey - no longer used,
removed from basicKnownKeyNames
- Remove breakpointId, breakpointCondId, opaqueTyCon, unknownTyCon -
they were used in the old implementation of the GHCi debugger
- Fix typos in comments
- Remove outdated comment in Lint.hs
- Use 'LitRubbish' instead of 'RubbishLit' for consistency
- Remove comment about subkinding - superseded by
Note [Kind Constraint and kind Type]
- Mention ticket ID in a linear types error message
- Fix formatting in using-warnings.rst and linear-types.rst
- Remove comment about 'Any' in Dynamic.hs - Dynamic
now uses Typeable + existential instead of Any
- Remove codeGen/should_compile/T13233.hs
This was added by accident, it is not used and T13233 is already in
should_fail
Diffstat (limited to 'compiler/GHC/Core/Lint.hs')
| -rw-r--r-- | compiler/GHC/Core/Lint.hs | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/compiler/GHC/Core/Lint.hs b/compiler/GHC/Core/Lint.hs index 45115bfb45..33902af853 100644 --- a/compiler/GHC/Core/Lint.hs +++ b/compiler/GHC/Core/Lint.hs @@ -155,16 +155,6 @@ We check for If we have done specialisation the we check that there are (a) No top-level bindings of primitive (unboxed type) -Outstanding issues: - - -- Things are *not* OK if: - -- - -- * Unsaturated type app before specialisation has been done; - -- - -- * Oversaturated type app after specialisation (eta reduction - -- may well be happening...); - - Note [Linting function types] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ As described in Note [Representation of function types], all saturated @@ -1740,11 +1730,11 @@ lintTySynFamApp report_unsat ty tc tys ; return (TyConApp tc tys') } ----------------- --- Confirms that a type is really *, #, Constraint etc +-- Confirms that a type is really TYPE r or Constraint checkValueType :: LintedType -> SDoc -> LintM () checkValueType ty doc = lintL (classifiesTypeWithValues kind) - (text "Non-*-like kind when *-like expected:" <+> ppr kind $$ + (text "Non-Type-like kind when Type-like expected:" <+> ppr kind $$ text "when checking" <+> doc) where kind = typeKind ty |