diff options
| author | Ben Gamari <ben@smart-cactus.org> | 2020-11-25 10:54:31 -0500 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2020-11-27 06:20:41 -0500 |
| commit | a1a75aa9be2c133dd1372a08eeb6a92c31688df7 (patch) | |
| tree | 8d389d7a541d2136ed4fc09c795ae88a2a2ae58d | |
| parent | 3e3555cc9c2a9f5246895f151259fd2a81621f38 (diff) | |
| download | haskell-a1a75aa9be2c133dd1372a08eeb6a92c31688df7.tar.gz | |
rts: Allocate MBlocks with MAP_TOP_DOWN on Windows
As noted in #18991, we would previously allocate heap in low memory.
Due to this the linker, which typically *needs* low memory, would end up
competing with the heap. In longer builds we end up running out of
low memory entirely, leading to linking failures.
| -rw-r--r-- | rts/win32/OSMem.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/rts/win32/OSMem.c b/rts/win32/OSMem.c index dd53f4d589..138660a879 100644 --- a/rts/win32/OSMem.c +++ b/rts/win32/OSMem.c @@ -50,8 +50,11 @@ allocNew(uint32_t n) { alloc_rec* rec; rec = (alloc_rec*)stgMallocBytes(sizeof(alloc_rec),"getMBlocks: allocNew"); rec->size = ((W_)n+1)*MBLOCK_SIZE; + // N.B. We use MEM_TOP_DOWN here to ensure that we leave the bottom of the + // address space available for the linker and libraries, which in general + // want to live in low memory. See #18991. rec->base = - VirtualAlloc(NULL, rec->size, MEM_RESERVE, PAGE_READWRITE); + VirtualAlloc(NULL, rec->size, MEM_RESERVE | MEM_TOP_DOWN, PAGE_READWRITE); if(rec->base==0) { stgFree((void*)rec); rec=0; |