| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=373745
|
|
|
|
| |
This explains the change in the previous commit.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=765122
|
|
|
|
|
|
|
|
|
|
|
| |
The previous patches didn't mark some strings as to be translated, and
tried to translate strings with a variable part already inside the
string, which isn't going to work.
Mark the strings as translatable with context, and also make sure to
translate static strings when getting them out of their structure.
https://bugzilla.gnome.org/show_bug.cgi?id=764585
|
|
|
|
|
|
| |
Notice that C_ just takes string literals as arguments.
https://bugzilla.gnome.org/show_bug.cgi?id=764585
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=764585
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=764585
|
|
|
|
|
|
| |
Some of the translated strings in the cups printbackend are short
and generic and might occur in other contexts. Give them disambiguating
message contexts to avoid translation problems.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to update calls to gtk_style_context_set_state() in
gtkimcontextime.c, so that the state passed into that function would be in
line with what GtkStyleContext expects, due to updates in the CSS
machinery, as outlined in this link[1], which is based on information in
in Matthias' blog[2].
Doing so will silence the gtk_style_context_set_state() warnings, which is
emitted when a widget uses gtkimcontext on Windows with CJK IME, which will
in turn call gtkimcontextime.
[1]: http://feaneron.com/2016/01/04/quick-guide-to-port-an-app-for-gtk-3-20/
[2]: https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/
https://bugzilla.gnome.org/show_bug.cgi?id=760314
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=728344
|
|
|
|
|
|
| |
Replace checking if the NSView is really a GdkWindow, which will crash
in the likely event it's not a GObject, with ensuring that the parent
GdkWindow is really a GdkWindowQuartz.
|
|
|
|
|
|
|
|
|
|
| |
GTK+ currently does not support printer instances in the printing
dialog. This commit avoids user options set for specific instances of
a printer being accidently applied to the printer with the same name but
no specific instance defined.
https://bugzilla.gnome.org/show_bug.cgi?id=753628
https://bugzilla.gnome.org/show_bug.cgi?id=582747
|
|
|
|
|
|
|
|
|
|
|
| |
In order to retrieve the user options for a printer, the respective
printer name is used.
This fixes the comparison of printer names to avoid that the options of
another printer are accidently read whose name starts with the same
letters, but is longer (e.g. "myprinterlongername" instead of
"myprinter").
This fixes Bug 753628.
|
|
|
|
|
|
|
|
| |
When clearing the compose buffer, don't emit preedit-changed
unconditionally. This triggers a recursion which leads to
a crash.
https://bugzilla.gnome.org/show_bug.cgi?id=753644
|
|
|
|
|
| |
We're closing this fd, but we're not going to do anything else
if that fails. Annotate to let coverity see this.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Yo, we heard you like traversing NULL-terminated arrays to operate on
them, so we called g_strv_length() as the for condition, so you can
iterate the array while iterating the array."
Instead of making famed rapper and television producer Xzibit proud, we
should avoid calling g_strv_length() on an array while looping on the
array, to avoid quadratic complexity.
We do this in various places that deal with arrays of strings that we
cannot really guess are short enough not to matter — e.g. the list of
CSS selectors in the inspector, or the required authentication
information for printing.
|
|
|
|
|
|
|
|
|
| |
Request "output-bin-supported" and "output-bin-default" attributes through
IPP if there is no PPD for selected printer.
Pass "output-bin" option with other options in printer_get_options().
Translate standard IPP values of "output-bin" option.
https://bugzilla.gnome.org/show_bug.cgi?id=725441
|
|
|
|
| |
Fix warnings due to -Wdeclaration-after-statement and -Wshadow.
|
|
|
|
|
|
|
| |
Add parameter for specification of port to gtk_cups_connection_cups_new().
Use default port returned by ippPort() if the given port is lower than 0.
https://bugzilla.gnome.org/show_bug.cgi?id=693738
|
|
|
|
|
|
|
|
|
| |
If auth_info_required is only set to "negotiate" the
request password dialog is shown anyway for each print
job without any input fields. As the request_password
dialog only handles username, password and domain.
https://bugzilla.gnome.org/show_bug.cgi?id=669008
|
|
|
|
|
|
|
| |
Consider NULL printer state message as empty too.
Printer state IPP_PRINTER_STOPPED can be considered as paused state.
https://bugzilla.gnome.org/show_bug.cgi?id=743323
|
|
|
|
|
|
|
|
| |
Request details of Avahi browsed printers even when
we've got their PPDs already. Some options are not
present in PPD.
https://bugzilla.gnome.org/show_bug.cgi?id=743323
|
|
|
|
|
|
|
|
| |
Since we combine Avahi browsed printers and
printers of local CUPS in one backend we need to
get covers for each printer separately.
https://bugzilla.gnome.org/show_bug.cgi?id=743323
|
|
|
|
|
|
|
|
|
| |
This was added a few years ago, as a way to have _no_ im context
at all. But it didn't actually work. Make it work, and streamline
the handling of none by moving it all to gtkimmodule.c.
As part of this, add context to the translated names of all
im modules we ship.
|
|
|
|
|
| |
cups_printer_get_hard_margins() returned margins in millimeters
for margins taken via IPP request instead of Units used before.
|
|
|
|
|
|
|
|
|
|
|
|
| |
g_utf8_get_char_validated() may return -1 or -2
return type is gunichar(guint32)
Therefore such checks like 'gunichar < 0' or 'gunichar > 0'
are always 'false' or 'true'(except when gunichar == 0).
Signed-off-by: Maks Naumov <maksqwe1@ukr.net>
https://bugzilla.gnome.org/show_bug.cgi?id=742774
|
| |
|
|
|
|
|
|
|
| |
Define missing functions ippFirstAttribute(), ippNextAttribute()
and macro ippGetCollection(). These were added in CUPS 1.6.
https://bugzilla.gnome.org/show_bug.cgi?id=740358
|
|
|
|
|
|
|
|
|
|
| |
We directly get the length of the secret from the g_variant
and use it in a following g_strndup which ensures that the
resulting string is terminated.
This fixes reading secrets which were stored by system-config-printer.
https://bugzilla.gnome.org/show_bug.cgi?id=740612
|
|
|
|
|
|
|
| |
Fix a typo which caused that "number-up-supported" and "media-col-default"
IPP attributes were not requested correctly.
https://bugzilla.gnome.org/show_bug.cgi?id=725441
|
|
|
|
|
|
|
|
|
|
|
|
| |
Request "sides-supported" and "sides-default" attributes through
IPP if there is no PPD for selected printer.
Pass "sides" option with other options in printer_get_options().
Add function setup_ipp_option() for creating of IPP option
of given name with passed choices and default value.
Mark such an option as "is-ipp-option" so we can distinguish it
later.
https://bugzilla.gnome.org/show_bug.cgi?id=725441
|
|
|
|
|
|
|
|
|
|
| |
Query printer via IPP for paper sizes if there is no
or empty PPD file.
Parse "media-supported" and "media-size-supported" attributes for list
of paper sizes. Parse "media-default" and "media-col-default" attributes
for default settings.
https://bugzilla.gnome.org/show_bug.cgi?id=725441
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=725441
|
|
|
|
| |
Just use regular GtkWindow styling instead.
|
|
|
|
|
|
|
|
| |
Remove checks for NULL before g_free() and g_clear_object().
Merge check for NULL, freeing of pointer and its setting
to NULL by g_clear_pointer().
https://bugzilla.gnome.org/show_bug.cgi?id=733157
|
|
|
|
|
|
| |
Use U+201C/U+201D for quoting.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
|
|
|
|
|
|
| |
Use U+007D MULTPLICATION SIGN for dimensions.
https://bugzilla.gnome.org/show_bug.cgi?id=735192
|
|
|
|
|
|
|
| |
This simplifies the code and - more importantly - fixes the cases like
in testsuite/reftests where the no_undefined definition was missing.
https://bugzilla.gnome.org/show_bug.cgi?id=736382
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a printer requires auth_info (e.g. a printer connected
over the samba protocol) it is now possible to save the
credentials necessary for printing if a secrets service
is available over dbus.
The auth_info is then stored / loaded from the default
collection of that secrets service.
If no such service is available the user is not shown
the option to remember the password and the behavior
remains the same as before.
https://bugzilla.gnome.org/show_bug.cgi?id=674264
|
|
|
|
|
|
|
|
| |
Similar to Bug #684123 in GLib.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=641638
Bug-Debian: https://bugs.debian.org/756476
Reviewed-by: Matthias Clasen
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=734735
|
|
|
|
|
| |
We should only use the PageSize option from the ppd if it
actually exists.
|
|
|
|
| |
Instead "Return value:" or "Return:"
|
|
|
|
|
|
|
|
| |
Moving the inspector into libgtk lets use reuse internals without
having to add public API for everything or inventing awkward private
call conventions.
https://bugzilla.gnome.org/show_bug.cgi?id=730095
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Move the show updates and flip text direction controls here,
and add controls for baseline and pixel cache debugging.
|
| |
|
|
|
|
|
| |
Add rudimentary signal tracing. The signals tab can now count signal
emissions for all signals of the current object.
|