summaryrefslogtreecommitdiff
path: root/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Annotate sequence argument of GtkGesture signals as nullableSebastian Dröge2020-09-021-5/+5
|
* searchengine: Prepare for apps linking to Tracker 2.xCarlos Garnacho2020-09-012-10/+32
| | | | | | | | | | Given it does seem likely Tracker is going to miss the goal to get all applications ported to Tracker 3, the scenario where there's applications linking to Tracker 2.x while GTK was built with Tracker 3 support becomes more likely. Avoid the upcoming GType clashes if that were the case, and resort to the good (I lie) old Tracker 2 search engine.
* Adwaita: error labels insensitive & backdrop statesJakub Steiner2020-08-183-1/+13
| | | | | | - address colored labels for the two states See https://gitlab.gnome.org/GNOME/gtk/-/issues/3063#note_891618
* Adwaita: error labels and entriesJakub Steiner2020-08-143-0/+12
| | | | See https://gitlab.gnome.org/GNOME/gtk/-/issues/3063
* Adwaita: add public color for text viewsJakub Steiner2020-08-073-0/+9
| | | | | | | - define @text_view_bg to complement @theme_text_color for high contrast legible text views. Fixes https://gitlab.gnome.org/GNOME/vte/-/issues/226
* Adwaita: sass wasn't re-renderedJakub Steiner2020-08-072-102/+102
| | | | - particularly the typographic fix c80ac1c05dde663aa7763eff90ca781c9ae22787
* Merge branch 'wip/oholy/gtkmountoperation-newline-gtk-3-24' into 'gtk-3-24'Matthias Clasen2020-08-071-9/+6
|\ | | | | | | | | gtkmountoperation: Drop the new line character when splitting a message See merge request GNOME/gtk!2400
| * gtkmountoperation: Drop the new line character when splitting a messageOndrej Holy2020-08-071-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | When asking for a password, the message string is split on primary and secondary if it contains a newline character. However, the newline character is currently part of both strings, which creates weird spacing between the GtkLabels. I suppose this is bug, which was not visible as in most cases (if not all) the message string hasn't contained the new line characters so far. But we are going to change that now, see GNOME/gvfs!82. Let's drop the new line character similarly as it is done when asking for a question, or showing processes in order to fix the weird spacing.
* | Merge branch 'cherry-pick-267ea755' into 'gtk-3-24'Matthias Clasen2020-08-071-1/+15
|\ \ | |/ |/| | | | | placesview: Always open default location after mounting See merge request GNOME/gtk!1288
| * placesview: Always open default location after mountingOndrej Holy2020-01-061-1/+15
| | | | | | | | | | | | | | | | | | | | | | The default location (obtained over g_mount_get_default_location) is opened after mounting volume, or when opening mounts from sidebar, but not after mounting over "Connect to Server". Let's unify the behavior and always open the default location. https://gitlab.gnome.org/GNOME/nautilus/issues/1319 (cherry picked from commit 267ea7552b35eb6eaf83767d58d0bef56ffd029a)
* | Visual Studio projects: move projects to win32/Chun-wei Fan2020-07-161-7/+7
| | | | | | | | This will simplify our source tree a bit
* | gtk/gtkfilechoosernativeportal.c: Fix on C89 compilersChun-wei Fan2020-07-161-1/+3
| | | | | | | | | | Make sure we declare variables at the top of the block-we can't declare variables in a for loop initilization in this case.
* | gtkcssshadowvalue.c: Fix build on older Visual StudioChun-wei Fan2020-07-162-1/+13
| | | | | | | | | | | | | | This code made use of isnan(), which is not provided by pre-2013 Visual Studio, so fix the build by including fallback-c89.c in place of math.h, and update fallback-c89.c to include the implementation of isnan() for Visual Studio, which is copied from the fallback-c89.c in gdk/.
* | Adwaita: revert letter-spacing for large-titleJakub Steiner2020-07-141-1/+0
| | | | | | | | Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2932
* | Merge branch 'wip/sadiq/fix-entry-magnifier' into 'gtk-3-24'Matthias Clasen2020-07-131-0/+1
|\ \ | | | | | | | | | | | | entry: Restrict magnifier popover within the entry size See merge request GNOME/gtk!2228
| * | entry: Restrict magnifier popover within the entry sizeMohammed Sadiq2020-07-121-0/+1
| | | | | | | | | | | | | | | The magnifier shown with touch input should not go beyond the widget limits.
* | | text-view: Fix select-all from touch bubbleMohammed Sadiq2020-07-131-1/+5
|/ / | | | | | | | | | | The 'select-all' signal requires a boolean argument to specify whether to select all or none. So explicitly pass TRUE to select all text instead of letting the demons choose one for us.
* | Merge branch 'wip/smcv/gtk3-gresource-internal' into 'gtk-3-24'Matthias Clasen2020-07-091-2/+2
|\ \ | | | | | | | | | | | | build: Don't export GResource-related symbols with newer GLib See merge request GNOME/gtk!2218
| * | build: Don't export GResource-related symbols with newer GLibSimon McVittie2020-07-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the desired behaviour explicit, and matches the behaviour seen with Meson, where "external : false" is the default. Before GNOME/glib!1468, not passing --internal to the resource compiler meant "no special export attribute, do what you would normally do", so these symbols were not exported due to our global use of -fvisibility=hidden. However, since GNOME/glib!1468, not passing --internal to the resource compiler results in the symbols being decorated with G_MODULE_EXPORT, which overrides -fvisibility=hidden. This was necessary because Windows DLLs normally behave a bit like the equivalent of ELF libraries with -fvisibility=hidden. Signed-off-by: Simon McVittie <smcv@debian.org> Resolves: https://gitlab.gnome.org/GNOME/gtk/-/issues/2919
* | | autotools: Teach about tracker3 search engineCarlos Garnacho2020-07-091-0/+9
|/ / | | | | | | | | | | | | | | Add --enable-tracker3 option (off by default, like in meson) and hook the tracker3 search engine to build. Also, make sure it's part of dist. Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/2912
* | Merge branch 'printing-portal-fix' into 'gtk-3-24'Matthias Clasen2020-07-091-1/+8
|\ \ | | | | | | | | | | | | Printing portal fix See merge request GNOME/gtk!2210
| * | Remember to call print_cb even if print operation is cancelled.Casey Jao2020-07-081-1/+8
| | | | | | | | | | | | Closes #2917.
* | | Merge branch 'gtk3-fix-menu-touch' into 'gtk-3-24'Emmanuele Bassi2020-07-071-1/+6
|\ \ \ | |/ / |/| | | | | | | | menu: Fix touch support by using pointer emulation under X11 See merge request GNOME/gtk!1794
| * | Remove platform specific codeAlynx Zhou2020-05-111-17/+1
| | |
| * | menu: Fix touch support by using pointer emulation under X11Alynx Zhou2020-04-301-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GtkMenu under X11 cannot handle touch events properly, so just disable touchscreen grabbing for it, which makes it fallback to pointer emulation. Closes https://gitlab.gnome.org/GNOME/gtk/-/issues/945 menu: Fix grab on other backend
* | | textview: invalidate pixelcache for some invisible changesChristian Hergert2020-06-291-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When making changes above the current visible region, we might need to invalidate the pixelcache as the Y positions will no longer match. This usually is not needed because changes are made interactively and are made onscreen. Other cases, though, can include an application changing the first line of the buffer automatically. We lose the ability to pixelcache well in this scenario, but that is unlikely an issue since rapid Y geometry resize or scrolling is less likely to be occuring. For situations where this is an issue, you can avoid removing the \n from the buffer so line heights are uneffected. Fixes #2882
* | | Merge branch 'quantize-corner-mask-cache' into 'gtk-3-24'Matthias Clasen2020-06-291-10/+52
|\ \ \ | | | | | | | | | | | | | | | | CSS: Quantization for corner mask cache See merge request GNOME/gtk!2103
| * | | Limit corner mask cacheLuca Bacci2020-06-291-0/+13
| | | | | | | | | | | | | | | | Fixes issue #2853
| * | | Quantization for corner mask cacheLuca Bacci2020-06-291-10/+39
| | | | | | | | | | | | | | | | Fixes issue #2853
* | | | Merge branch 'adwaita-fix-gtk-3-24' into 'gtk-3-24'Jakub Steiner2020-06-243-117/+117
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Remove .tile from checkbox style selector See merge request GNOME/gtk!2018
| * | | | Adwaita: Remove .tile from checkbox style selectorNeville2020-06-033-117/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently .tile style is required for the larger blue checkboxes. The .tile style is removed since it adds unwanted style to elements. Also the selector to ignore list elements has been modified since it currently checks for checkboxes that are not lists.
* | | | | Merge branch 'cursor-aspect-ratio-for-3' into 'gtk-3-24'Matthias Clasen2020-06-232-6/+22
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add a gtk-cursor-aspect-ratio setting See merge request GNOME/gtk!2144
| * | | | | Add a gtk-cursor-aspect-ratio settingcursor-aspect-ratio-for-3Matthias Clasen2020-06-232-6/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a setting that controls how thick the text caret is drawn. This setting replaces a style property that we used to have. The default value is 0.04.
* | | | | | Adwaita: notebook legibility fixesJakub Steiner2020-06-233-31/+32
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | - make inactive tabs more legible Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2652
* | | | | [Quartz]Silence type mismatch warning.John Ralls2020-06-201-2/+5
| | | | |
* | | | | quartz: gtk-application - inhibit openFiles events from cmdlineFriedrich Beckmann2020-06-181-0/+7
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an application is started via cmdline, then openFiles events from MacOS are generated although gtkapplication already interprets the cmdline arguments and opens suitable arguments as files. So they would be opened twice. Depending on the exact situation the openFiles event can also be issued before the startup signal is given. Depending on the application this can result in a crash due to unexpected behaviour. I took this idea from the gedit-app-osx.m file. Also from Jesse van den Kieboom. See: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/2098#note_842975 https://gitlab.gnome.org/GNOME/gtk/-/commit/a3ad7fa80f764fb7bcbe https://gitlab.gnome.org/GNOME/gedit/-/blob/master/gedit/gedit-app-osx.m#L592
* | | | Merge branch 'gtk-application-quartz' into 'gtk-3-24'Matthias Clasen2020-06-161-0/+30
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | quartz: Bugfix - Add openFiles delegate to gtk_application (#463) See merge request GNOME/gtk!2098
| * | | | quartz: added open capability to gtk_applicationFriedrich Beckmann2020-06-161-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch implements the openFiles delegate which is required to open files which are associated with an application via the Finder or via open on the command line. The patch has been proposed by jessevdk@gmail.com. See: https://gitlab.gnome.org/GNOME/gtk/-/issues/463 I tested the patch with the GNU pspp application on MacOS with the quartz backend.
* | | | | Merge branch 'benzea/fix-css-update' into 'gtk-3-24'Benjamin Otte2020-06-151-2/+2
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Fix CSS update loop See merge request GNOME/gtk!2093
| * | | | cssnode: Don't queue_validate/deque_validate invisible nodesBenjamin Berg2020-06-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise setting/unsetting the parrent may cause on an invisible widget may cause the style to be continuously updated. Fixes: #2849
* | | | | Merge branch ↵Matthias Clasen2020-06-151-0/+30
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'michaelweghorn/issue1820_gtkfilechoosernativeportal_get_filter' into 'gtk-3-24' Make gtk_file_chooser_get_filter work for the portal GtkFileChooserNative (issue #1820) See merge request GNOME/gtk!1960
| * | | | | Make gtk_file_chooser_get_filter work for portal caseMichael Weghorn2020-06-091-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes 'gtk_file_chooser_get_filter' work for the portal native file chooser by handling the corresponding 'current_filter' argument in the response retrieved via D-Bus. In order to try to map the retrieved 'current_filter' to one of the existing list of filters, use the retrieved filter's name, similar to how xdg-desktop-portal-gtk does it when evaluating the 'current_filter' input parameter in 'options'.) Note: This depends on the following merge/pull requests which fix the filter handling in gtk for native file choosers and introduce the 'current_filter' handling for FileChooser portal. * https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1959 * https://github.com/flatpak/xdg-desktop-portal/pull/493 * https://github.com/flatpak/xdg-desktop-portal-gtk/pull/311 This fixes #1820 for desktop portal case. Fixes: #1820
* | | | | | Merge branch 'michaelweghorn/issue1820_gtkfilechoosernative_get_filter' into ↵Matthias Clasen2020-06-151-0/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'gtk-3-24' gtk_file_chooser_get_filter Make gtk_file_chooser_get_filter work for the non-portal GtkFileChooserNative (issue #1820) See merge request GNOME/gtk!1959
| * | | | | filechoosernative: Make get_filter work for (non-portal) native chooserMichael Weghorn2020-05-231-0/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'gtk_file_chooser_get_filter' did not work for GtkFileChooserNative, since the previous way did not properly handle the delegate dialog, s.a. commit a136cbae8f8848d49976512f7f0ec73137428ea0 ("filechoosernative: forward current_filter to delegate dialog", 2018-11-29) for details, wich basiscally fixed the same thing for the 'gtk_file_chooser_set_filter' case. This fixes #1820 for the fallback dialog. A solution for the portal one (which also requires changes to xdg-desktop-portal and xdg-desktop-portal-gtk as well) will be suggested in a subsequent step. Bug: #1820
* | | | | gtkbuilder: Eliminate array reallocations in get_parameters()Philip Withnall2020-06-103-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `gtk_builder_get_parameters()` is a hot path, being called twice for each object in each UI file in an application. The majority of objects have ≤ 8 properties, which are each filtered into either `parameters` or `filtered_parameters`. Unfortunately, both of those arrays are created as empty `GArray`s, and adding 8 elements to an empty `GArray` hits the worst possible case of reallocating and `memcpy()`ing the array 3 times. As the array size is doubled with each reallocation, the cost is not particularly well amortised when the array size is small. From the `ObjectInfo`, we actually know how many properties there are in total, so just allocate the arrays at the right size to begin with. This saves 7% of the instruction cycles needed to start up gnome-software to the point where it’s showing its main window, according to callgrind. gnome-software is making around 5500 calls to `gtk_builder_get_parameters()`. Signed-off-by: Philip Withnall <withnall@endlessm.com>
* | | | | gtk_file_chooser_set_current_name: fix type of name argumentThomas Holder2020-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | The description says UTF-8 string, but the annotation said filename.
* | | | | Merge branch 'issue-2820' into 'gtk-3-24'Emmanuele Bassi2020-06-051-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | docs: Update the link to the GtkBuilder schema See merge request GNOME/gtk!2042
| * | | | | docs: Update the link to the GtkBuilder schemaEmmanuele Bassi2020-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The link to the file is still using the old cgit format, which redirects to master, where the RNC file is gone. Fixes: #2820
* | | | | | flowbox: Don't use a removed child after it has been unparentedKjell Ahlstedt2020-06-041-1/+1
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | In gtk_flow_box_remove(), call g_sequence_remove() before the child is unparented. See MR !2029
* | | | | Merge branch 'gtk-3-24' into 'gtk-3-24'Matthias Clasen2020-06-011-7/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix GPtrArray sorting function See merge request GNOME/gtk!1984
View Lorry Controller Status