summaryrefslogtreecommitdiff
path: root/gtk
Commit message (Collapse)AuthorAgeFilesLines
* stack: Only map children when necessaryFlorian Müllner2016-05-231-2/+1
| | | | | | | | | | | gtk_widget_set_parent() will map the widget if the parent is mapped and the widget is both visible and child-visible. As we currently only set the child visibility after adding the child, we immediately map all children that are added to a mapped stack, even when they are not actually shown. Avoid this by setting the child visibility before adding the child, so widgets are only mapped when shown. https://bugzilla.gnome.org/show_bug.cgi?id=766737
* treeview: Fix a rubberbanding-related crashMatthias Clasen2016-05-231-14/+41
| | | | | | | | When starting a rubberband selection from an empty area, we could run into crashes if the selection moves over the rows and then back out to unpopulated area. Handle this case without crashing. https://bugzilla.gnome.org/show_bug.cgi?id=766336
* popover: set priv->window before setting doing add_popover() on itCarlos Garnacho2016-05-211-4/+4
| | | | | | | | | | | | If the popover's relative-to widget is unparented/reparented, we end up unparenting/reparenting the popover as well. In that case, at the moment of reparenting, the widget might have been visible (and is thus mapped again), but priv->window hasn't been set yet. We must first set priv->window, and then call gtk_window_add_popover(), that way gtk_popover_map() has its prerequisites straight. https://bugzilla.gnome.org/show_bug.cgi?id=766323
* Adwaita: add vertical margins to switches on a headerbarLapo Calamandrei2016-05-203-1/+11
| | | | See https://bugzilla.gnome.org/show_bug.cgi?id=766642
* Adwaita: shave 1px from the switchLapo Calamandrei2016-05-203-6/+6
| | | | make the switch height and width 1px smaller.
* Revert "scrolledwindow: Remove child before destroying self"Matthias Clasen2016-05-201-5/+0
| | | | | | | | This reverts commit dcb4b48b29559ca632bb020a3b8eb2b9188b02e7. This was causing crashes in the filechooser in some applications. https://bugzilla.gnome.org/show_bug.cgi?id=766694
* gtktextview: fix < public > commentIgnacio Casal Quinteiro2016-05-201-1/+1
| | | | This was causing problems with the gtk# scanner
* scrolledwindow: Fix typo in get_preferred_height calculationDebarshi Ray2016-05-191-3/+3
| | | | | | | | | | | | | | | | | When we are beginning to calculate the height, if the vscrollbar_policy is not GTK_POLICY_NEVER, and there is no min-content-height, then we need some small non-zero value to get started. The idea is to always ask for at least enough to fit the horizontal scrollbar. Simply put, this should be the mirror image of the corresponding width calculation code. Those who got used to the buggy behaviour might notice that their GtkScrolledWindows are not as tall as they used to be. Fall out from 55196a705f00564a44647bfc97981db0a783369a https://bugzilla.gnome.org/show_bug.cgi?id=766530
* icon theme: Add a warningMatthias Clasen2016-05-191-1/+24
| | | | | | | Warn about the situation when we've found a resource or file path, but gdk-pixbuf fails to give us a pixbuf. This generally means that either pixbuf loaders are not found or the shared-mime database is missing.
* stack: Don't underallocate the last_childTimm Bäder2016-05-191-4/+9
|
* stack: Remove some code duplicationTimm Bäder2016-05-191-6/+2
|
* places sidebar: Avoid markup confusion in tooltipsMatthias Clasen2016-05-191-4/+1
| | | | | | | | At one point, the sidebar was using gtk_treeview_set_tooltip_column, which expects tooltips to be markup. With the listbox-based sidebar, we don't do that anymore. So don't escape the tooltip text. https://bugzilla.gnome.org/show_bug.cgi?id=766175
* scale: Remove double nullable annotationTimm Bäder2016-05-191-1/+1
| | | | | Being both (allow-none) and (nullable) at the same time is a bit much. Was from 591e7f5ef8538982e227b2c2cefc536a33cafa6c.
* widget: Add Since annotation to gtk_widget_queue_allocateTimm Bäder2016-05-191-0/+2
|
* scrolledwindow: Remove child before destroying selfBenjamin Otte2016-05-191-0/+5
| | | | | | Children tend to call back into the scrolled window while being removed and that doesn't work too well if the scrolled window is destroyed already as Christian Hergert found out.
* cssimage: Make it possible to shrink builtin check/optionmarksBenjamin Otte2016-05-191-30/+10
| | | | ... below 7px of size.
* revealer: emit notify::child-revealed when animation stopsMatthieu Gautier2016-05-191-2/+5
| | | | | | | | | | | | Depending of float rounding during target calculation, the size of the GtkRevealer can be set to zero will the animation is not finished. If the GtkRevealer is in a GtkPaned, it will be hidden and so the animation will be stopped before it is finished. In this case, force the emission of the child-revealed signal to let client code know the animation is finished. https://bugzilla.gnome.org/show_bug.cgi?id=765973
* infobar: Fix typoTimm Bäder2016-05-191-1/+1
| | | | Style class names are prefixed with a '.'
* Adwaita: fix scale themingLapo Calamandrei2016-05-193-176/+132
| | | | | | rely on toplevel styleclass for scale with marks. See https://bugzilla.gnome.org/show_bug.cgi?id=766440
* color scale: Really sync style classes with GtkScaleLapo Calamandrei2016-05-191-1/+1
| | | | sync the alpha scale styleclass too.
* color scale: Sync style classes with GtkScaleMatthias Clasen2016-05-191-2/+2
| | | | | We should use the same style classes here, to avoid theme confusion.
* gtkselectionprivate: minor style fixIgnacio Casal Quinteiro2016-05-191-1/+1
| | | | This seems to make some issue with the gtk# scanner.
* scale: Use more succinct names for style classesMatthias Clasen2016-05-191-7/+7
| | | | | | | | | Use .marks-before/after to indicate the presence of marks. As Lapo points out, compatibility with the previous names is not really that important, since everything else changed around it. https://bugzilla.gnome.org/show_bug.cgi?id=766440
* scale: Bring back marks-related style classesMatthias Clasen2016-05-181-1/+20
| | | | | | | | | | It turns out that it is too hard (and in some cases, impossible) to get this information from node positioning, so bring back the .scale-has-marks-above/below style classes on the main node. This should allow us to fix the 'pointy sliders'. https://bugzilla.gnome.org/show_bug.cgi?id=766440
* Docs: Clarify life cycle issueMatthias Clasen2016-05-171-0/+4
| | | | | | | gtk_gesture_get_last_event() wasn't very clear about how long it is safe to use the returned pointer. (cherry picked from commit c891ceb31df1fb16c7727be46cee4d8a9fc0b447)
* DND: Avoid a use-after-freeMatthias Clasen2016-05-171-3/+7
| | | | | | | | Cancelling the gesture causes the last_event pointer to become invalid. Make a copy of the event so we can keep using it regardless of the gesture state. (cherry picked from commit 358eec297204b438809692a24cc3649658dbab5a)
* docs: Update examples of matching key bindingsEmmanuele Bassi2016-05-091-6/+9
| | | | | | The selector for matching GtkEntry has changed to `entry` after 3.20. https://bugzilla.gnome.org/show_bug.cgi?id=766166
* Adwaita: relocate a selectorLapo Calamandrei2016-05-063-10/+6
| | | | | relocate treview acceleditor > label in the treeview section and add a comment for a testcase.
* Adwaita: tidy treeview style properties...Lapo Calamandrei2016-05-063-23/+23
| | | | ...removing a double definition in the process.
* scale: Fix mark positioning at the left/top edgeMatthias Clasen2016-05-051-1/+5
| | | | | | | We were failing to take the widget allocation.x/y into account when deciding whether we need to push in the mark. https://bugzilla.gnome.org/show_bug.cgi?id=765922
* searchenginetracker: Quote fts match so it's seen as a single phraseCarlos Garnacho2016-05-051-5/+10
| | | | | | | FTS5 has a complex enough syntax that it makes not much sense to wrap in simple search boxes. https://bugzilla.gnome.org/show_bug.cgi?id=765981
* css names are always setMatthias Clasen2016-05-051-2/+1
| | | | | No need to check for it, we set the css name on GtkWidgetClass ourselves.
* switch: Remove .slider from slider gadgetTimm Bäder2016-05-051-1/+0
| | | | | As the documentation states, neither the switch nor the slider gadget should be using any style classes.
* switch: Create less pango layoutsTimm Bäder2016-05-051-35/+60
| | | | | | Instead of creating 2 pango layouts in every draw() and on in _get_content_size (and calling into gettext twice in both cases), just keep the layouts around and create them in only one place.
* label: Also initialize textTimm Bäder2016-05-051-1/+1
| | | | | So gtk_label_get_text returns the default value of "". Broke the GtkModelButton default value test.
* label: don't use set_text in gtk_label_newTimm Bäder2016-05-051-3/+1
| | | | | It would just set up lots of things with the default values, but a common case is that a few gtk_label_set_* calls follow.
* label: minimum/natural size parameters are not nullableTimm Bäder2016-05-051-5/+2
| | | | Stop comparing them to NULL.
* label: Don't set out parameters twiceTimm Bäder2016-05-051-6/+6
| | | | | We set them later again when we calculate the vertical size, so just move the general assignment to -1 into the horizontal branch.
* widget: Remove useless NULL checkTimm Bäder2016-05-051-3/+3
| | | | | We are checking for allocation != NULL at the beginning of the function already. This also means that the allocation parameter is not nullable.
* cssimagebuiltin: Remove icons that don't draw anything anymoreBenjamin Otte2016-05-055-16/+10
|
* cssimagebuiltin: Remove unused variablesBenjamin Otte2016-05-052-21/+1
|
* css: Stop drawing double borders for builtinsMatthias Clasen2016-05-051-34/+1
| | | | | | | The fallback code for rendering builtin checks, radios and expanders was using border parameters. With the generic gadget borders using the same parameters, this was giving double borders.
* shadowsvalue: Don't draw invisible box shadowsTimm Bäder2016-05-051-0/+12
|
* Fix gtk_paned_set_position to set position_set consistentlyMatthias Clasen2016-05-051-11/+14
| | | | | As pointed out in https://bugzilla.gnome.org/show_bug.cgi?id=765676, we were failing to set position_set if the position did not change.
* GtkPlacesView: check for network:// URI support before using itРуслан Ижбулатов2016-05-051-0/+12
| | | | | | | | Specifically, this URI is not supported on Windows, but GFile will do its "best" and turn it into GLocalFile("$pwd/network"), with spectacularly bad results. https://bugzilla.gnome.org/show_bug.cgi?id=765858
* dnd: Make sure to free a stashed eventMatthias Clasen2016-05-051-0/+3
| | | | I am not sure if this happens in practice, but better to be safe.
* gesture: Don't leak stashed eventsMatthias Clasen2016-05-051-1/+12
| | | | These events were never freed.
* Use a better hash for arcsMatthias Clasen2016-05-051-1/+17
|
* box gadget: Redo expand flag handlingMatthias Clasen2016-05-057-101/+67
| | | | | | | | | | | | | | | | | We only keep one align flag per child, so it seems odd to keep separate h/v expand flags. Just keep one expand flag and interpret it according to orientation. Allow setting the expand flag for child widgets too, though, so we can make widget expand without interfering with the recursive widget expand flag. Update all callers. Use the new possibility of expanding child widgets to make the label of check and radio buttons expand. This fixes unexpected behavior of these widgets in RTL in some places. https://bugzilla.gnome.org/show_bug.cgi?id=765742
* expander: Reverse alignments in RTLMatthias Clasen2016-05-051-0/+2
| | | | Flip alignments of the title gadget children.