summaryrefslogtreecommitdiff
path: root/gtk
Commit message (Collapse)AuthorAgeFilesLines
* Fix return value error in gtk_stack_get_interpolate_sizeTing-Wei Lan2015-07-201-1/+1
|
* GtkPopover: Set interpolate-size on the stack...Timm Bäder2015-07-202-0/+2
| | | | | ... in gtk_popover_bind_model and gtk_popover_menu_init
* GtkStack: Add interpolate-size propertyTimm Bäder2015-07-202-15/+89
| | | | | And use it to determine whether we should actually interpolate between stack sizes or not.
* GtkListBox: Improve focus scrollingMatthias Clasen2015-07-191-6/+11
| | | | | | | We are trying to scroll the header in view together with the focus row. The way this is implemented works fine when scrolling up, but falls short when scrolling down. Fix this by making sure that both the row and the header bar visible.
* GtkListBox: Listen for adjustment changesMatthias Clasen2015-07-191-4/+23
| | | | | | | | We automatically pick up an adjustment from our parent scrollable, but we failed to update it when it changes. This is happening in the places sidebar, and it was causing the focus-tracking to fail there, letting the focus move out of view. With this change, the focus remains visible.
* places sidebar: Improve keynavMatthias Clasen2015-07-191-28/+0
| | | | | | Remove the code in the sidebar keypress handler that imperfectly reproduces what GtkListBox already does: moving selection and focus in response to arrow keys.
* trivial: Some reformattingMatthias Clasen2015-07-191-12/+7
|
* places sidebar: Remove pointless codeMatthias Clasen2015-07-191-2/+0
| | | | No need to set or unset adjustments explicitly.
* spin button: Add Home and End as key bindingsMatthias Clasen2015-07-191-0/+2
| | | | | | Make these go to the lower/upper boundary of the adjustment, like Ctrl-PageUp/PageDown already do. https://bugzilla.gnome.org/show_bug.cgi?id=309300
* GtkWidget: Add custom font map supportMatthias Clasen2015-07-192-7/+86
| | | | | | | This allows to use a custom font map for parts of the widget hierarchy - this can be used for application-specific fonts. https://bugzilla.gnome.org/show_bug.cgi?id=751812
* font chooser: Add placeholder text to preview entryMatthias Clasen2015-07-191-1/+2
| | | | | | This will make things more understandable if an application sets an empty preview text. https://bugzilla.gnome.org/show_bug.cgi?id=725551
* builder-tool: Don't strip border-widthMatthias Clasen2015-07-191-0/+1
| | | | | Strictly speaking, this would only have to be special-cased inside GtkDialog, but lets just skip it altogether.
* Fix csd decorationsMatthias Clasen2015-07-191-0/+3
| | | | | | By accident, commit b9b17c3c2a434983452561c3 removed one line that wasn't unused, but important for hiding close buttons on dialogs. Bring it back.
* window: Set the type hint when it changes, not just on map()Benjamin Otte2015-07-191-16/+4
| | | | | There is no reason to wait until map() to reset a type hint on the GDK window. Just set it when it changes.
* window: g_object_notify() on type-hint changeBenjamin Otte2015-07-191-0/+2
|
* window: Don't update type hint when it didn't changeBenjamin Otte2015-07-191-0/+3
|
* window: Allow setting type hint on mapped windowsBenjamin Otte2015-07-191-2/+4
|
* window: Don't keep 2 type hintsBenjamin Otte2015-07-191-9/+3
| | | | | | | | 1. This confuses the code as it's using the old type hint with the new type hint on GDK window creation 2. It only existed as a workaround for old code that directly accessed window->type_hint which hasn't been possible since 3.0.
* combobox: Simplify codeBenjamin Otte2015-07-181-13/+4
| | | | | We don't add new children to the child's parent, we add them to ourself. Because guess who a child's parent is?
* combobox: Remove unused header function functionalityBenjamin Otte2015-07-183-144/+2
|
* combobox: Remove unused argument from private functionBenjamin Otte2015-07-181-6/+4
|
* Fix the buildMatthias Clasen2015-07-171-1/+1
|
* Revert "GtkGrid: Add a few NULL checks"Matthias Clasen2015-07-171-5/+2
| | | | | | This reverts commit e215db6da21fc7c54f49b247afabc06a18d60513. We are actually requiring non-NULL out arguments here now.
* inspector: Avoid a NULL derefMatthias Clasen2015-07-171-1/+4
| | | | | Coverity pointed out that getting a class name requires dereferencing the pointer, so only don't do it if it is NULL.
* GtkWindow: Fix a use-after-freeMatthias Clasen2015-07-171-2/+4
| | | | | | We were printing a string in a warning after freeing it. Also, fix an x/y typo that might cause popovers to be mispositioned.
* file chooser: remove an unused GError variableMatthias Clasen2015-07-171-5/+0
| | | | Pointed out by coverity
* inspector: Remove some dead codeMatthias Clasen2015-07-171-6/+0
| | | | Not sure what I was thinking here. Coverity pointed this out.
* inspector: Avoid a NULL derefMatthias Clasen2015-07-171-1/+1
|
* treeview: Add an explicit return for clarityMatthias Clasen2015-07-171-0/+3
| | | | | | I believe that first_column can only ever be NULL here if last_column is NULL too, in which case we'd exited already. But coverity doesn't see that, so add an explicit exit.
* tooltip: Remove unnecessary checksMatthias Clasen2015-07-171-32/+30
| | | | Coverity uses these as clues to complain.
* list box: Remove unnecessary checksMatthias Clasen2015-07-171-4/+3
| | | | Again, coverity takes these as clues to complain.
* GtkLabel: Remove an unnecessary checkMatthias Clasen2015-07-171-1/+1
| | | | | Coverity has the annoying habit of guessing backwards that if we check the value here, it might be NULL earlier.
* GtkGrid: Add a few NULL checksMatthias Clasen2015-07-171-2/+5
| | | | Coverity complained about these.
* GtkActionHelper: Avoid null deref in debug codeMatthias Clasen2015-07-171-1/+1
|
* inspector: Check a return valueMatthias Clasen2015-07-171-3/+5
| | | | | | | We don't care about the error here, but we were relying on g_resources_get_info to zero the size even in case of error. No need to do that, we can just check the return value. Plus, it makes coverity happy.
* inspector: Annotate a call whose return value we don't needMatthias Clasen2015-07-171-1/+1
| | | | | | | The way this code is written, we know that there is an item in the hash table and the iter_next call will give it to us, so no need to check the return value. Annotate the call to tell coverity.
* gtkicontheme: Check a return valueMatthias Clasen2015-07-171-3/+2
| | | | | We were already looking at the error anyway, but rewriting things this way lets coverity see the light.
* gtkbuilderparser: Add some assertionsMatthias Clasen2015-07-171-0/+3
| | | | | Add some assertions that things are non-NULL when we know they are, so that coverity gets it.
* css: Fix GtkCssChange enumBenjamin Otte2015-07-171-35/+35
| | | | | | | | | | | Previously, the (1<<31) value evaluated to the 64bit value 0xFFFFFFFF80000000 instead of 0x0000000080000000 Avoid this by explicitly casting the value to unsigned long long. Also cast all values to unsigned long long to achieve consistency and hopefully in the future get new values added the same way.
* headerbar: Switch css positions on direction changeBenjamin Otte2015-07-171-0/+10
|
* file chooser: Improve popover positioningMatthias Clasen2015-07-171-22/+25
| | | | | We keep the popover vertically tied to the selected row, but pick up the horizontal position from the click / touch.
* places sidebar: Preserve ::populate-popup functionalityMatthias Clasen2015-07-171-27/+78
| | | | | | | | We "fix" this signal the same way we did for GtkEntry and GtkTextView: slightly change the signature so that the passed widget may be a container other than a GtkMenu, and add a property to explicitly opt in to receiving the signal in this case.
* file chooser: Use a popover for the context menuMatthias Clasen2015-07-171-253/+255
| | | | | Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
* places sidebar: Use a popover for the context menuMatthias Clasen2015-07-171-258/+224
| | | | | Use a popover for the context menu, and add a long press gesture to allow opening it with touch.
* inspector: Avoid a gratitious use of g_strv_lengthMatthias Clasen2015-07-161-3/+2
| | | | No need to count the strings first before iterating over them.
* file chooser: Make bindings work in save entryMatthias Clasen2015-07-161-0/+16
| | | | | | | With the name entry being in the header bar now, we no longer get bindings working by just letting the key event bubble up, we have to explicitly apply them on key events that the save entry is not handling.
* GtkFileChooserButton: Don't update icon/label so oftenTimm Bäder2015-07-171-2/+10
| | | | | | | | | | | They were updated in style-changed, causing the label to get set to (None), then to the actual file name again a frame later, both of the updates cause the GtkFileChooserButton to resize, possibly to the minimal width, causing the layout to jump. Fix this by only updating icon/label in style-updated when the icon theme actually changed, which is the only case we care about here. https://bugzilla.gnome.org/show_bug.cgi?id=752509
* gtkprintunixdialog: Set border_width to 0Timm Bäder2015-07-161-0/+1
|
* Avoid O(n²) walking of string arraysEmmanuele Bassi2015-07-162-13/+17
| | | | | | | | | | | | | | | "Yo, we heard you like traversing NULL-terminated arrays to operate on them, so we called g_strv_length() as the for condition, so you can iterate the array while iterating the array." Instead of making famed rapper and television producer Xzibit proud, we should avoid calling g_strv_length() on an array while looping on the array, to avoid quadratic complexity. We do this in various places that deal with arrays of strings that we cannot really guess are short enough not to matter — e.g. the list of CSS selectors in the inspector, or the required authentication information for printing.
* placessidebar: show persistent drives when not showing Other LocationsGeorges Basile Stavracas Neto2015-07-161-3/+4
| | | | | | | | | | | | | Previous commits changes the behavior of GtkPlacesSidebar, as it stops handling persistent devices and only manages mounted networks, XDG directories and bookmarks. By radically breaking the previous behavior, we may have trouble since we provide no alternatives to that besides the private widget GtkPlacesView. Fix that by showing the persistent devices when not showing Other Locations item.
View Lorry Controller Status