| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the location entry up in the header bar in save mode, we can
end up with the search model being in use when the user types in
the location entry. In this case, we don't make the Save button
sensitive as we should.
Having two entries in the dialog is somewhat confusing anyway,
so just stop the search when the user starts typing in the location
entry.
https://bugzilla.gnome.org/show_bug.cgi?id=761757
|
|
|
|
|
|
|
| |
We don't need to make assumptions about which model is currently
used since gtk_tree_selection_get_selection hands us the model.
https://bugzilla.gnome.org/show_bug.cgi?id=761757
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling _gtk_file_consider_as_remote() with a NULL argument
results in warnings being thrown.
Note that query->priv->location being NULL is a state that does
not seem to be invalid by itself.
This could happen if you do search-as-you-type in a filechooser,
which has a filter that does not match anything *and* the current
"place" selected is "Recent".
https://bugzilla.gnome.org/show_bug.cgi?id=761552
|
|
|
|
|
|
|
|
|
| |
In some situations (no header bar, save mode), hitting Escape
would not do anything because the entry ate the key event.
Fix this by telling the entry to only handle Escape when there
is something to do, such as switching back to the path bar.
https://bugzilla.gnome.org/show_bug.cgi?id=761026
|
| |
|
|
|
|
|
|
|
| |
The code for adjusting the center widget allocation in case
of uneven sides never worked right in RTL. This was finally
noticed for tabs with close button, which commonly use a
centered label.
|
|
|
|
|
|
|
|
| |
We are no longer setting a margin on the content area, so put
one on the action area itself to prevent the buttons from touching
the edge.
https://bugzilla.gnome.org/show_bug.cgi?id=762315
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=761838
|
|
|
|
|
|
|
|
|
|
|
|
| |
It does no good to iterate through a series of mime types to call a
function when the eventually-called function,
_gtk_quartz_get_selection_data_from_pasteboard() in this case, gives the
wrong answer and stops the iteration on all but one especially if that
one isn't first.
The one is "image/tiff" and the quartz pasteboard function will return
any image type Quartz knows about for it, so lose the iteration and use
only "image/tiff".
|
|
|
|
|
| |
Update the README.glade file to use current .ui file
names and locations as example.
|
|
|
|
|
|
|
|
|
| |
Changing the visibility of child widgets in size-allocate does
not work well with out current allocation and layout machinery.
To avoid the visual fallout, just keep the arrow buttons visible
and only change their sensitivity.
https://bugzilla.gnome.org/show_bug.cgi?id=754868
|
|
|
|
|
|
|
|
| |
When using the color chooser in editor mode,
gtk_color_chooser_set_rgba need to be propaged
to the editor
https://bugzilla.gnome.org/show_bug.cgi?id=761005
|
|
|
|
|
|
|
|
|
|
| |
It might have changed (eg. after a row being expanded, and the child
rows revalidated), so just update it here based on the last pointer
position.
Based on a patch by Maxim Reznik <reznikmm@gmail.com>
https://bugzilla.gnome.org/show_bug.cgi?id=760891
|
|
|
|
|
|
|
| |
It is not something that can happen normally.
But if it does, we shouldn't crash.
https://bugzilla.gnome.org/show_bug.cgi?id=760680
|
|
|
|
|
|
|
| |
Calling gtk_widget_propagate_state is enough to queue a resize if
needed
See da7a4089fe82981d1412aaa295e76d47a81ad6df
|
|
|
|
| |
We don't want to grow the titlebar by showing an empty label.
|
|
|
|
|
| |
This addresses problems with uneven border radius',
pointed out by Lapo.
|
|
|
|
|
|
|
| |
There was an errant path that threw off our clipping for
the top section of the border.
https://bugzilla.gnome.org/show_bug.cgi?id=722937
|
|
|
|
|
|
|
| |
We skip sides with 0 border width in render_border, but when
we collect sides with the same style, we may pass the 0 width
down to render_frame_stroke anyway. So skip width 0 sides
there as well.
|
|
|
|
|
| |
This is the same fix that was applied for ridge and groove
style in 9f27ee7f5abf49a20ac95d57b306ecd4294b49c6.
|
|
|
|
| |
Use g_sequence_lookup for a binary search over the rows.
|
| |
|
|
|
|
|
|
| |
It was causing needless redraws
https://bugzilla.gnome.org/show_bug.cgi?id=759757
|
|
|
|
| |
The parser was turning a 400 into a 200 and a 700 into a 500.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
I forgot that the settings object we're dealing with here
is in delay mode, so settings won't apply immediately.
|
|
|
|
|
|
|
|
|
|
|
| |
We were only storing the dialog size on unmap, but resetting to the
stored default value more often, e.g. on focus-out. This was causing
the dialog to 'jump back' to its remembered size after the user
manually resized it, leading to frustration and bug reports.
Instead, save the dialog size on every ::size-allocate of the toplevel.
To avoid needlessly spamming dconf, only write the new value if it
changed.
|
|
|
|
|
|
| |
The function can return NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=759081
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure to clean up internal widgets in destroy, as these aren't
cleaned up when GtkContainer walks the childrens list in
gtk_container_destroy().
This also fixes a gedit crash as reported in
https://bugzilla.redhat.com/show_bug.cgi?id=1288669
https://bugzilla.gnome.org/show_bug.cgi?id=759132
|
|
|
|
|
|
|
| |
Pop up the completion window after 100ms. The previous timeout
of 300ms was making completions feel slow.
https://bugzilla.gnome.org/show_bug.cgi?id=758929
|
| |
|
| |
|
|
|
|
|
|
|
| |
Let the label wrap if needed, that's required in some locales, use an
icon which is available in the theme
https://bugzilla.gnome.org/show_bug.cgi?id=758908
|
|
|
|
|
|
|
|
|
| |
Commit 8e975b2 (Bug 753969) introduced check of parent accessibility.
Consequently it is not possible to save file if executable attribute
is not set, which might happen for some gvfs backends. Let's assume
that the folder is accessible even if the attribute is not set.
https://bugzilla.gnome.org/show_bug.cgi?id=760881
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With Mingw-w64 fstat() can be an inline function that
calls _fstat32() or _fstat64(), depending on some macros.
And if LFS is enabled, fstat() is defined to turn into
_fstat32i64() or _fstat64(). And some/all of the above
might also be macros as well. Side-step all that mess
and excplicitly re-define fstat as _fstat32, which is
guaranteed to use a version of "stat" struct that
has 32-bit size and time fields, which is what we want.
https://bugzilla.gnome.org/show_bug.cgi?id=760615
|
|
|
|
| |
see https://bugzilla.gnome.org/show_bug.cgi?id=760169
|
|
|
|
| |
...and make the change more subtle on the dark one.
|
|
|
|
| |
fixes https://bugzilla.gnome.org/show_bug.cgi?id=759260
|
|
|
|
|
|
|
| |
After removal of the selectable header and separator from the combo box,
the method to update the menu sensitivity must be changed as it assumes
at least two items within each sub menu and contains special handling
for the separator. Removing this fixes bug #759079.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise rounding errors fool the "tab under coordinates" checks on
crossing events, which will be triggered close enough to the window
rectangle if the pointer moves slowly enough.
With this, the tab_prelight() function correctly figures out we've
moved the pointer outside the tab area when called in
gtk_notebook_leave_notify().
https://bugzilla.gnome.org/show_bug.cgi?id=759091
|
|
|
|
|
| |
These were a bit crammed, which doesn't match well with spacing used in
various other parts of gtk.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'win.lines' contains the same content as the GtkTextBuffer, so to find
@match_start, forward_chars_with_skipping() is called with
skip_decomp=FALSE (the last parameter). So far so good.
On the other hand, the content 'lines' (the needle split in lines) is
casefolded and normalized for a case insensitive search. So,
forward_chars_with_skipping(..., skip_decomp=TRUE) must be called only
for the portion of text containing the needle.
Since 'start_tmp' contains the location at the start of the match, we
can simply begin at that location to find the end of the match.
Unit tests are added.
https://bugzilla.gnome.org/show_bug.cgi?id=758698
|
|
|
|
|
|
|
| |
Instead of just listing the return type of get_plus_button() and
get_minus_button() in the documentation, we can use the (type)
annotation to ensure that the introspection data reflects the actual
type of the returned widget.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=539944
|