| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Some places were missing the right valign setting to make
baselines line up properly.
|
|
|
|
|
| |
Use the CSS name paper for this as well, and make sure Adwaita
sets a color that makes the text visible in the dark theme as well.
|
|
|
|
| |
The CSS name for GtkPrintUnixDialog is printdialog.
|
|
|
|
| |
And the compiler warning that comes with it.
|
|
|
|
|
|
| |
There was one more call to gtk_style_context_save here that I
overlooked. We can get rid of it by just setting the element name
on the drawing area.
|
|
|
|
|
| |
Use a transient node with name paper instead of a random
collection of style classes for rendering the papers.
|
|
|
|
|
|
|
| |
This changes GTK+ to use gdk_cursor_new_from_name() with the
'standard' css names, instead of GdkCursorType.
https://bugzilla.gnome.org/show_bug.cgi?id=652085
|
| |
|
|
|
|
|
| |
const gchar const is still just const gchar, unless there's
indirections in between.
|
|
|
|
|
|
|
|
|
| |
The code above checks whether (printer == NULL), so we’d better do so
here as well.
Found by scan-build.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
|
|
|
|
|
|
|
|
|
|
| |
The page_setup of a GtkPrintContext or GtkPrintUnixDialog is nullable,
so all reference count changes to it have to be guarded against NULL
values.
Found by scan-build.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
|
|
|
|
|
|
|
|
| |
These types are not covered by g_test_register_all_types,
and having the types registered when a print dialog is used
helps in cases where GTK+ is dlopened.
https://bugzilla.gnome.org/show_bug.cgi?id=745065
|
|
|
|
|
|
| |
I've noticed a missing image show up in my print dialog, where
the printer reported "printer-paused" as icon. Rearrange things
so we always fall back to "printer" for printer icons.
|
|
|
|
|
| |
After consultation, revisit the vertical centering to center
the first 'stack', and put the second one behind it.
|
|
|
|
| |
... and use it in the print preview.
|
|
|
|
|
| |
We don't need the scaling support anymore - icon sizes are
no longer settable.
|
|
|
|
|
| |
Center the page ordering indicator horizontally, relative to the
spinbutton above it.
|
|
|
|
|
| |
Center the page ordering indicator vertically, relative to the
checkboxes next to it.
|
|
|
|
|
| |
This is only one step in the right direction. Long term this code should
probably be replaced by real widgets.
|
|
|
|
| |
Use the newer constructed instead, which has a fast path in GObject.
|
|
|
|
|
| |
Automatic template children get cleaned up and NULLed out in destroy,
the g_clear_pointer() calls in finalize never do anything.
|
|
|
|
|
|
|
|
|
|
| |
Following up from 438cd857c49242244dda2923ac447f36464b9e72,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
|
|
|
|
|
|
|
| |
Don't crash when /tmp is not writable when printing to file.
Show that getting of printer details failed for CUPS printers.
https://bugzilla.gnome.org/show_bug.cgi?id=693200
|
|
|
|
|
|
| |
Don't make Print button sensitive until a printer is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=724895
|
|
|
|
| |
Instead of Return value:
|
|
|
|
|
|
| |
GtkPrintUnixDialog was leaking a GFile.
Spotted by Christian Persch in
https://bugzilla.gnome.org/show_bug.cgi?id=724631
|
|
|
|
| |
This was also causing the templates test to fail.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Specifically, switch to using markdown syntax for sections.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=723119
|
|
|
|
| |
It is a little heavy handed. The text can speak for itself.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Add printer_compare() function for comparing printers according
to their names and locations. It is possible to search by multiple
keys separated by space or tabulator using logical conjunction.
Based on patch by William Hua.
https://bugzilla.gnome.org/show_bug.cgi?id=692931
|
|
|
|
|
| |
Use gtk_dialog_add_button() which adds the button to
the message dialog correctly and uses gtk_widget_show() on it.
|
| |
|
| |
|
|
|
|
|
|
| |
Make the print dialog use a headerbar when desired.
https://bugzilla.gnome.org/show_bug.cgi?id=720059
|
|
|
|
|
| |
We'll keep this code around for now to not regress
on Windows, but avoid deprecation warnings.
|
|
|
|
|
|
|
|
| |
g_file_new_for_uri() is guaranteed to return a non-NULL value, so this
check was redundant, and was confusing the static analyser into
returning a false positive, where it thought the file could be NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
|
|
|
|
|
|
| |
GtkPrintUnixDialog and testtitlebar were still using
gtk_widget_set_margin_left/right. Switch them over to
gtk_widget_set_margin_start/end.
|
|
|
|
|
|
|
|
| |
* gtk/gtkprintunixdialog.c (printer_status_cb): Do not reset the
waiting_for_printer on status change as the default printer might
get added later.
https://bugzilla.gnome.org/show_bug.cgi?id=577642
|
|
|
|
|
|
|
| |
The dimensions in the n-up illustration were not using the
color of the style for drawing.
https://bugzilla.gnome.org/show_bug.cgi?id=709420
|
|
|
|
|
|
|
|
|
|
|
| |
We rename the gtk_widget_class_bind_template_child{_internal}
macros by appending a _private to their name. Otherwise, it
would be too magic to pass the 'public' names as arguments,
but affect a member of the Private struct. At the same time,
Add two new macros with the old names,
gtk_widget_class_bind_template_child{_internal} that operate
on members of the instance struct.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The macros and functions are inconsistently named, and are not tied to
the "template" concept - to the point that it seems plausible to use
them without setting the template.
The new naming scheme is as follows:
gtk_widget_class_bind_template_child_full
gtk_widget_class_bind_template_callback_full
With the convenience macros:
gtk_widget_class_bind_template_child
gtk_widget_class_bind_template_child_internal
gtk_widget_class_bind_template_callback
https://bugzilla.gnome.org/show_bug.cgi?id=700898
https://bugzilla.gnome.org/show_bug.cgi?id=700896
|
|
|
|
|
|
|
|
|
|
| |
Using an offset from the struct means you can have children in
both the public and private (via G_PRIVATE_OFFSET) parts of the
instance. It also matches the new private macros nicer.
https://bugzilla.gnome.org/show_bug.cgi?id=702563
Signed-off-by: Emmanuele Bassi <ebassi@gnome.org>
|
|
|
|
|
| |
Drop includes of deprecated headers where they are
no longer needed.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've recently a number of classes wholly. For these cases,
move the headers and sources to gtk/deprecated/ and adjust
Makefiles and includes accordingly.
Affected classes:
GtkAction
GtkActionGroup
GtkActivatable
GtkIconFactory
GtkImageMenuItem
GtkRadioAction
GtkRecentAction
GtkStock
GtkToggleAction
GtkUIManager
|