summaryrefslogtreecommitdiff
path: root/gtk/gtkplacessidebar.c
Commit message (Collapse)AuthorAgeFilesLines
* places sidebar: Drop the top marginMatthias Clasen2015-01-191-1/+0
| | | | This looks odd in combination with the top underflow.
* gtkplacessidebar: insert bookmark by dnd in correct positionNelson Benítez León2015-01-131-0/+19
| | | | | | | Add needed COLUMN INDEX to "new bookmark" row based on previous bookmark index plus one. Fixes bug 742727
* GtkPlacesSidebar: Don't return FALSE as a pointerMatthias Clasen2014-12-081-1/+1
| | | | Pointed out in https://bugzilla.gnome.org/show_bug.cgi?id=741250
* places sidebar: Fix the sort functionMatthias Clasen2014-12-041-0/+4
| | | | | | | | When returning 1 for a pair (a,b), a sort function must return -1 for the pair (b,a), otherwise things can go badly. https://bugzilla.gnome.org/show_bug.cgi?id=739729
* GtkPlacesSidebar: Fix Home and Desktop on Windows.Matias De Lellis2014-12-011-2/+2
| | | | | | | We were concatenating "file://" to the result of g_get_user_special_dir() to build a URI, but this is not enough on Windows. Use g_filename_to_uri() instead. See https://bugzilla.gnome.org/show_bug.cgi?id=739453
* GtkPlacesSidebar: add support for unmount notificationsCosimo Cecchi2014-11-301-19/+71
| | | | | | | Now that we can use GNotification from here, send a notification when umounting from GtkPlacesSidebar. https://bugzilla.gnome.org/show_bug.cgi?id=740896
* GtkPlacesSidebar: Don't crash on dndMatthias Clasen2014-10-251-4/+6
| | | | | | gtk_get_current_event() can return NULL. Don't crash if it does. https://bugzilla.gnome.org/show_bug.cgi?id=739150
* GtkPlacesSidebar: Don't leak an iconMatthias Clasen2014-10-141-0/+1
| | | | Found in valgrind.
* gtkplacessidebar: Fix commit f6870e5b79fd9abCarlos Soriano2014-10-121-14/+12
| | | | | | | | | Commit f6870e5b79fd9ab introduced a some memory leaks and could be improved in some areas. Fix the memory leaks and apply the improvements. https://bugzilla.gnome.org/show_bug.cgi?id=737983
* gtkplacessidebar: Open $HOME after unmounting or ejectingCarlos Soriano2014-10-101-2/+126
| | | | | | | | | | | When a drive is ejected or a volume unmounted the current directory doesn't change most of the times being empty or being a directory that user shouldn't take care about, like /run/media Seems more useful to change to $HOME directory in that case so the user can see something useful and familiar just after unmounting. https://bugzilla.gnome.org/show_bug.cgi?id=737983
* gtkplacessidebar: Don't change location if clicked on eject buttonCarlos Soriano2014-10-101-1/+7
| | | | | | | | | | Currently we change the current location if we click the eject button of a mount. Check whether the user actually clicked the eject button and don't change location in that case. https://bugzilla.gnome.org/show_bug.cgi?id=737983
* Cosmetic formatting fixMatthias Clasen2014-10-051-1/+1
|
* GtkPlacesSidebar: Don't pile up duplicate bookmarksMatthias Clasen2014-10-051-0/+5
| | | | | | | | | | | | | | We get multiple notifications from the bookmark manager when something changes. Every time, we reconstruct the sidebar contents completely, by clearing the store. The bookmarks are added with async calls though, and the code was forgetting to cancel outstanding async requests, leading to multiple instances of the same bookmark getting added. Use the cancellable we already have to prevent that. This could be made much more efficient by not recreating the entire sidebar quite so often (3-5 times for a single bookmark rename). https://bugzilla.gnome.org/show_bug.cgi?id=737679
* GtkPlacesSidebar: Be consistent in messagesMatthias Clasen2014-09-291-9/+9
| | | | | | Always quote drive/volume names. https://bugzilla.gnome.org/show_bug.cgi?id=735192
* GtkPlacesSidebar: Fix a memory leakRoss Lagerwall2014-09-121-1/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=736512
* GtkPlacesSidebar: Don't update bookmark if cancelledRoss Lagerwall2014-09-121-1/+5
| | | | | | | | | If the query fails because it has been cancelled, it means that dispose() has been called, so don't try and update anything. This fixes a segfault with Nautilus in certain situations. https://bugzilla.gnome.org/show_bug.cgi?id=736512
* GtkPlacesSidebar: Only add shortcut if query succeedsRoss Lagerwall2014-09-121-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=736512
* GtkPlacesSidebar: Cancel async ops when finalizedMatthias Clasen2014-09-031-2/+12
| | | | | This is the common practice for objects that start async operations. https://bugzilla.gnome.org/show_bug.cgi?id=735953
* places-sidebar: Use asynchronous API for querying bookmarksEmmanuele Bassi2014-09-031-77/+124
| | | | | | | Removes two FIXMEs, and ensures that the places sidebar does not block while enumerating bookmarks or application shortcuts to remote volumes. https://bugzilla.gnome.org/show_bug.cgi?id=735953
* places-sidebar: Refine the spacingYosef Or Boczko2014-08-131-3/+4
| | | | | Based on a patch by Yosef Or Boczko, https://bugzilla.gnome.org/show_bug.cgi?id=731443
* GtkPlacesSidebar: Fix editing of bookmarksMatthias Clasen2014-07-231-7/+4
| | | | | | | | | This was silently broken - the code was just assuming that the text cell renderer is item no. 6 on the list of all cells. That doesn't work so well if the cell renderers are set up elsewhere and get rearranged. Fix this by keeping an explicit pointer to the the text cell.
* placessidebar: Use symbolic name for symbolic iconBastien Nocera2014-06-221-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=731908
* gtk: add missing type annotations ported from Vala bindingsEvan Nemerson2014-05-271-9/+11
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=730745
* placessidebar: use proper canonicalization when checking if homeCosimo Cecchi2014-05-141-2/+24
| | | | | | | Instead of just checking the string. This catches things like double slashes, relative paths and so on. https://bugzilla.gnome.org/show_bug.cgi?id=730142
* places-sidebar: add optional enter location placeWilliam Jon McCann2014-04-221-0/+104
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=722211
* places-sidebar: use separators instead of heading labelsWilliam Jon McCann2014-04-221-75/+23
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=722211
* docs: use Returns: consistentlyWilliam Jon McCann2014-02-191-7/+7
| | | | Instead of Return value:
* docs: use apostrophe in *'llWilliam Jon McCann2014-02-071-1/+1
|
* docs: use proper apostropheWilliam Jon McCann2014-02-071-5/+5
| | | | https://wiki.gnome.org/Design/OS/Typography
* docs: use proper quotesWilliam Jon McCann2014-02-051-8/+8
|
* docs: Identify examples that are C codeWilliam Jon McCann2014-01-291-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=723119
* GtkPlacesSidebar: Stop drives that can be stoppedMatthias Clasen2014-01-271-31/+37
| | | | | | | | | Removable USB drives or memory sticks should be powered down when the eject button is pressed. For this, we need to call g_drive_stop() instead of g_drive_eject(), provided the drive can be stopped. https://bugzilla.gnome.org/show_bug.cgi?id=723121
* GtkPlacesSidebar: Fix two copy-paste errorsMatthias Clasen2014-01-271-2/+2
| | | | Sadly, this means the code can have never been tested :-(
* GtkPlacesSidebar: Remove to FIXMEsMatthias Clasen2014-01-271-4/+4
| | | | It doesn't hurt to just add the ref here, as the FIXME suggests.
* docs: use correct signal name in docsWilliam Jon McCann2014-01-211-1/+1
|
* Fix a memory leakMatthias Clasen2014-01-131-0/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=722029
* GtkPlacesSidebar: Don't show desktop if its homeMatthias Clasen2013-12-191-8/+11
| | | | | | We go to extra length to set the desktop_uri to NULL when desktop == home, but then we were adding the (non-functional) place item anyway. Don't do that.
* GtkPlacesSidebar: avoid a crashMatthias Clasen2013-12-191-1/+1
| | | | | | | Be more careful when comparing uris during DND - they may be NULL. https://bugzilla.gnome.org/show_bug.cgi?id=720264
* places sidebar: Use a symbolic desktop iconMatthias Clasen2013-12-011-2/+3
| | | | | | This was pointed out in https://bugzilla.gnome.org/show_bug.cgi?id=719505
* Change the default for "show-desktop" back to TRUEMatthias Clasen2013-11-261-1/+1
| | | | | | | | Change the GtkSettings default for "shell-shows-desktop" back to TRUE and also change the default value of the "show-desktop" property on GtkPlacesSidebar so that the defaultvalue test passes. https://bugzilla.gnome.org/show_bug.cgi?id=712302
* GtkPlacesSidebar: don't unref an object we don't ownCosimo Cecchi2013-11-141-1/+1
| | | | | gtk_settings_get_default() doesn't return a reference, so don't unref it during dispose.
* GtkPlacesSidebar: use shell-shows-desktop settingRyan Lortie2013-11-141-3/+50
| | | | | | | Use the just-added shell-shows-desktop GtkSetting to determine if we should also show the "Desktop" folder in the places sidebar. https://bugzilla.gnome.org/show_bug.cgi?id=712302
* GtkPlacesSidebar: Show unmounted bookmarksBastien Nocera2013-11-131-17/+35
| | | | | | | The GtkFileInfo is only used if there's no bookmark name, or to get the icon for the remote share or local folder. https://bugzilla.gnome.org/show_bug.cgi?id=711548
* Silence a compiler warningMatthias Clasen2013-11-091-1/+1
|
* Filter out duplicate application shortcutsMatthias Clasen2013-11-091-0/+35
| | | | | | | The file chooser used to do this, the places sidebar still needs to learn it. https://bugzilla.gnome.org/show_bug.cgi?id=711636
* GtkPlacesSidebar: Add local-onlyMatthias Clasen2013-11-091-61/+146
| | | | | | | This is necessary to implement the filechooser property of the same name. https://bugzilla.gnome.org/show_bug.cgi?id=711574
* Update coding styleMatthias Clasen2013-11-091-3518/+3486
| | | | gtkplacessidebar.c was looking foreign.
* Properly set drop targetsMatthias Clasen2013-11-091-3/+6
| | | | Pointed out in by Nelson Benitez in bug 707679.
* Revert "GtkPlacesSidebar: support switching locations for XDS drag types"Matthias Clasen2013-10-231-15/+3
| | | | This reverts commit 588ffa8c3241eff2f8e2d99b911a6bcb539347bd.
* Revert "GtkPlacesSidebar: support open locations when dragging text"Matthias Clasen2013-10-231-16/+5
| | | | This reverts commit 1b839d4b72a2cedb2bb633b5acd57239860693f4.
View Lorry Controller Status