| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Instead of allowing people to pass a uint user-data, insist on them
comparing mime types.
The user data was a uint instead of a pointer anyway, so uniqueness
could not be guaranteed and it caused more issues than it was worth.
And that's ignoring the fact that it basically wasn't used.
|
|
|
|
|
| |
This gets rid of GtkTargetEntry in the API and consistently uses
GtkTargetList.
|
|
|
|
|
| |
show-tabs=FALS means the notebook is not supposed to show tabs,
regardless of whether it has a current page or not.
|
| |
|
|
|
|
|
| |
Returning the screen does not add anything here and
GdkScreen is going away.
|
|
|
|
| |
We only want to pop up the context menu in the tab strip.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes that work using 1 of 2 options:
1. Add all missing enums to the switch statement
or
2. Cast the switch argument to a uint to avoid having to do that (mostly
for GdkEventType).
I even found a bug while doing that: clearing a GtkImage with a surface
did not notify thae surface property.
The reason for enabling this flag even though it is tedious at times is
that it is very useful when adding values to an enum, because it makes
GTK immediately warn about all the switch statements where this enum is
relevant.
And I expect changes to enums to be frequent during the GTK4 development
cycle.
|
| |
|
|
|
|
|
|
| |
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://bugzilla.gnome.org/show_bug.cgi?id=787303
|
| |
|
|
|
|
|
| |
It's not needed anymore with get_outer_allocation (which will be
replaced by something more appropriately named).
|
|
|
|
|
|
|
|
|
| |
This function clearly assumes the parameter children cannot be NULL, and
the call sites seem to perform enough checks to confirm this.
CID 1388869 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking children suggests that it may be null,
but it has already been dereferenced on all paths leading to the check.
|
|
|
|
|
| |
Otherwise we might skip them here, then set child-visible to TRUE and
then later snapshot them even though they have no valid size.
|
|
|
|
|
|
|
|
|
|
|
| |
Since setting a clip is mandatory for almost all widgets, we can as well
change the size-allocate signature to include a out_clip parameter, just
like GtkCssGadget did. And since we now always propagate baselines, we
might as well pass that one on to size-allocate.
This way we can also make sure to transform the clip returned from
size-allocate to parent-coordinates, i.e. the same coordinate space
priv->allocation is in.
|
| |
|
|
|
|
| |
Aaand all the unit tests pass again.
|
| |
|
|
|
|
|
| |
Hardcode the default values until someone comes up with a proposal for a
better way.
|
|
|
|
| |
Now unused.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
always initialize clips to the (content) allocation, don't walk up the
widget hierarchy in gtk_widget_set_clip, implement
gtk_widget_size_allocate in GtkSeparator. This way we don't end up using
uninitialized clip values.
The entire clip handling is up for major rework since we can't and don't
want to force every single widget to call _set_clip in size-allocate
implementations.
|
|
|
|
| |
gtk_gesture_get_last_event can return NULL, so guard against that.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=781935
|
|
|
|
|
| |
It is not necessary anymore to implement tab DnD, since we just render
it on top.
|
|
|
|
| |
No longer needed.
|
|
|
|
|
|
|
|
|
|
| |
We now rely on toplevels receiving and forwarding all the events
the windowing should be able to handle. Event masks are no longer a
way to determine whether an event is deliverable ot a widget.
Events will always be delivered in the three captured/target/bubbled
phases, widgets can now just attach GtkEventControllers and let those
handle the events.
|
|
|
|
|
| |
This makes notebooks happy again after changing event coordinates to always come in
the widget coordinate system.
|
|
|
|
|
|
| |
with include_internals=TRUE, this is the same as the (still private)
gtk_widget_forall, or just using the children/sibling accessors in a
loop.
|
|
|
|
| |
Do the same thing GtkContainer does.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Thanks to Daniel Boles for helping with a crash in an earlier version of
this patch.
https://bugzilla.gnome.org/show_bug.cgi?id=777547
|
|
|
|
| |
This reverts commit 218beb2ef49d407b547047693605328c10d4877d.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=777547
|
|
|
|
| |
Replace it with the already existing gtk_widget_snapshot_child.
|
|
|
|
|
| |
It's equivalent to gtk_container_propagate_draw() and then one is
public, too.
|
|
|
|
|
|
|
| |
And with it, remove the draw func from custom gadgets, that has been
NULL everywhere.
All gadgets are snapshot now.
|
|
|
|
|
|
| |
See https://developer.gnome.org/hig/stable/typography.html
https://bugzilla.gnome.org/show_bug.cgi?id=772371
|
| |
|
|
|
|
|
| |
This was pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=774743
|
|
|
|
| |
The answer is: Yes.
|
| |
|
|
|
|
| |
Instead of GtkWidget's buton-press-event/button-release-event
|
|
|
|
| |
... instead of copy/paste from gtk_widget_real_realize.
|
| |
|
|
|
|
|
|
|
|
| |
Add a new ::measure vfunc similar to GtkCssGadget's that widget
implementations have to override instead of the old get_preferred_width,
get_preferred_height, get_preferred_width_for_height,
get_preferred_height_for_width and
get_preferred_height_and_baseline_for_width.
|
| |
|