| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
We create and destroy gadgets inside the levelbar hierarchy here,
and if we don't explicitly remove their CSS nodes from the parent,
they stick around.
|
|
|
|
|
|
| |
We were freeing the old offset before using its name to
recreate a new one. Don't do that.
Found by gcc's undefined behavior sanitizer.
|
| |
|
|
|
|
|
|
|
|
| |
We had some odd special-casing for the lowest and highest offset
that did not quite work. The new rule is simple: If the value
is between offset n-1 and n, it gets the style for offset n.
https://bugzilla.gnome.org/show_bug.cgi?id=761416
|
|
|
|
|
|
| |
The docs were not explaining at all what happens to existing
level offsets when the min- or max-value of a level bar are
changed.
|
|
|
|
|
| |
We are adding 3 offsets, not just two. Add a define for the
third one, and mention it in the docs.
|
|
|
|
|
|
|
|
|
| |
During the gadget conversion, the drawing of discrete levelbars
was unintentionally changed to draw a wide trough but narrow
blocks, which does not look great. So go back to the previous
way of drawing things.
https://bugzilla.gnome.org/show_bug.cgi?id=761428
|
| |
|
|
|
|
|
| |
Use gtk_css_gadget_set_state in all the places where we previously
were getting a node from a gadget, just to call gtk_css_node_set_state.
|
|
|
|
|
| |
Instead of just picking the first. This is because the theme might set a
border on only one of them, like the HighContrast theme does.
|
|
|
|
| |
We're always interested in the minimum size.
|
| |
|
|
|
|
| |
We now use one gadget for the trough, and one for each block.
|
| |
|
|
|
|
|
| |
We should not try to access a block with an index that exceeds the
number of blocks in the widget.
|
|
|
|
|
| |
Clarify the use of brackets in the CSS node diagrams:
[] means optional nodes or classes, <> means child widgets.
|
|
|
|
|
|
|
|
| |
Instead of having old and new style, now have a GtkCssStyleChange opaque
object that will compute the changes you are interested in for you.
This simplifies change signal handlers quite a bit and avoids lots of
repeated computation in every signal handler.
|
|
|
|
|
| |
When introducing handlers for state_flags_changed in the node
transitions, chaining up was forgotten.
|
|
|
|
| |
Create as many CSS nodes as we're rendering blocks on the screen.
|
| |
|
|
|
|
|
|
| |
Use element names levelbar, trough, block, and some style
classes on the block nodes: .discrete, .continuous, .empty,
.level-low, etc.
|
|
|
|
| |
This avoids pointless allocations
|
|
|
|
|
|
|
| |
Instead of issuing g_warning, fill the provided GError.
This lets us test this error handling, and is the right
thing to do. Use the new GtkBuilder helpers and
g_markup_collect_attributes to do so.
|
|
|
|
|
|
|
|
| |
We want to be able to style the empty blocks independently of all the
offset styles, so remove the current style class when painting an empty
block.
https://bugzilla.gnome.org/show_bug.cgi?id=707695
|
| |
|
|
|
|
| |
So level bars can have shadows, too.
|
| |
|
|
|
|
|
| |
Size vfuncs always get non-null out variables passed, so no need to
check for NULL.
|
|
|
|
| |
Instead of Return value:
|
|
|
|
|
|
|
|
|
| |
Try to do a better job of keeping example content
from being too wide. It is often rendered as <pre>
text so the only time we can wrap it is in the source.
It is best to full break lines at all punctuation and
to try to keep the width under 70 chars or so.
|
|
|
|
| |
https://wiki.gnome.org/Design/OS/Typography
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=723119
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=723119
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=702996
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=684288
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=684288
|
|
|
|
|
|
|
| |
This reverts commit 4b3ed75f7d14bc10a045aeb4a3873ff36eee966a.
I didn't see https://bugzilla.gnome.org/show_bug.cgi?id=684288 - it
makes more sense to properly fix this for the next cycle.
|
|
|
|
|
|
| |
As long as we don't have an API for explicitly inverting the bar, it
makes more sense for the progress in vertical orientation to fill from
the bottom.
|
|
|
|
|
|
|
| |
-Include fallback-c89.c for the usage of round(), where an implementation
of round() is provided for compilers that don't have it
-Use g_ascii_strtod() instead of strtof as strtof() may not be universally
available.
|
|
|
|
|
|
|
| |
Similar to CcStrengthBar from gnome-control-center, but more generic and
with thorough CSS styling support.
https://bugzilla.gnome.org/show_bug.cgi?id=677892
|
|
|
|
|
|
| |
This reverts commit 126a2308ca467744178d4be3309403f6899de987.
Pushed by mistake.
|
|
Similar to CcStrengthBar from gnome-control-center, but more generic and
with thorough CSS styling support.
https://bugzilla.gnome.org/show_bug.cgi?id=677892
|