| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
The pointers passed to GtkWidgetClass::measure cannot be NULL
|
|
|
|
|
| |
Make this function shorter, the parameters non-nullable and the simple
cases more explicit.
|
|
|
|
|
| |
This only happens in error cases so not very interesting. Anyway, try to
make scan-build happy.
|
| |
|
|
|
|
| |
This is only used in gtklabel.c
|
|
|
|
|
|
| |
Try to sort toplevel functions to minimize unnecessary function
prototypes at the beginning of the file, get rid of all tabs and
trailing whitespace.
|
|
|
|
|
|
|
|
|
| |
Rename a few local variables to be clearer about whether they belong to
the widget or to the layout.
Remove a workaround for an old bug that is no longer valid. We don't
underallocate the layout anymore. Aways center vertically, with respect
to the yalign.
|
|
|
|
|
| |
Use two early-out style if statements to reduce indentation in this
entire function.
|
|\
| |
| |
| |
| | |
Rework surface state and geometry computation
See merge request GNOME/gtk!2885
|
| |
| |
| |
| | |
This makes it more explicit that managers of popovers make it "present".
|
|/
|
|
| |
Instead of checking the activate_signal field directly.
|
| |
|
|
|
|
|
| |
GtkBindingSignal does not exist anymore, so link to
GtkSignalAction for an explanation of keybinding signals.
|
|
|
|
|
|
|
| |
Commit 0db504edde63eb77e made a mistake described here:
https://en.wikipedia.org/wiki/Short-circuit_evaluation#Possible_problems
Fixes: #3359
|
|
|
|
|
| |
Don't duplicate the string before we know if it
has actually changed.
|
|
|
|
|
|
|
|
| |
The overarching goal here is to not queue a resize
unless something has actually changed. In columnview
scenarios, we often deal with hundreds of labels.
Labels are cattle, not pets.
|
|
|
|
|
|
|
|
|
|
| |
Using GList is a bit lame, and makes the API more complicated to use
than necessary in the common case.
The only real use case for a GList is gtk_widget_add_mnemonic_label(),
and for that we can use the GValue-based API instead.
Fixes: #3343
|
|
|
|
|
|
| |
This only happens in error cases so pretty insignificant.
Found by scan-build
|
|
|
|
|
| |
gtkcssnodeprivate.h was mainly used for repositioning CSS nodes in
gadgets, and gadgets are gone now.
|
|
|
|
| |
This will make label text show up in ATs again.
|
|
|
|
|
|
| |
Replace most remaining uses of GTK+ in the docs and
user-visible strings by GTK. Also remove some leftover
"Was added in 3.x" sentences from the docs.
|
| |
|
|
|
|
| |
Measuring text is quite expensive, so only do this if really necessary.
|
|
|
|
| |
Fixes: #3034
|
|
|
|
|
| |
When focus changes in a selectable label, we need to
redraw to make the text caret (dis)appear.
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to select on focus-in when the focus
comes from a child. The case where this does harm
is when you activate copy or paste actions from the
context menu. We close the menu before triggering the
action, and if that causes the text in the label to
be selected, unexpected things happen, since the action
applies to the current selection.
This is the equivalent of cd9f5733b3e354301f2 for GtkLabel.
|
|
|
|
|
|
|
|
| |
Use the label accessible role for GtkLabel. ARIA has some
ominous wording about it going way, but while we have it,
GtkLabel is the obvious candidate for carrying it.
Update the documentation and add a test.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To build a better world sometimes means having to tear the old one down.
-- Alexander Pierce, "Captain America: The Winter Soldier"
ATK served us well for nearly 20 years, but the world has changed, and
GTK has changed with it. Now ATK is mostly a hindrance towards improving
the accessibility stack:
- it maps to a very specific implementation, AT-SPI, which is Linux and
Unix specific
- it requires implementing the same functionality in three different
layers of the stack: AT-SPI, ATK, and GTK
- only GTK uses it; every other Linux and Unix toolkit and application
talks to AT-SPI directly, including assistive technologies
Sadly, we cannot incrementally port GTK to a new accessibility stack;
since ATK insulates us entirely from the underlying implementation, we
cannot replace it piecemeal. Instead, we're going to remove everything
and then incrementally build on a clean slate:
- add an "accessible" interface, implemented by GTK objects directly,
which describe the accessible role and state changes for every UI
element
- add an "assistive technology context" to proxy a native accessibility
API, and assign it to every widget
- implement the AT context depending on the platform
For more information, see: https://gitlab.gnome.org/GNOME/gtk/-/issues/2833
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Drop fallback-c89.c
See merge request GNOME/gtk!1999
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We require a C compiler supporting C99 now. The main purpose of
these fallbacks was for MSVC. From what I can see this is now all supported
by MSVC 2015+ anyway.
The only other change this includes is to replace isnanf() with the
(type infering) C99 isnan() macro, because MSVC doesn't provide isnanf().
|
|\ \
| |/
|/|
| |
| |
| |
| | |
label: Fix mnemonic zero
Closes #2805
See merge request GNOME/gtk!1993
|
| |
| |
| |
| |
| |
| |
| | |
We were confusing '\0' and '0' when parsing the label
for mnemonics.
Fixes: #2805
|
|/
|
|
| |
It's not used and nobody has documented how it's meant to work anyway.
|
|
|
|
|
|
|
|
|
|
|
| |
If you run weston with the headless backend, you get a Wayland
display with no seat, which is just fine by the protocol.
gdk_display_get_default_seat() returns NULL in this case. Various
widgets assume that we always have a seat with a keyboard and a
pointer, since that is what X guarantees. Make things survive
without that, so we can run the testsuite under a headless
Wayland compositor.
|
|
|
|
|
|
|
|
|
|
| |
Add back a property that determines whether an individual
widget will accept focus or not. :can-focus prevents the
focus from ever entering the entire widget hierarchy
below a widget, and :focusable just determines if grabbing
the focus to the widget itself will succeed.
See #2686
|
|\
| |
| |
| |
| | |
Wip/baedert/for master
See merge request GNOME/gtk!1828
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
The destroy vfunc is going away.
|
|/
|
|
|
| |
Replace all uses of gtk_container_add on buttons
by gtk_button_set_child.
|
|
|
|
|
|
|
| |
Emit accessible change signals after setting the
new selection limits. This was broken in
commit f6bedd0d5e4c8f7b, and showed up as broken
accessibility tests.
|
| |
|
|
|
|
|
| |
The arguments name in the documentation must match declaration and
definition, or gtk-doc and g-ir-scanner will get very cross at us.
|