| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Use g_slist_free_full more consistently. This commit just converts
the obvious cases where g_slist_forall is directly followed by
g_slist_free.
|
|
|
|
|
|
| |
When the dialog is as narrow as possible, we still want some
space between the entry and the search button, so use margins
around the entry and label instead of box spacing.
|
|
|
|
|
| |
Things work smoother, keynav-wise, if the search button does not
take focus on click.
|
|
|
|
|
| |
We were not listening for action changes to update the
save entry.
|
|
|
|
|
|
|
|
|
|
|
| |
Make the file chooser entry optionally capture Escape
and emit a signal. Make the file chooser widget hide the
entry on that signal and go back to the path bar.
This gives us a two-level undo:
location entry -> path bar -> dialog close.
When the location entry is permanently displayed in the
header for save mode, we still let the first Escape close
the dialog.
|
|
|
|
|
| |
When we have a header bar, put a save entry there and
make the file chooser use it.
|
|
|
|
|
| |
Use the new "subtitle" property of the file chooser widget
to display a subtitle in the headerbar, if we have one.
|
|
|
|
|
|
|
|
| |
The height of the text buttons depends on the font height,
whereas the search button has a fixed-size icon in it...
Prevent unevent heights by putting them all in a size group.
https://bugzilla.gnome.org/show_bug.cgi?id=745263
|
|
|
|
|
| |
This is where we put similar search buttons in applications
and in other dialogs, such as the GtkAppChooserDialog.
|
|
|
|
| |
These were leftover at various places in the documentation.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=547988
|
|
|
|
| |
Instead of Return value:
|
|
|
|
|
|
|
|
|
| |
Try to do a better job of keeping example content
from being too wide. It is often rendered as <pre>
text so the only time we can wrap it is in the source.
It is best to full break lines at all punctuation and
to try to keep the width under 70 chars or so.
|
|
|
|
| |
https://wiki.gnome.org/Design/OS/Typography
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
From 30cc1512e
|
|
|
|
| |
This greatly reduces the amount of xml in the docs.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=723119
|
|
|
|
| |
We don't want to assume menu bar structures.
|
|
|
|
| |
It is a little heavy handed. The text can speak for itself.
|
| |
|
|
|
|
|
|
|
| |
Make the file chooser dialog use a headerbar
when desired.
https://bugzilla.gnome.org/show_bug.cgi?id=720059
|
| |
|
|
|
|
|
| |
Some of these should be revisited and fixed. For now,
just avoid the deprecation warnings.
|
|
|
|
|
|
|
|
|
|
|
| |
We rename the gtk_widget_class_bind_template_child{_internal}
macros by appending a _private to their name. Otherwise, it
would be too magic to pass the 'public' names as arguments,
but affect a member of the Private struct. At the same time,
Add two new macros with the old names,
gtk_widget_class_bind_template_child{_internal} that operate
on members of the instance struct.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The macros and functions are inconsistently named, and are not tied to
the "template" concept - to the point that it seems plausible to use
them without setting the template.
The new naming scheme is as follows:
gtk_widget_class_bind_template_child_full
gtk_widget_class_bind_template_callback_full
With the convenience macros:
gtk_widget_class_bind_template_child
gtk_widget_class_bind_template_child_internal
gtk_widget_class_bind_template_callback
https://bugzilla.gnome.org/show_bug.cgi?id=700898
https://bugzilla.gnome.org/show_bug.cgi?id=700896
|
|
|
|
|
|
|
|
|
|
| |
Using an offset from the struct means you can have children in
both the public and private (via G_PRIVATE_OFFSET) parts of the
instance. It also matches the new private macros nicer.
https://bugzilla.gnome.org/show_bug.cgi?id=702563
Signed-off-by: Emmanuele Bassi <ebassi@gnome.org>
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=702996
|
| |
|
|
|
|
|
| |
We'll take private structures out of gtkfilechooserprivate.h and move
them to the appropriate place.
|
| |
|
|
|
|
|
| |
Move it from the filechooserwidget to the filechooserdialog unmap
function. It was previously only working for filechooserdialogs, too.
|
| |
|
|
|
|
|
|
|
| |
The window's role is 'GtkFileChooserDialog', so that window managers can match it
for positioning.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
| |
Mostly making sure that return values and varargs don't loose
their docs.
|
|
|
|
|
|
|
| |
After some searching, it turns out that gtk-doc now interprets
markdown, and can no longer accept '-' in the docs without making
a mess. I hope that this does not affect more places in more
subtle ways.
|
| |
|
|
|
|
|
|
|
|
|
| |
Basically, don't ever set the current folder, and only use
gtk_file_chooser_set_filename() for 'File/Save As'. This is so
that the file chooser will be able to present its recently-used
lists as appropriate, giving the user good suggestions by default.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to explicitly map and unmap the child GtkFileChooserWidget when
mapping and unmapping the dialog, respectively. Now that GtkWidget actually
unmaps child widgets (instead of avoiding that), we can assume that the
child GtkFileChooserWidget will be unmapped when we wanted it to be.
This fixes a warning that happened with the new GtkWidget invariant checker,
as we were mapping our child widget before calling our parent class' ::map() handler.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
|
|
|
|
| |
Bug #630850.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't make sense to keep them separate as GtkSizeRequest requires a
GtkWidget and GtkWidget implements GtkSizeRequest, so you can never have
one without the other.
It also makes the code a lot easier because no casts are required when
calling functions.
Also, the names would translate to gtk_widget_get_width() and people
agreed that this would be a too generic name, so a "preferred" was added
to the names.
So this patch moves the functions:
gtk_size_request_get_request_mode() => gtk_widget_get_request_mode()
gtk_size_request_get_width() => gtk_widget_get_preferred_width()
gtk_size_request_get_height() => gtk_widget_get_preferred_height()
gtk_size_request_get_size() => gtk_widget_get_preferred_size()
gtk_size_request_get_width_for_height() =>
gtk_widget_get_preferred_width_for_height()
gtk_size_request_get_height_for_width() =>
gtk_widget_get_preferred_height_for_width()
... and moves the corresponding vfuncs to the GtkWidgetClass.
The patch also renames the implementations of the vfuncs in widgets to
include the word "preferrred".
|
|
|
|
|
|
|
| |
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=629598
Signed-off-by: Javier Jardón <jjardon@gnome.org>
Signed-off-by: Tristan Van Berkom <tristanvb@openismus.com>
|
|
|
|
|
| |
It seems more reasonable to remove this feature than to keep fighting
off every separator that pops up by accident in a dialog.
|
|
|
|
| |
This was reported by Christian Becke in bug 626052.
|
| |
|