summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Deprecation cleanupManish Singh2002-10-0918-275/+357
| | | | | | | | Tue Oct 8 17:34:26 2002 Manish Singh <yosh@gimp.org> * gtk/gtkmain.c gtk/gtkscrolledwindow.[ch] gtk/gtksettings.c gtk/gtkstatusbar.[ch] gtk/gtkstyle.c gtk/gtktoolbar.[ch] gtk/gtkviewport.[ch] gtk/gtkwindow.[ch]: Deprecation cleanup
* Deprecation cleanupManish Singh2002-10-0815-102/+142
| | | | | | | Tue Oct 8 15:25:53 2002 Manish Singh <yosh@gimp.org> * gtk/gtkhpaned.[ch] gtk/gtkpaned.[ch] gtk/gtkprogress.[ch] gtk/gtkprogressbar.[ch] gtk/gtkvpaned.[ch]: Deprecation cleanup
* restore gtkobject.h #include so we don't break backwards compat.Manish Singh2002-10-087-0/+33
| | | | | | | Tue Oct 8 14:49:56 2002 Manish Singh <yosh@gimp.org> * gtk/gtktreemodel.h: restore gtkobject.h #include so we don't break backwards compat.
* Patch from Takuro Ashie to fix updating of open_ims list. (#95150)Owen Taylor2002-10-087-1/+31
| | | | | | | Tue Oct 8 09:41:43 2002 Owen Taylor <otaylor@redhat.com> * Patch from Takuro Ashie to fix updating of open_ims list. (#95150)
* Move out of HAVE_XKB. (#95129, Phil Blundell)Owen Taylor2002-10-087-2/+32
| | | | | | | Mon Oct 7 19:44:45 2002 Owen Taylor <otaylor@redhat.com> * gdk/x11/gdkkeys-x11.c (_gdk_keymap_keys_changed): Move out of HAVE_XKB. (#95129, Phil Blundell)
* fix compilationEric Warmenhoven2002-10-088-3/+54
| | | | | | | | Mon Oct 7 19:14:24 2002 Eric Warmenhoven <eric@warmenhoven.org> * gdk/linux-fb/gdkwindow-fb.c: fix compilation * gdk/linux-fb/gdkmain-fb.c: better display mode setting
* Free the private data. (#84903, Matthias Clasen)Owen Taylor2002-10-077-1/+47
| | | | | | | Mon Oct 7 18:50:46 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtkcolorsel.c (gtk_color_selection_finalize): Free the private data. (#84903, Matthias Clasen)
* New file. Move gdk_drag_find_window(), gdk_drag_get_protocol() here.Owen Taylor2002-10-071-0/+48
| | | | | | | | Mon Oct 7 15:48:44 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkdnd.c Makefile.am gdk/x11/gdkdnd-x11.c gdk/fb/gdkdnd-fb.c gdk/win32/gdkdnd-win32.c: New file. Move gdk_drag_find_window(), gdk_drag_get_protocol() here.
* Allow the slider to be set all the way to the edge, and if that happens,Owen Taylor2002-10-079-6/+75
| | | | | | | | | Mon Oct 7 18:21:39 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtk[hv]paned.c gtk/gtkpaned.c: Allow the slider to be set all the way to the edge, and if that happens, use gtk_widget_set_child_visible() to hide the appropriate child. (#72784, request from Darin Adler)
* Use a pixbuf to set the drag icon, combine code to create drag iconsOwen Taylor2002-10-078-77/+201
| | | | | | | | | | | | | | | | | | | | Mon Oct 7 16:28:11 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtkcolorsel.c (palette_drag_begin): Use a pixbuf to set the drag icon, combine code to create drag icons (Fixes #80092, #80093) * gtk/gtkcolorsel.c (get_screen_color): Don't warn on failure to grab keyboard/mouse. (#80085) * gtk/gtkcolorsel.c (palette_press): Return FALSE, so DND initiation is possible. * gtk/gtkcolorsel.c (palette_release): Set the color from the palette on release, not press. * tests/testgtk.c (create_color_selection): Use gtk_widget_show_all()
* Add gdk_drag_find_window_for_screen(), so that we can interpret x_root /Owen Taylor2002-10-0713-117/+386
| | | | | | | | | | | | | | | | | | | | Mon Oct 7 15:48:44 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkdnd.[ch] gdk/x11/gdkdnd-x11.c: Add gdk_drag_find_window_for_screen(), so that we can interpret x_root / y_root relative to the correct screen. * gdk/gdkdnd.c Makefile.am gdk/x11/gdkdnd-x11.c gdk/fb/gdkdnd-fb.c gdk/win32/gdkdnd-win32.c: New file. Move gdk_drag_find_window(), gdk_drag_get_protocol() here. * gtk/gtkdnd.c: Handle drags between screens; use a fallback icon for icons set as windows/pixmaps, move the drag icon between displays for icons set as pixbufs. * gdk/x11/gdkkeys-x11.c (update_keymaps): Fix infinite loop from last change.
* - Replace GdkPointerHooks with a multihead-safe GdkDisplayPointerHooks,Owen Taylor2002-10-0724-170/+661
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mon Oct 7 15:10:00 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkdisplay.[ch] gdk/gdkinternals.h gdk/gdkwindow.[ch] gdk/linux-fb/gdkwindow-fb.c gdk/win32/gdkwindow-win32.c gdk/x11/gdkwindow-x11.c: - Replace GdkPointerHooks with a multihead-safe GdkDisplayPointerHooks, leave GdkPointerHooks around for singlehead. - Add gdk_display_get_pointer() to get the pointer location with the screen it is on. * gdk/gdk.def gdk/gdkdisplay.[ch] gdk/gdkscreen.[ch]: Change gdk_screen_get_window_at_pointer() to gdk_display_get_window_at_pointer(). * gtk/gtktreeview.c demos/gtk-demo/changedisplay.c tests/testgtk.c: Use gdk_display_get_window_at_pointer(), not gdk_screen_get_window_at_pointer(). * gtk/gtkcolorsel.c: Fix grabbing color to be multihead safe. * gtk/gtkwidget.c: Allow gtk_widget_push_colormap (NULL). since it is useful for writing code that doesn't know the dcurrent state but needs a clean colormap. * gtk/gtkrc.c: When loading the settings for a particular screen, only reset toplevels on that screen. * gtk/gtkiconfactory.h: Fix #ifdef GTK_MULTIHEAD_SAFE that should have been #ifndef GTK_MULTIHEAD_SAFE.
* Deprecation cleanupManish Singh2002-10-0718-84/+140
| | | | | | | | | Mon Oct 7 11:59:33 2002 Manish Singh <yosh@gimp.org> * gtk/gtkliststore.[ch] gtk/gtktreedatalist.[ch] gtk/gtktreednd.c gtk/gtktreemodel.[ch] gtk/gtktreemodelsort.[ch] gtk/gtktreeselection.[ch] gtk/gtktreesortable.[ch] gtk/gtktreestore.[ch]: Deprecation cleanup
* Fix some prototypes that had () instead of (void).Owen Taylor2002-10-077-2/+32
| | | | | | | Mon Oct 7 14:51:21 2002 Owen Taylor <otaylor@redhat.com> * gdk/x11/gdkx.h: Fix some prototypes that had () instead of (void).
* Clean up the handling of clearing transient state settings, fixing bugOwen Taylor2002-10-077-13/+55
| | | | | | | | | Mon Oct 7 12:40:39 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtkwindow.c (gtk_window_move_resize): Clean up the handling of clearing transient state settings, fixing bug #95026, reported by Jami Pekannen.
* If Mode_switch is used for a known modifier like Mod1, assume it won't beOwen Taylor2002-10-077-6/+56
| | | | | | | | | Mon Oct 7 11:45:17 2002 Owen Taylor <otaylor@redhat.com> * gdk/x11/gdkkeys-x11.c (update_keymaps): If Mode_switch is used for a known modifier like Mod1, assume it won't be used to switch group. (#94841, problem reported by Szekeres Istvan)
* gdk_image_get_pixel, gdk_image_put_pixel: Fixed sense of bounds checks.Bill Haneman2002-10-0710-13/+49
|
* Deprecation cleanupManish Singh2002-10-0714-153/+190
| | | | | | | Sun Oct 6 21:23:29 2002 Manish Singh <yosh@gimp.org> * gtk/gtkcontainer.[ch] gtk/gtkbox.[ch] gtk/gtkhbox.[ch] gtk/gtkvbox.[ch]: Deprecation cleanup
* deprecation cleanupManish Singh2002-10-0715-164/+214
| | | | | | | | Sun Oct 6 18:32:11 2002 Manish Singh <yosh@gimp.org> * gtk/gtkcelleditable.c gtk/gtkcellrenderer.[ch] gtk/gtkcellrendererpixbuf.[ch] gtk/gtkcellrenderertext.[ch] gtk/gtkcellrenderertoggle.[ch]: deprecation cleanup
* deprecation cleanupManish Singh2002-10-0516-245/+290
| | | | | | | Sat Oct 5 16:11:22 2002 Manish Singh <yosh@gimp.org> * gtk/gtkmisc.[ch] gtk/gtklabel.[ch] gtk/gtkimage.[ch] gtk/gtkdrawingarea.[ch] gtk/gtknotebook.[ch]: deprecation cleanup
* Use $(top_builddir) instead of here-undefined $$topdir. (Problem reportedOwen Taylor2002-10-057-1/+37
| | | | | | | | Sat Oct 5 18:30:50 2002 Owen Taylor <otaylor@redhat.com> * gtk/stock-icons/Makefile.am (pixbuf_csource): Use $(top_builddir) instead of here-undefined $$topdir. (Problem reported by Jacob Berkman)
* at Oct 5 18:25:11 2002 Owen Taylor <otaylor@redhat.com>Owen Taylor2002-10-057-2/+37
| | | | | | * gtk/gtknotebook.c (gtk_notebook_draw_tab): Fix &expose_event vs expose_event problem (#94898, reported by Jon-Kare Hellan)
* Updated Norwegian (bokmål) translation.Kjartan Maraas2002-10-052-315/+289
| | | | | | 2002-10-04 Kjartan Maraas <kmaraas@gnome.org> * no.po: Updated Norwegian (bokmål) translation.
* docs/reference/gtk/tmpl/gtkfontseldlg.sgml, gdk/gdkwindow.c,Soeren Sandmann2002-10-0513-48/+161
| | | | | | | | | | | | | | | Sat Oct 5 16:47:03 2002 Soeren Sandmann <sandmann@daimi.au.dk> * docs/reference/gtk/tmpl/gtkfontseldlg.sgml, gdk/gdkwindow.c, gdk/x11/gdkwindow-x11.c, gtk/gtkfontsel.h, gtk/gtkimcontext.c, gtk/gtktreeview.c, gtk/gtktreeviewcolumn.c Documentation fixes: #75170, Dan Winship; #73220, Havoc Pennington; #70742, Boris Shingarov; #72007, Alexey A. Malyshev
* Deprecation cleanupManish Singh2002-10-0520-287/+340
| | | | | | | | Fri Oct 4 18:40:50 2002 Manish Singh <yosh@gimp.org> * gtkcheckmenuitem.[ch] gtkimagemenuitem.[ch] gtkmenu.[ch] gtkmenubar.[ch] gtkmenuitem.[ch] gtkmenushell.[ch] gtkradiomenuitem.[ch]: Deprecation cleanup
* Deprecation cleanupManish Singh2002-10-0418-161/+186
| | | | | | | Fri Oct 4 16:48:27 2002 Manish Singh <yosh@gimp.org> * gtkaspectframe.[ch] gtkbin.[ch] gtkframe.[ch] gtkhruler.[ch] gtkruler.[ch] gtkvruler.[ch]: Deprecation cleanup
* Deprecation cleanupManish Singh2002-10-0418-130/+152
| | | | | | | Fri Oct 4 15:47:06 2002 Manish Singh <yosh@gimp.org> * gtkbbox.[ch] gtkhbbox.[ch] gtkhscale.[ch] gtkscale.[ch] gtkvscale.[ch] gtkvbbox.[ch]: Deprecation cleanup
* Fix memory intilization error caused by my previous checkin. #94908 aHidetoshi Tajima2002-10-047-1/+37
| | | | | | * modules/input/gtkimcontextxim.c (get_ic_real): Fix memory intilization error caused by my previous checkin. #94908 a patch from famao@momonga-linux.org (Motonobu Ichimura)
* Improve checks on public entry points, including, among other thingsOwen Taylor2002-10-0411-39/+132
| | | | | | | | | | | | | | | Fri Oct 4 17:13:03 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtkdnd.c: Improve checks on public entry points, including, among other things checking whether drag contexts passed in are source or dest. (Fixes #76762, Alexey A. Malyshev) * tests/testtext.c tests/testgtk.c tests/testdnd.c: Fix uninstalled operation for new pixbuf changes. * gtk/stock-icons/Makefile.am (pixbuf_csource): Fix makefile for uninstalled operation.
* remove unused codepath.Soeren Sandmann2002-10-0423-223/+254
| | | | | | | | | | Fri Oct 4 21:21:47 2002 Soeren Sandmann <sandmann@daimi.au.dk> * gtk/gtkhandlebox.c (gtk_handle_box_paint): remove unused codepath. * gtk/gtkmenuitem.c (gtk_real_menu_item_{de,}select): call gtk_widget_queue_draw() instead of gtk_widget_draw().
* Patch from Shivram U <shivaram.upadhyayula@wipro.com>Owen Taylor2002-10-047-3/+57
| | | | | | | | | | | Fri Oct 4 14:49:04 2002 Owen Taylor <otaylor@redhat.com> Patch from Shivram U <shivaram.upadhyayula@wipro.com> * gdk/x11/gdkkeys-x11.c (update_keymaps): Increased the keycount to (max_keycode - min_keycode) + 1 from (max_keycode - min_keycode). (update_keymaps), (gdk_keymap_get_entries_for_keyval) looping through less than or equal to max_keycode. (#79184)
* Remove thisAnders Carlsson2002-10-041-8/+0
|
* make legal Cjacob berkman2002-10-047-3/+28
| | | | | | 2002-10-04 jacob berkman <jacob@ximian.com> * gdk/x11/gdkscreen-x11.c (init_xinerama_support): make legal C
* Fix envars for uninstalled operation of gdk-pixbufOwen Taylor2002-10-047-2/+50
| | | | | | | | | | Fri Oct 4 12:05:27 2002 Owen Taylor <otaylor@redhat.com> * demos/Makefile.am (pixbuf_csource): Fix envars for uninstalled operation of gdk-pixbuf * demos/Makefile.am (test-inline-pixbufs.h): Remove output on failure.
* Get the name right.Owen Taylor2002-10-048-3/+51
| | | | | | | | | | Fri Oct 4 12:00:10 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkscreen.c (gdk_screen_class_init): Get the name right. * gdk/x11/gdkscreen-x11.c (gdk_screen_x11_class_init): Fix function that should have been static.
* Add a check for the Xrandr extension.Owen Taylor2002-10-0414-4/+168
| | | | | | | | | | | | | | Fri Oct 4 11:43:47 2002 Owen Taylor <otaylor@redhat.com> * configure.in: Add a check for the Xrandr extension. * gdk/gdkscreen.[ch]: Add a size-changed signal. * gdk/x11/gdkscreen-x11.[ch]: Patch from Keith packard to hook up ConfigureNotify events on the root window to the ::size-changed signal. (#94560) * gtk/gtkimcontextsimple.c: Warning fixes
* Deprecation cleanupManish Singh2002-10-0421-154/+204
| | | | | | | | Fri Oct 4 00:57:53 2002 Manish Singh <yosh@gimp.org> * gtkhscrollbar.[ch] gtkhseparator.[ch] gtkrange.[ch] gtkscrollbar.[ch] gtkseparator.[ch] gtkseparatormenuitem.h gtkvscrollbar.[ch] gtkvseparator.[ch]: Deprecation cleanup
* make it legal CManish Singh2002-10-048-1/+28
| | | | | | Thu Oct 3 22:38:12 2002 Manish Singh <yosh@gimp.org> * gdk-pixbuf/queryloaders.c: make it legal C
* make legal Cjacob berkman2002-10-042-1/+6
| | | | | | 2002-10-04 jacob berkman <jacob@ximian.com> * queryloaders.c (query_module): make legal C
* implement maximize for linux-fbEric Warmenhoven2002-10-0319-94/+440
| | | | | | | | | | | | | | | Thu Oct 3 16:40:18 2002 Eric Warmenhoven <eric@warmenhoven.org> * gdk/gdkevents.c, gdk/linux-fb/gdkwindow-fb.c, gtk/gtkwindow-decorate.c: implement maximize for linux-fb * gdk/linux-fb/gdkkeyboard-fb.c: implement raw keyboard mode * gdk/linux-fb/Makefile.am, gdk/linux-fb/gdkdnd-fb.c, gdk/linux-fb/gdkmain-fb.c, gdk/linux-fb/gdkselection-fb.c, gdk/linux-fb/miarc.c, gdk/linux-fb/mifpolycon.c, gdk/linux-fb/miwideline.c, gdk/linux-fb/mizerclip.c, gdk/linux-fb/mizerline.c: small cleanups
* Fix error in computing length and a memory leak. (Fixes #94072, reportedOwen Taylor2002-10-039-21/+95
| | | | | | | | | | | Thu Oct 3 19:00:55 2002 Owen Taylor <otaylor@redhat.com> * gdk/x11/gdkselection-x11.c (gdk_selection_property_get): Fix error in computing length and a memory leak. (Fixes #94072, reported by Hema Seetharamaiah) * gtk/gtkmenu.c (gtk_menu_motion_notify): Fix &event used instead of event.
* Adjustments for recent gdk-pixbuf changes.Matthias Clasen2002-10-0311-19/+219
|
* Support for separately installed loaders. (#77486)Matthias Clasen2002-10-0342-587/+1460
| | | | | | | | | | | | | | | | | * Makefile.am gdk-pixbuf-animation.c gdk-pixbuf-data.c gdk-pixbuf-io.c gdk-pixbuf-io.h gdk-pixbuf-loader.c gdk-pixbuf-loader.h gdk-pixbuf-private.h gdk-pixbuf.h gdk-pixdata.c io-ani-animation.h io-ani.c io-bmp.c io-gif-animation.c io-gif-animation.h io-gif.c io-ico.c io-jpeg.c io-png.c io-pnm.c io-ras.c io-tga.c io-tiff.c io-wbmp.c io-xbm.c io-xpm.c pixbufloader_ani.def pixbufloader_bmp.def pixbufloader_gif.def pixbufloader_ico.def pixbufloader_jpeg.def pixbufloader_png.def pixbufloader_pnm.def pixbufloader_ras.def pixbufloader_tga.def pixbufloader_tiff.def pixbufloader_wbmp.def pixbufloader_xbm.def pixbufloader_xpm.def test-gdk-pixbuf.c gdk-pixbuf-animation.h queryloaders.c: Support for separately installed loaders. (#77486)
* Fix memory leak. (#94399)Owen Taylor2002-10-032-1/+7
| | | | | | | Thu Oct 3 18:25:57 2002 Owen Taylor <otaylor@redhat.com> * io-jpeg.c (gdk_pixbuf__jpeg_image_save): Fix memory leak. (#94399)
* get XDisplay from window instead of display, as display has not beenKristian Rietveld2002-10-037-1/+37
| | | | | | | | Thu Oct 3 23:53:43 2002 Kristian Rietveld <kris@gtk.org> * gdk/x11/gdkwindow-x11.c (_gdk_windowing_window_destroy): get XDisplay from window instead of display, as display has not been defined here (fixes the build).
* Restore the pre-Xft2 code to render text directly via RENDER,Owen Taylor2002-10-0310-5/+154
| | | | | | | | | | Thu Oct 3 17:09:23 2002 Owen Taylor <otaylor@redhat.com> * gdk/x11/{gdkdrawable-x11.[ch],gdkpixmap-x11.c, gdkwindow-x11.c}: Restore the pre-Xft2 code to render text directly via RENDER, conditionalized with !HAVE_XFT2 so that we'll build again on Xft1 systems. (#90181)
* Add a 'type' parameter, make public.Owen Taylor2002-10-0331-266/+534
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thu Oct 3 14:13:33 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkevents.c (gdk_event_new): Add a 'type' parameter, make public. * gdk/gdkevents.c (gdk_event_copy): Copy the screen. * gdk/gdkevents.c gdk/linux-fb/gdkmain-fb.c gdk/x11/gdkevents-x11.c gdk/win32/gdkevents-win32.c: _gdk_event_new() => gdk_event_new(). * gdk/win32/gdkevents-win32.c (real_window_procedure): Fix event_private->screen breakage that results from evil encapsulation breakage here. * gtk/gtkclist.c gtk/gtkcombo.c gtk/gtkcontainer.c gtk/gtkdialog.c gtk/gtkdnd.c gtk/gtkdrawingarea.c gtk/gtkimcontextsimple.c gtk/gtklist.c gtk/gtkmenu.c gtk/gtknotebook.c gtk/gtkplug.c gtk/gtkselection.c gtk/gtktext.c gtk/gtktreeitem.c gtk/gtktreeview.c gtk/gtkviewport.c gtk/gtkwindow-decorate.c gtk/gtkwindow.c tests/testgtk.c: Remove most usage of stack-allocated GdkEvent structures. * gtk/gtktreeview.c: Use a cut-and-paste of the full send_focus_event() from gtkwindow.c that does the necessary notification of the ::has-focus property and setting of the HAS_FOCUS flag.x * gtk/gtkdnd.c: Clean up some mess/duplicated code; removing an extraneous use of a GdkEvent.
* Export _gdk_draw_pixbuf as gdk_draw_pixbuf(), rename the _draw_pixbufOwen Taylor2002-10-0222-148/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Wed Oct 2 17:46:53 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkdrawable.h gdk/gdkinternals.h gdk/gdkdraw.c gdk/gdkwindow.c gdk/gdkdrawable.c: Export _gdk_draw_pixbuf as gdk_draw_pixbuf(), rename the _draw_pixbuf virtual function to draw_pixbuf. (#60582) * gdk/gdkpixbuf-render.c (gdk_pixbuf_render_to_drawable[_alpha]): Note that these functions are obsolete in the docs. * gdk/gdkpixbuf-render.c (gdk_pixbuf_render_to_drawable): Remove all the sanity checks now we make it clear that it is obsolete name for gdk_draw_pixbuf(). * gdk/gdkpixmap.c gtk/gtkcellrendererpixbuf.c gtk/gtkimage.c gtk/gtkpixmap.c demos/testpixbuf-scale.c demos/testpixbuf.c tests/testrgb.c: Use gdk_draw_pixbuf() everywhere. * gtk/gtklabel.c (gtk_label_set_mnemonic_widget): Fix some warnings. * gdk/gdkinternals.h (struct _GdkEventPrivate): Fix missed bit from last gdk_event_get_screen() change. * gdk/gdkevents.c: Couple of small fixes.i
* Add gdk_screen_set_screen()/_get_screen() which (by evil hacks) work forOwen Taylor2002-10-029-5/+145
| | | | | | | | | Wed Oct 2 17:36:42 2002 Owen Taylor <otaylor@redhat.com> * gdk/gdkevents.[ch] gdk/x11/gdkevents-x11.[ch]: Add gdk_screen_set_screen()/_get_screen() which (by evil hacks) work for for heap allocated events and fall back gracefully for stack allocated events.
* Privately export: _gtk_settings_set_property_value_from_rc()Owen Taylor2002-10-029-44/+206
| | | | | | | | | | | | Wed Oct 2 08:47:31 2002 Owen Taylor <otaylor@redhat.com> * gtk/gtksettings.[ch]: Privately export: _gtk_settings_set_property_value_from_rc() _gtk_settings_reset_rc_values() so that we can reset settings set from RC files when reloading RC files. (#94610) * gtk/gtkrc.c: Hook up RC file setting resetting.