| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
| |
- Selection mode does not get the special devel styling.
- removed teh last-child() selector for it doesn't work anymore.
Better style all section of the headerbar than none. Proper fix pending.
https://source.puri.sm/Librem5/libhandy/issues/57
|
| |
|
|
|
|
|
|
|
| |
Instead we just cache the monitor number and get
out of it the nsscreen when it is needed. This is
a requirement since it nsscreen it is not supposed
to be cached.
Fixes: https://gitlab.gnome.org/GNOME/gtk/issues/1312
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
'1397-gtknotebook-built-in-popup-menu-listing-tabs-doesn-t-use-tab-label-text-for-the-last-tab-4' into 'master'
Notebook: Ensure menu label updates with tab_label
Closes #1397
See merge request GNOME/gtk!386
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was noticed in Firefox and demonstrated using a GtkBuilder ui file.
buildable_add_child() calls set_tab_label(), but the latter did nothing
to update the menu_label corresponding to that tab with the new text.
Using Builder to populate the tab child, only tabs other than last got
the right non-default labels, and even that was mostly coincidental, as
adding the main child called update_labels() via real_insert_page(), so
it took effect when the 2nd last main child is added, updating the rest
but leaving the last with the default label, not that given in Builder.
Fix by factoring out the code from child_reordered() to a new helper
menu_item_recreate() and calling that in set_tab_label(), so that
whenever the tab_label is updated, so is its corresponding menu_label.
This fixes the reported case and presumably others that we could write.
fixes https://gitlab.gnome.org/GNOME/gtk/issues/1397
|
| |\ \
| | |
| | |
| | |
| | | |
Don't let the OS maintain relative Z-order for windows (GTK4)
See merge request GNOME/gtk!197
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There is no reason why we shouldn't pass this flag every time
Z-order changes. We have separate routines that are used to
maintain relative Z-order, so it should be completely OK to
pass SWP_NOOWNERZORDER to let the OS know that it shouldn't try
to maintain relative Z-order of the windows when raising them.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Pass SWP_NOOWNERZORDER when rising TEMP surfaces to the top. This ensures that
they don't drag anything else to the top with them. The use-case for this is
a tooltip appearing for a non-foreground surface, causing said surface to rise
above other surfaces, some of which maybe foreground at the moment.
https://bugzilla.gnome.org/show_bug.cgi?id=784766
|
| | |/
|/|
| |
| | |
It calls set_tab_label(), which already does that.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Comments matched to reassure the compiler that fallthrough is
intentional are supposed to precede the case or default keywords, at
least in GCC, so the one here did not suppress the warning with GCC. We
can just the if condition and put the comment at the end to solve that.
https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
|
| | | |
|
| | |
| |
| |
| |
| | |
The only event signal left is ::event and everything needing that
connects to it directly.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
We do this for every single node, which is a little costly, especially
since the common case for the modelview matrix these days is a simple
translation. So, check whether the new modelview matrix is only a
translation matrix and if so, don't do a full matrix multiplication per
node.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
gdk: seal in-memory files when possible
See merge request GNOME/gtk!353
|
| | | |
| | |
| | |
| | |
| | | |
This can be used by compositors to mmap memory without having to
handle SIGBUS.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
GtkBuildable: Fix the type of the user_data in GtkBuildable.custom_tag_end
See merge request GNOME/gtk!378
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous type was a pointer to a pointer, which seems to be a copy-paste
error from GtkBuildable.custom_tag_start which is an out parameter. It was
always cast in use so this is an API break, but not an ABI one.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Commit 64a489ad inadvertently introduced a regression that broke Korean
text input because the changes there resulted that only the last input
string that we have from ImmGetCompositionStringW() for each time the
commit signal is emitted is kept, and also as a result the final Korean
character that is input by hitting space is also lost as a result, as we
didn't check for whether we are done with preediting.
Fix these issues by doing the following when we receive the
WM_IME_COMPOSITION message with GCS_RESULTSTR from Windows:
-Do not emit the commit signal during WM_IME_ENDCOMPOSITION, and...
-Emit the commit signal anyways, as we did before c255ba68, however...
-We still save up the string to commit, because we need to re-compute
the cursor position when we do ->get_preedit_string(), which needs to
take the GCS_RESULTSTR string we get from WM_IME_COMPOSITION into
account as well, so that we avoid getting the Pango criticals that
occur during Chinese (and most likely Japanese) input as the cursor
position is out-of-range.
Fixes issue #1350.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Pointer arithmetic on gpointers (void *) is a GCCism, so avoid that by
being more explicit with things.
|
| |/ / /
| | |
| | |
| | |
| | | |
Visual Studio is unlikely to support VLAs at any point, so avoid using
them and use g_newa() instead.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
gtkstack: fix null pointer dereference
See merge request GNOME/gtk!361
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The gtk_stack_snapshot_slide() function dereferences the
last_visible_child pointer without proper != NULL ckeck. This might
result in NULL pointer dereference and crash if last_visible_child is
invalid.
Add a != NULL check before dereferencing the pointer.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
GDK W32: Support switching IM contexts at runtime (GTK4)
See merge request GNOME/gtk!372
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This leverages the normal input context switching mechanism in GTK
by making it think that the gtk-im-module setting changed.
The backend returns gtk-im-module value as "ime" if W32
IME API says that an IME is in use. Otherwise it returns
and empty string - this still triggers an input context
switching code, which, not being able to create the desired context
(which is and empty string), falls back to looking at current
keyboard layout (currently that code is still a FIXME).
Paired with the code that signals gtk-im-module change on keyboard layout
switches, this is sufficient to make GTK capable of switching to
the appropriate IM context at runtime. At least, the kinds of context
that specify languages for which they are used automatically by default
(once locale matching is implemented), and the IME context.
Loading other kinds of IM context might still work via specifying
the gtk-im-module setting in gtk ini file, but doing so will likely
make GTK incapable of using the IME context that is used
for Korean, Chinese and Japanese (and some other languages).
Until someone figures out a way to actually change gtk-im-module
setting on Windows at runtime with meaningful values, the behaviour
introduced by this commit seems like a sufficient workaround.
|
| | | | | | |
|
| |/ / / / |
|
| | | | |
| | | |
| | | |
| | | | |
Fixes #1383
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
The widget observer APIs belong into the widget docs, not the window
docs. Oops.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
- don't put the gradient/cogged wheel on apps that have a split headerbar
due to having a sidebar
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
docs: Fix inclusion of source files in tutorial
See merge request GNOME/gtk!341
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Adwaita: tone down the 'devel' styling
See merge request GNOME/gtk!357
|
| |/ / / /
| | | |
| | | |
| | | | |
The selected bg was too prominent and intefered with button styling.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Make dashed border-style work correctly
See merge request GNOME/gtk!355
|
| | | | | |
| | | | |
| | | | |
| | | | | |
There’s a short-path done for focus rectangles, but it can be taken in other conditions, and then fail occasionally to render a dashed line if the border-width is too big.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
We don't technically hide the arrow nodes anymore.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Unneeded now.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | |_|/ /
|/| | | |
|
| | | | |
| | | |
| | | |
| | | | |
Close https://gitlab.gnome.org/GNOME/gtk/issues/1323#note_327705
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
flattenlistmodel: Fix uninitialized variable warning
See merge request GNOME/gtk!347
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Variable, added, would be a garbage value if model is NULL and
the following code, if condition, use the uninitialized variable.
A side effect could be occurred by that.
To avoid, the variable is initialized to zero.
|
