| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
This is a GtkGesture done to deal with stylus events from drawing tablets.
Those have a special number of characteristics that extend a regular
pointer, so it makes sense to wrap that.
|
|
|
|
|
| |
Be a good GObject citizen and use G_DECLARE_FINAL_TYPE instead of
writing the usual GObject boilerplate.
|
|
|
|
|
|
|
| |
After commit ffef28a7e8d5ffef7de6a3baccb30b0021b6b0ff,
gtk-icon-browser was spewing critical warnings when
changing sections. Avoid that by respecting the return
value of gtk_tree_model_get_iter.
|
| |
|
|
|
|
| |
It's not needed in the generic implementation, so don't have it there.
|
|
|
|
|
| |
They're only used inside the X11 backend, and the backend can just call
its own function.
|
|
|
|
| |
Does not exist anymore.
|
|
|
|
| |
This reverts commit a29306cb1e739afaa4a7b31d48c4bec328cfef9e.
|
|
|
|
|
| |
The slider gets its new size in size-allocate, so we have to do this
even if the range has no origin.
|
|
|
|
|
|
|
|
|
| |
BTN_STYLUS3 is defined by the Linux 4.15 kernel and is sent when the
third button on a stylus is pressed. At the moment, only Wacom's "Pro
Pen 3D" has three stylus buttons. Pressing this button triggers a button
8 event to be sent under X11, so we use the same mapping here.
https://bugzilla.gnome.org/show_bug.cgi?id=790033
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=792793
|
| |
|
|
|
|
|
| |
Just like we reset the scissor test and the viewport, we also can't use
the current clip anymore in this case.
|
|
|
|
|
| |
GskRoundedRect does not have a .rect member, it's 'bounds'. Also,
properly initialize all fields, i.e. all the corners.
|
|
|
|
|
|
| |
We can't just unconditionally create a larger texture here, since the
incoming cairo surface might have a device scale that doesn't fit our
scale_factor. Instead, look up the surface device scale and use that.
|
|
|
|
|
| |
In add_offscreen_ops, we use the max_x/min_x values for the texture and
viewport width, and the max_y/min_y for the texture and viewport height.
|
|
|
|
|
| |
Otherwise, overridden pick vfuncs don't work and we e.g. pick widgets
scrolled away in a viewport.
|
| |
|
|
|
|
|
| |
No need to keep a separate current_event variable around, we don't use
it anyway.
|
|
|
|
|
| |
These signals are going away, don't mention them in
the docs.
|
|
|
|
| |
We can use the existing ::event handler for this.
|
| |
|
|
|
|
| |
This fixes hidpi blurred outset shadows
|
|
|
|
|
|
|
|
| |
We have a couple of Python 3.x scripts that parse C files, and since C
does not have any encoding, we need to force one ourselves, to avoid the
case when we're running the build in a non-UTF-8 locale.
https://bugzilla.gnome.org/show_bug.cgi?id=792497
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GtkGesture is a GtkEventController. gtk_event_controller_dispose() calls
_gtk_widget_remove_controller(). That NULLs the pointer-to-Controller in
our EventControllerData but does not delete said ECData from our GList.
Subsequently, if that same Widget gets unparent()ed, that method calls
unset_state_flags(), which leads to doing reset_controllers() if we are
insensitive. Now, unlike most most other loops over the GList of ECData,
reset_controllers() does not skip nodes whose pointer-to-Controller is
NULL. So, we call gtk_event_controller_reset(NULL) and get a CRITICAL.
This surfaced in a gtkmm program. The Gesture is destroyed before the
Widget. The Widget then gets dispose()d, which calls unparent()… boom.
I didn’t find an MCVE yet but would hope this logic is correct anyway:
The simplest fix is to make the loop in gtk_widget_reset_controllers()
skip GList nodes with a NULL Controller pointer, like most other such
loops, so we avoid passing the NULL to gtk_event_controller_reset().
In other, live cases, _gtk_widget_run_controllers() loops over the GList
and removes/frees nodes having NULL Controllers, so that should suffice.
But this clearly was not getting a chance to happen in the failing case.
https://bugzilla.gnome.org/show_bug.cgi?id=792624
|
|
|
|
| |
(cherry picked from commit 814c55d473c6a7ab9f930421aad5612a351ba68d)
|
|
|
|
|
| |
Fix bug 771986 "Inconsistent 'row-activated' signal emission before \
drag'n'drop, 'activate-on-single-click'=TRUE, 'reorderable'=TRUE"
|
|
|
|
|
| |
We only use the graphene_rect_t version of the offset_clip for the
fallback cairo nodes.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This state flag is used in several places in GTK+, for example to
ignore RESIZE_INC hints if tiled. Setting it is also necessary for
backwards compatibility with applications that changed their behaviour
when tiled, such as GNOME Terminal and its MATE fork.
Signed-off-by: Simon McVittie <smcv@debian.org>
https://bugzilla.gnome.org/show_bug.cgi?id=789357
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit c415bef5de introduced support for the new _GTK_EDGE_CONSTRAINTS
atom. If the compositor supports that atom, however, we were always
setting the tiled state, even if no actual tiling information is
available, where the correct action is to completely remove any traces
of the tiled state.
Fix that by correctly removing the tiled state when compositor supports
_GTK_EDGE_CONSTRAINTS Xatom.
https://bugzilla.gnome.org/show_bug.cgi?id=788516
|
|
|
|
|
|
| |
Otherwise, gtk_widget_get_window returns NULL and we can't successfully
perform a grab via the later gdk_set_grab call. This fixes the entry
completion in the file chooser not working.
|
|
|
|
| |
Widgets are visible by default now.
|
|
|
|
|
|
|
| |
Filter models rely on views taking a ref on every node
they care about. GtkIconView was not doing that. Amazingly,
this has never shown up in a bug so far, until I spotted
the fallout in gnome-font-viewer.
|
|
|
|
|
|
|
|
| |
Test that filter models propagate ::row-changed if there is
an external reference on the node, and not otherwise. This
is showing up in buggy icon view behaviour, where the icon
view is not redrawing if the content changes in a model that
is below a filter model.
|
|
|
|
| |
Otherwise dangling callbacks may lead to crashes.
|
|
|
|
|
|
| |
We shouldn't apply the shadow offset when drawing the child offscreen,
instead apply it afterwards when we draw it to the current render
target.
|
| |
|
| |
|
|
|
|
|
| |
The default gtk_widget_contains/gtk_widget_pick don't consider
insensitive widgets.
|
|
|
|
| |
The later code would just ref both styles and not do anything else.
|
|
|
|
|
|
| |
We have to explicitly set some of these to their default values so
expand-set is TRUE and the boxes stop propagating their expansion state
up the hierarchy.
|
|
|
|
| |
Leftover from 7046463b880c79b227594a2b35a6c625119d286e
|
|
|
|
| |
Now even simpler!
|
|
|
|
|
| |
If g_type_from_name fails, try gtk_builder_get_type_from_name
before giving up. This fixes cases like GtkPrinterOptionWidget.
|
| |
|
|
|
|
|
| |
safe guard against people using the returned coordinate values without
checking the return value of gtk_widget_translate_coordinates.
|
|
|
|
|
| |
We will later pass this variable on to some other functions, so be safe
against them using the value.
|