| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
|
| |
Make it so that the repeating vs normal test only uses sharp color
cutoffs instead of real gradients. That removes rounding errors and
makes the test pass.
|
|
|
|
| |
What used to be "green" is now "lime"
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=132333
|
|
|
|
| |
Use the correct enum type.
|
|
|
|
| |
Otherwise the following else becomes attached to the wrong if.
|
|
|
|
| |
va_copy must be matched with va_end.
|
|
|
|
|
|
| |
Reestablish an else that went missing in commit 5ff328d2. Without
it, the return is reached unconditionally, and the code behind
it is dead.
|
|
|
|
|
| |
This code was clearly meant to return _after_ the loop.
Don't put the return inside the loop body, then.
|
|
|
|
| |
Coverity complains about it being uninitialized, otherwise.
|
|
|
|
|
| |
We were intentionally falling through here, this commit
just adds comments to make that explicit.
|
|
|
|
|
| |
This switch was entirely breakless. Amazing accessibility code,
found by Coverity.
|
|
|
|
|
| |
This code confused Coverity into thinking we were falling through,
when we were not. Add a few explicit breaks to clear that up.
|
|
|
|
|
|
| |
The GTK_BORDER_STYLE_DOUBLE case was clearly not meant to
fall through to the subsequent cases, yet it did.
Found by Coverity.
|
|
|
|
|
| |
Don't access vadjustment after checking hadjustment for
not being NULL. Found by Coverity.
|
|
|
|
|
|
| |
The code clearly meant to reset action->active here.
This was found by Coverity.
|
|
|
|
|
|
|
| |
Due to a copy-paste error, the code failed to compare the
contain members of value1 and value2.
This was found by Coverity.
|
|
|
|
|
|
|
|
| |
This was broken since commit b2aaa94 in 2008. Its commit message
clearly states that the intention was to check for GTK_GRAB,
GTK_UNGRAB and STATE_CHANGED. Lets do that, then.
This was found by Coverity.
|
|
|
|
|
|
| |
Clearly, what was meant here was that we create a new attribute
list if either of the input attribute lists are non-NULL.
This was found by Coverity.
|
|
|
|
|
|
|
|
|
| |
gtk+ was trying to display already freed strings, leaking memory,
...I noticed this because I was getting weird blinking characters
as the status of my cups printers, and valgrind confirmed something
was wrong.
https://bugzilla.gnome.org/show_bug.cgi?id=683072
|
|
|
|
| |
This fixes a warning with gobject-introspecion scanning
|
|
|
|
| |
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
|
|
|
|
| |
Signed-off-by: Gheyret Kenji <gheyret@gmail.com>
|
|
|
|
| |
y coordinates don't care about the right value, they want bottom.
|
| |
|
| |
|
|
|
|
|
| |
to fix the build, thanks to parafin for the patch.
(cherry picked from commit e3e055f8551ac8ee033f361261c849c612554184)
|
|
|
|
|
| |
We assume a reference to all the GtkCssValues we store, so we need to
release it when free-ing.
|
|
|
|
|
|
|
| |
This is a simple fallout from sealing gtkmenushell, which only appears
when F10 or Shift-F10 is used in a submenu.
https://bugzilla.gnome.org/show_bug.cgi?id=690266
|
| |
|
|
|
|
|
|
| |
When checking for modal grabs in gtk_main_do_event(), forward
GDK_SCROLL events to event_widget, even if it is insensitive.
(cherry picked from commit 343f1706bd51b830ff66c67b163f397889a96758)
|
|
|
|
|
|
|
|
|
|
| |
In gtkimcontextime.c, use gdk_win32_window_get_impl_hwnd() to get to
the impl's existing native window instead of GDK_WINDOW_HWND() which
implicitly ensures a native window for the widget itself. This seems
to work around whatever GDK problem with native subwindows and fixes
the bug.
This is based on Michael Natterer's fix for gtk-2-24.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We must not release the GtkClipboardOwner in pasteboardChangedOwner
becaue we don't own a reference to ourselves (NSPasteboard does).
Instead, release the owner right after setting it, transferring
ownership to NSPasteboard
Also, fix repeated setting of the same owner by keeping the
owner around in GtkCLipboard, and re-use it if "user_data"
doesn't change. To avoid clipboard_unset()ting our own contents
in the process, add an ugly "setting_same_owner" boolean to
GtkClipboardOwner, set it during re-setting the same owner,
and avoid calling clipboard_unset() from pasteboardChangedOwner
if it's TRUE.
(cherry picked from commit 4a8df7a33c298d22bf78b947d0e861fc03ec70e1)
|
|
|
|
|
|
| |
This is necessary because values in a GtkCssComputedValues can change
now. So if the font-size is inherited or animated, the cached value will
be outdated.
|
|
|
|
|
|
| |
Revert the second part of the commit
6ad6f719c6b2fc7cf797c86b406f4e61d9fca4d1. mark_printer_active()
was called without its second parameter in g_list_free_full().
|
|
|
|
|
|
|
|
|
|
|
| |
pasteboardChangedOwner is not called as reliably as we'd want to get it,
so keep track of [pasteboard changeCount] and drop clipboard ownership
when a change happened. Also better unset the clipboard content redundantly
in a few places rather than missing one, and reorder the code in
gtk_clipboard_set_contents() so that the new aggressive unsetting
won't unset the clipboard under our feet when we call
[pasteboard declareTypes].
(cherry picked from commit f2b74db5dcbd28a1e27431f413c66d2a5d50b2bd)
|
|
|
|
| |
(cherry picked from commit 9eea724e3b5eeb3d5d483b5a0c30d4b70a448741)
|
|
|
|
|
|
| |
So " plus foo prduces foo-with-diaereses and ' plus c produces
c-with-cedilla.
(cherry picked from commit f619f91a8fb8e01e399ab29c1f1355146d730bc4)
|
|
|
|
|
|
|
|
|
|
| |
Both flashing a window and setting the window opacity were using
incorrect declarations for function pointers. They were missing the
WINAPI annotation as defined in windows.h. As a result, the stack
could be corrupted when these functions were invoked.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=689235
(cherry picked from commit 5637ef1f97ee46666c97707ed7f6bae459007163)
|
|
|
|
|
| |
Also use GDK_OSX_UNSUPPORTED instead of 0 in gdk_quartz_osx_version().
(cherry picked from commit 9644e910a85f97aedf3f5f4fee974229f29766c3)
|
|
|
|
|
| |
Thanks to Paul Davis for pointing this out.
(cherry picked from commit d6533ffc44d77b42cce7987f249fa481581b7c50)
|
|
|
|
|
|
| |
This commit fixes a regression caused by a patch to remove Cups 1.2
ifdefs. This resulted in the "installable options" to appear in the
print dialog.
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=93381
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=687816
|
|
|
|
|
|
|
| |
In the setter, we only set fixed height mode and queue a revalidation of
the row heights.
https://bugzilla.gnome.org/show_bug.cgi?id=687816
|
|
|
|
|
|
|
|
|
|
| |
The documentation for gtk_file_chooser_get_filenames() states that the
returned filenames are absolute paths, and uses g_file_get_path() to
construct the filename. The same function is used to construct the
filename in gtk_file_chooser_get_filename(), so it should also return
absolute paths.
https://bugzilla.gnome.org/show_bug.cgi?id=371034
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=688884
|