| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
| |
Windows does not send any release key event for one of the shift keys
when both shift keys were pressed together. This commit solves
the problem by sending the extra release key event for the shift key
which was released as first, when the other shift key is released.
Other modifiers (e.g. Ctrl, Alt) do not have this problem.
https://bugzilla.gnome.org/show_bug.cgi?id=751721
(cherry picked from commit 44608dadc67749df15525b8386f95ad39e48c5ef)
|
| |
|
|
|
|
|
| |
One of the backported fixes brought in a dependency on new glib
that I didn't mean to introduce here. Avoid it.
|
| |
|
| |
|
|
|
|
|
| |
Since the stock strings usually have menmosics suggest
gtk_menu_item_new_with_mnemonic().
|
|
|
|
|
| |
gtk_menu_item_new(9 would create an empty menu item. While the stock deprecation
aims to unclutter the menus, I feel this goes too far.
|
|
|
|
|
|
|
|
| |
We automatically pick up an adjustment from our parent
scrollable, but we failed to update it when it changes.
This is happening in the places sidebar, and it was causing
the focus-tracking to fail there, letting the focus move
out of view. With this change, the focus remains visible.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=752502
|
|
|
|
|
|
|
| |
cairo_xlib_surface_get_visual might return NULL so we need to
check for NULL before trying to use it.
https://bugzilla.gnome.org/show_bug.cgi?id=752520
|
|
|
|
|
|
|
|
| |
We need to check on realize if we have access to a GL context, before
calling GL functions. We use gtk_gl_area_get_error() for that.
We also need to tear down the resources during unrealization, instead
of leaking them.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=752093
|
|
|
|
|
|
|
|
|
|
| |
The menu tracker does a better job of this than we can, so move over to
using it instead.
This fixes issues with './testgmenu --import' not properly displaying
the language submenu.
https://bugzilla.gnome.org/show_bug.cgi?id=752016
|
|
|
|
|
| |
The GdkEvent field is nullable on gtk_drag_begin*, and gtk_drag_cancel()
is a method, like the rest of the DnD API.
|
|
|
|
|
|
|
| |
g_set_object() will take care of ref'ing before destroying the previous
instance, which might actually be the same pointer.
https://bugzilla.gnome.org/show_bug.cgi?id=751401
|
|
|
|
|
|
|
|
| |
In case the X11 backend is not enabled, we still need to include the
pangofc-fontmap.h header file, as we use the Pango/FontConfig API in
both the X11 and Wayland case.
https://bugzilla.gnome.org/show_bug.cgi?id=751625
|
| |
|
| |
|
|
|
|
|
| |
The display is getting overwritten immediately. Pointed out by
coverity.
|
|
|
|
|
| |
Coverity pointed out that getting a class name requires
dereferencing the pointer, so only don't do it if it is NULL.
|
|
|
|
|
|
| |
We were printing a string in a warning after freeing it.
Also, fix an x/y typo that might cause popovers to be
mispositioned.
|
|
|
|
| |
Pointed out by coverity
|
|
|
|
| |
Not sure what I was thinking here. Coverity pointed this out.
|
| |
|
|
|
|
|
|
| |
I believe that first_column can only ever be NULL here if
last_column is NULL too, in which case we'd exited already.
But coverity doesn't see that, so add an explicit exit.
|
|
|
|
| |
Coverity uses these as clues to complain.
|
|
|
|
| |
Again, coverity takes these as clues to complain.
|
|
|
|
|
| |
Coverity has the annoying habit of guessing backwards that
if we check the value here, it might be NULL earlier.
|
| |
|
|
|
|
| |
Coverity complained about these.
|
|
|
|
|
| |
This may help coverity recognize that we're not called with
invalid combinations.
|
|
|
|
|
| |
Coverity complained about us ignoring the return value
here, and it is nicer to get an error message about this.
|
|
|
|
|
| |
We're closing this fd, but we're not going to do anything else
if that fails. Annotate to let coverity see this.
|
|
|
|
|
|
|
| |
We don't care about the error here, but we were relying on
g_resources_get_info to zero the size even in case of error.
No need to do that, we can just check the return value. Plus,
it makes coverity happy.
|
|
|
|
|
|
|
| |
The way this code is written, we know that there is an item in
the hash table and the iter_next call will give it to us, so
no need to check the return value. Annotate the call to tell
coverity.
|
|
|
|
|
| |
We were already looking at the error anyway, but rewriting things
this way lets coverity see the light.
|
|
|
|
|
| |
Add some assertions that things are non-NULL when we know they
are, so that coverity gets it.
|
|
|
|
| |
Found by coverity.
|
| |
|
|
|
|
|
|
| |
This reverts commit 3d9cce79cf16bce335599b3b78b6bd0a04e37560.
The commit broke more scenarios than fixed, better to go back to square one.
|
|
|
|
|
|
|
|
|
|
|
|
| |
messages
When using frame times from _NET_WM_FRAME_DRAWN and _NET_WM_FRAME_TIMINGS, we
were treating them as local monotonic times, but they are actually extended-precision
versions of the server time, and need to be translated to monotonic times in the
case where the X server and client aren't running on the same system.
This fixes rendering stalls when using X over a remote ssh connection.
https://bugzilla.gnome.org/show_bug.cgi?id=741800
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Support was added for GDK_HINT_ASPECT in
gdk_quartz_window_set_geometry_hints though with one restriction:
min_aspect and max_aspect have to be equal, which I believe corresponds
to the most common usage. A warning will be printed if this condition is
not met but min_aspect will be used anyway.
|
| |
|
|
|
|
|
|
| |
Fixes reftests.
https://bugzilla.gnome.org/show_bug.cgi?id=750605
|
|
|
|
|
| |
This prevents it from creating a _NET_WM_USER_TIME_WINDOW, which can
confuse mutter / other window managers, and also me, when debugging.
|
|
|
|
| |
Do not suggest using icons that do not exist.
|
|
|
|
|
| |
Now that gtk_widget_reparent() has been deprecated, we should not
suggest it.
|