| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
The selector for matching GtkEntry has changed to `entry` after 3.20.
https://bugzilla.gnome.org/show_bug.cgi?id=766166
|
| |
|
|
|
|
|
| |
relocate treview acceleditor > label in the treeview section and
add a comment for a testcase.
|
|
|
|
| |
...removing a double definition in the process.
|
|
|
|
|
|
|
| |
We were failing to take the widget allocation.x/y into account
when deciding whether we need to push in the mark.
https://bugzilla.gnome.org/show_bug.cgi?id=765922
|
|
|
|
|
|
| |
The active keyboard grab can be spared then. This way the passive
key grabs allow other key combinations (eg. alt-tab) that are not
mandatory to grab here.
|
|
|
|
|
|
|
| |
FTS5 has a complex enough syntax that it makes not much sense to wrap
in simple search boxes.
https://bugzilla.gnome.org/show_bug.cgi?id=765981
|
|
|
|
|
| |
No need to check for it, we set the css name on GtkWidgetClass
ourselves.
|
|
|
|
|
| |
As the documentation states, neither the switch nor the slider gadget
should be using any style classes.
|
|
|
|
|
|
| |
Instead of creating 2 pango layouts in every draw() and on in
_get_content_size (and calling into gettext twice in both cases), just
keep the layouts around and create them in only one place.
|
|
|
|
|
| |
So gtk_label_get_text returns the default value of "". Broke the
GtkModelButton default value test.
|
|
|
|
|
| |
It would just set up lots of things with the default values, but a
common case is that a few gtk_label_set_* calls follow.
|
|
|
|
| |
Stop comparing them to NULL.
|
|
|
|
|
| |
We set them later again when we calculate the vertical size, so just
move the general assignment to -1 into the horizontal branch.
|
|
|
|
|
| |
We are checking for allocation != NULL at the beginning of the function
already. This also means that the allocation parameter is not nullable.
|
| |
|
| |
|
|
|
|
|
|
|
| |
The fallback code for rendering builtin checks, radios
and expanders was using border parameters. With the generic
gadget borders using the same parameters, this was giving
double borders.
|
| |
|
|
|
|
|
| |
As pointed out in https://bugzilla.gnome.org/show_bug.cgi?id=765676,
we were failing to set position_set if the position did not change.
|
|
|
|
|
|
|
|
| |
Specifically, this URI is not supported on Windows, but GFile will
do its "best" and turn it into GLocalFile("$pwd/network"), with
spectacularly bad results.
https://bugzilla.gnome.org/show_bug.cgi?id=765858
|
|
|
|
| |
Those should be freed together with their list link.
|
|
|
|
| |
I am not sure if this happens in practice, but better to be safe.
|
|
|
|
| |
These events were never freed.
|
|
|
|
| |
These have been sitting here forever, unused. Time to drop them
|
|
|
|
|
| |
We were keeping all the event sources in a list, only to remove
them at the end of their life. Not useful.
|
|
|
|
|
| |
We were keeping all the event sources in a list, only to remove
them at the end of their life. Not useful.
|
| |
|
|
|
|
| |
It should just return the same as gdk_screen_make_display_name.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only keep one align flag per child, so it seems odd to
keep separate h/v expand flags. Just keep one expand flag
and interpret it according to orientation. Allow setting
the expand flag for child widgets too, though, so we can
make widget expand without interfering with the recursive
widget expand flag.
Update all callers.
Use the new possibility of expanding child widgets to make
the label of check and radio buttons expand. This fixes
unexpected behavior of these widgets in RTL in some places.
https://bugzilla.gnome.org/show_bug.cgi?id=765742
|
|
|
|
| |
Flip alignments of the title gadget children.
|
|
|
|
| |
Flip alignments for the box gadget children.
|
|
|
|
|
|
|
| |
In RTL, we want to interpret GTK_ALIGN_START and _END
in the opposite way. Since we don't give gadgets a text
direction, just allow setting an align_reverse flag
to the box gadget.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If there was a piece of text in the cell, then when the edit
entry is shown for that cell, it should have a piece of text
in it roughly at the same location.
Therefore, when child widget is enlarged (child preferred
size exceeds cell size), extra width should be added by
extending either left or right edge depending on text direction.
If after that the child sticks outside of the treeivew visible region,
try to push it back inside (breaking its alignment with the
cell), again, giving preference (i.e. adjusting it last)
to either left or right edge depending on text direction.
https://bugzilla.gnome.org/show_bug.cgi?id=765471
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NoSymbol is not a valid GDK symbol (it only has the concept of
VoidSymbol, for some reason, which is neither the same thing nor
produced by any sane keymap). Passing NoSymbol events through to GTK+
apps is unlikely to produce anything useful.
In particular, this meant VTE would scroll to the end of the buffer when
pressing Fn (required for Page Up/Down on Macs), as it was receiving a
keypress that wasn't a modifeir. This does not happen on X11, as the
KEY_FN keycode is above 255, so does not get sent to clients.
https://bugzilla.gnome.org/show_bug.cgi?id=764825
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids the g_source_remove(), g_source_destroy(),
g_timer_source_new(), and g_source_set_name_by_id() in the common case.
Instead, we reuse our previous source and update the ready time to our
new deadline. We lose the coalescing with g_timeout_add_seconds(), but
that is not going to help in the common case anyway (unless you have
three hands and can scroll multiple pixelcached backed widgets at once).
https://bugzilla.gnome.org/show_bug.cgi?id=765640
|
|
|
|
|
|
|
|
| |
In non-composited environments, we were ending up with all-black
drag icons, because nothing was drawing the background of our new
toplevel. Fix this by drawing background when we are not composited.
We don't do this when composited, since we want to allow transparent
icons.
|
|
|
|
| |
There is nothing textview-specific here.
|
|
|
|
|
|
|
| |
When measuring gadgets, minimum must come out <= natural.
Make sure we don't fail this when measuring progressbar text.
https://bugzilla.gnome.org/show_bug.cgi?id=765644
|
|
|
|
|
|
|
|
|
| |
The documentation clearly says that the widget is not destroyed,
but we were in fact failing to keep it alive, since it was still
a child or the icon_window when we destroy that. Fix this by
reparenting the icon_widget out before. Also, deal with the
possibility that the application might destroy the widget
halfway through, for whatever reason.
|
|
|
|
|
|
| |
I added a new test function, but didn't actually use it.
No wonder I couldn't reproduce the lifecycle issues with
drag widgets that firefox is experiencing.
|
|
|
|
|
|
|
|
|
|
| |
Always associate a drag context with a GdkDisplay and use that when
getting a cursor for a given action.
If we don't do this, dragging on a window that doesn't use the default
display will make us use cursors from the wrong display.
https://bugzilla.gnome.org/show_bug.cgi?id=765565
|
|
|
|
|
|
|
|
| |
Typically, there won't be any references on old frame timings except for
the most recent timing. So instead of discarding these and re-entering
gslice twice, just steal the old frame timing and reuse it.
https://bugzilla.gnome.org/show_bug.cgi?id=765592
|
|
|
|
|
|
|
|
| |
Don't track all orphaned dialogs globally, as mixing them up with each
other would in most cases trigger errors when we try to pass bogus
values to Wayland requests.
https://bugzilla.gnome.org/show_bug.cgi?id=765474
|
|
|
|
|
| |
This adds a testcase which reuses the drag widget for multiple
drags.
|
|
|
|
| |
This is not freely settable.
|