diff options
| author | Jonas Ådahl <jadahl@gmail.com> | 2020-12-07 18:18:38 +0100 |
|---|---|---|
| committer | Jonas Ådahl <jadahl@gmail.com> | 2020-12-07 20:37:30 +0100 |
| commit | d2c95a1b13ee710fcfc69a592be669bcea4b26e8 (patch) | |
| tree | 0b94b1569acc71d4c4196f2fc85a7b44b65e91b6 /tests | |
| parent | 8f8c5040dbfc9fe1bac0df7664c39f65c3110428 (diff) | |
| download | gtk+-d2c95a1b13ee710fcfc69a592be669bcea4b26e8.tar.gz | |
gdk: Replace 'WITHDRAWN' state with async 'is-mapped' boolean
It was used by all surfaces to track 'is-mapped', but still part of the
GdkToplevelState, and is now replaced with a separate boolean in the
GdkSurface structure.
It also caused issues when a widget was unmapped, and due to that
unmapped a popover which hid its corresponding surface. When this
surface was hidden, it emitted a state change event, which would then go
back into GTK and queue a resize on popover widget, which would travel
back down to the widget that was originally unmapped, causing confusino
when doing future allocations.
To summarize, one should not hide widgets during allocation, and to
avoid this, make this new is-mapped boolean asynchronous when hiding a
surface, meaning the notification event for the changed mapped state
will be emitted in an idle callback. This avoids the above described
reentry issue.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/testgtk.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/testgtk.c b/tests/testgtk.c index 06a9f0f06a..077d16136b 100644 --- a/tests/testgtk.c +++ b/tests/testgtk.c @@ -4531,8 +4531,6 @@ surface_state_callback (GdkSurface *window, new_state = gdk_toplevel_get_state (GDK_TOPLEVEL (window)); msg = g_strconcat ((const char *)g_object_get_data (G_OBJECT (label), "title"), ": ", - (new_state & GDK_TOPLEVEL_STATE_WITHDRAWN) ? - "withdrawn" : "not withdrawn", ", ", (new_state & GDK_TOPLEVEL_STATE_MINIMIZED) ? "minimized" : "not minimized", ", ", (new_state & GDK_TOPLEVEL_STATE_STICKY) ? |