diff options
| author | Benjamin Otte <otte@redhat.com> | 2017-10-06 21:19:42 +0200 |
|---|---|---|
| committer | Benjamin Otte <otte@redhat.com> | 2017-10-06 21:23:39 +0200 |
| commit | 43c212ac28f5f80e10c49590e569b6450098743f (patch) | |
| tree | ae5210d90f79d313d3b4c88c88f5e00b87405e0e /gtk/gtkwindow.c | |
| parent | 2ac66328a3edc0838c19b49fcb9468c473936c9c (diff) | |
| download | gtk+-43c212ac28f5f80e10c49590e569b6450098743f.tar.gz | |
build: Enable -Wswitch-enum and -Wswitch-default
This patch makes that work using 1 of 2 options:
1. Add all missing enums to the switch statement
or
2. Cast the switch argument to a uint to avoid having to do that (mostly
for GdkEventType).
I even found a bug while doing that: clearing a GtkImage with a surface
did not notify thae surface property.
The reason for enabling this flag even though it is tedious at times is
that it is very useful when adding values to an enum, because it makes
GTK immediately warn about all the switch statements where this enum is
relevant.
And I expect changes to enums to be frequent during the GTK4 development
cycle.
Diffstat (limited to 'gtk/gtkwindow.c')
| -rw-r--r-- | gtk/gtkwindow.c | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/gtk/gtkwindow.c b/gtk/gtkwindow.c index 4d95aa257e..91b637a401 100644 --- a/gtk/gtkwindow.c +++ b/gtk/gtkwindow.c @@ -1411,6 +1411,8 @@ gtk_window_titlebar_action (GtkWindow *window, case GDK_BUTTON_SECONDARY: g_object_get (settings, "gtk-titlebar-right-click", &action, NULL); break; + default: + break; } if (action == NULL) @@ -1531,6 +1533,14 @@ multipress_gesture_pressed_cb (GtkGestureMultiPress *gesture, gtk_gesture_set_sequence_state (GTK_GESTURE (gesture), sequence, GTK_EVENT_SEQUENCE_CLAIMED); break; + case GTK_WINDOW_REGION_EDGE_NW: + case GTK_WINDOW_REGION_EDGE_N: + case GTK_WINDOW_REGION_EDGE_NE: + case GTK_WINDOW_REGION_EDGE_W: + case GTK_WINDOW_REGION_EDGE_E: + case GTK_WINDOW_REGION_EDGE_SW: + case GTK_WINDOW_REGION_EDGE_S: + case GTK_WINDOW_REGION_EDGE_SE: default: if (!priv->maximized) { @@ -1585,6 +1595,15 @@ drag_gesture_begin_cb (GtkGestureDrag *gesture, gtk_gesture_set_state (GTK_GESTURE (gesture), GTK_EVENT_SEQUENCE_DENIED); break; + + case GTK_WINDOW_REGION_EDGE_NW: + case GTK_WINDOW_REGION_EDGE_N: + case GTK_WINDOW_REGION_EDGE_NE: + case GTK_WINDOW_REGION_EDGE_W: + case GTK_WINDOW_REGION_EDGE_E: + case GTK_WINDOW_REGION_EDGE_SW: + case GTK_WINDOW_REGION_EDGE_S: + case GTK_WINDOW_REGION_EDGE_SE: default: gtk_gesture_set_state (GTK_GESTURE (gesture), GTK_EVENT_SEQUENCE_DENIED); } @@ -8502,6 +8521,7 @@ gtk_window_compute_configure_request (GtkWindow *window, } break; + case GTK_WIN_POS_NONE: default: break; } |