diff options
| author | Philip Withnall <philip.withnall@collabora.co.uk> | 2013-11-26 15:06:48 +0000 |
|---|---|---|
| committer | Philip Withnall <philip.withnall@collabora.co.uk> | 2013-12-02 10:36:26 +0000 |
| commit | b37f8b80b46f3453491f5de4df2ca1437c30582b (patch) | |
| tree | 6958580579f587359031302e44fd23e7cfdca2bb /gtk/gtkprintunixdialog.c | |
| parent | 380150361b8ab22f9a14d4f68de865d10e6ec62e (diff) | |
| download | gtk+-b37f8b80b46f3453491f5de4df2ca1437c30582b.tar.gz | |
gtkprintunixdialog: Remove a redundant (GFile != NULL) check
g_file_new_for_uri() is guaranteed to return a non-NULL value, so this
check was redundant, and was confusing the static analyser into
returning a false positive, where it thought the file could be NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=712760
Diffstat (limited to 'gtk/gtkprintunixdialog.c')
| -rw-r--r-- | gtk/gtkprintunixdialog.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gtk/gtkprintunixdialog.c b/gtk/gtkprintunixdialog.c index ea66c6703d..763775c547 100644 --- a/gtk/gtkprintunixdialog.c +++ b/gtk/gtkprintunixdialog.c @@ -659,8 +659,7 @@ error_dialogs (GtkPrintUnixDialog *print_dialog, { file = g_file_new_for_uri (option->value); - if (file != NULL && - g_file_query_exists (file, NULL)) + if (g_file_query_exists (file, NULL)) { toplevel = get_toplevel (GTK_WIDGET (print_dialog)); |