diff options
| author | Benjamin Otte <otte@redhat.com> | 2017-10-06 21:19:42 +0200 |
|---|---|---|
| committer | Benjamin Otte <otte@redhat.com> | 2017-10-06 21:23:39 +0200 |
| commit | 43c212ac28f5f80e10c49590e569b6450098743f (patch) | |
| tree | ae5210d90f79d313d3b4c88c88f5e00b87405e0e /gtk/gtkmenuitem.c | |
| parent | 2ac66328a3edc0838c19b49fcb9468c473936c9c (diff) | |
| download | gtk+-43c212ac28f5f80e10c49590e569b6450098743f.tar.gz | |
build: Enable -Wswitch-enum and -Wswitch-default
This patch makes that work using 1 of 2 options:
1. Add all missing enums to the switch statement
or
2. Cast the switch argument to a uint to avoid having to do that (mostly
for GdkEventType).
I even found a bug while doing that: clearing a GtkImage with a surface
did not notify thae surface property.
The reason for enabling this flag even though it is tedious at times is
that it is very useful when adding values to an enum, because it makes
GTK immediately warn about all the switch statements where this enum is
relevant.
And I expect changes to enums to be frequent during the GTK4 development
cycle.
Diffstat (limited to 'gtk/gtkmenuitem.c')
| -rw-r--r-- | gtk/gtkmenuitem.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gtk/gtkmenuitem.c b/gtk/gtkmenuitem.c index efddab514e..0c98806f46 100644 --- a/gtk/gtkmenuitem.c +++ b/gtk/gtkmenuitem.c @@ -1351,6 +1351,7 @@ popped_up_cb (GtkMenu *menu, break; case GTK_DIRECTION_RIGHT: + default: menu_item->priv->submenu_direction = GTK_DIRECTION_LEFT; break; } @@ -1425,6 +1426,7 @@ gtk_menu_item_real_popup_submenu (GtkWidget *widget, break; case GTK_LEFT_RIGHT: + default: if (parent_menu && GTK_IS_MENU_ITEM (parent_menu->priv->parent_menu_item)) submenu_direction = GTK_MENU_ITEM (parent_menu->priv->parent_menu_item)->priv->submenu_direction; else @@ -1451,6 +1453,7 @@ gtk_menu_item_real_popup_submenu (GtkWidget *widget, switch (submenu_direction) { case GTK_DIRECTION_RIGHT: + default: g_object_set (priv->submenu, "rect-anchor-dx", horizontal_offset + parent_padding.right + menu_padding.left, NULL); |