Argh, decided not to return a string that must be freed from

gtk_file_selection_get_filename after all, as that would
cause memory leaks in all apps that use it unless they
specifically checked fot the GTk+ version.

gtk_file_selection_get_filename returns the filename in the C
runtime encoding. It calls g_filename_from_utf8, but copies the
returned string to a static buffer, which is returned. I think
this is better than returning the result from g_filename_from_utf8
directly, which would mean all apps that use it would have to free
the return value. Or should this function care about this issue at
all? Maybe a new function with clearly defined semantics.

1 files changed, 2 insertions, 1 deletions

diff --git a/gtk/gtkfilesel.h b/gtk/gtkfilesel.h
index 24ff5de521..d5970c3f1a 100644
--- a/gtk/gtkfilesel.h
+++ b/gtk/gtkfilesel.h
@@ -89,7 +89,8 @@ void       gtk_file_selection_set_filename        (GtkFileSelection *filesel,
 /* This function returns the selected filename in the C runtime's
  * multibyte string encoding, which may or may not be the same as that
  * used by GDK (UTF-8). To convert to UTF-8, call g_filename_to_utf8().
- * The returned string should be deallocated with g_free().
+ * The returned string points to a statically allocated buffer and
+ * should be copied away.
  */
 gchar*     gtk_file_selection_get_filename        (GtkFileSelection *filesel);