summaryrefslogtreecommitdiff
path: root/gtk/gtkcssbordervalue.c
diff options
context:
space:
mode:
authorDaniel Boles <dboles@src.gnome.org>2017-08-01 19:31:20 +0100
committerDaniel Boles <dboles@src.gnome.org>2017-08-01 20:12:44 +0100
commit5e6293e54f9d807869835dfbb8814819e1449401 (patch)
treecbe86419f094168a8f6c53d8bcfd27def1c61fb5 /gtk/gtkcssbordervalue.c
parent0b230d34c4b01b4540ad1986031d206d8293b6d4 (diff)
downloadgtk+-5e6293e54f9d807869835dfbb8814819e1449401.tar.gz
cssbordervalue: Fix possible use of uninitialised
If value->values[i] is NULL, then values[i] was left uninitialised. The code then reads each element of values[]. CID 1432029 (#1 of 1): Uninitialized pointer read (UNINIT) 11. uninit_use: Using uninitialized value values[i].
Diffstat (limited to 'gtk/gtkcssbordervalue.c')
-rw-r--r--gtk/gtkcssbordervalue.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/gtk/gtkcssbordervalue.c b/gtk/gtkcssbordervalue.c
index 5140057289..d95196ca02 100644
--- a/gtk/gtkcssbordervalue.c
+++ b/gtk/gtkcssbordervalue.c
@@ -60,6 +60,10 @@ gtk_css_value_border_compute (GtkCssValue *value,
values[i] = _gtk_css_value_compute (value->values[i], property_id, provider, style, parent_style);
changed |= (values[i] != value->values[i]);
}
+ else
+ {
+ values[i] = NULL;
+ }
}
if (!changed)