diff options
| author | Matthias Clasen <mclasen@redhat.com> | 2006-08-15 05:46:08 +0000 |
|---|---|---|
| committer | Matthias Clasen <matthiasc@src.gnome.org> | 2006-08-15 05:46:08 +0000 |
| commit | bb279057f361e421a0447617487f65f1e8a79931 (patch) | |
| tree | 61c6905bbcac491ec379f3450ab108fe7345ab8e /gdk | |
| parent | e4f6c9d4d00daf6bac3898e75268ebdb92bba091 (diff) | |
| download | gtk+-bb279057f361e421a0447617487f65f1e8a79931.tar.gz | |
Zero out some stack-allocated X structures, to avoid valgrind warnings
2006-08-15 Matthias Clasen <mclasen@redhat.com>
* gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd):
* gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations):
(gdk_window_set_functions): Zero out some stack-allocated
X structures, to avoid valgrind warnings about uninitialized
memory. (#349382, David Baron)
Diffstat (limited to 'gdk')
| -rw-r--r-- | gdk/x11/gdkdnd-x11.c | 2 | ||||
| -rw-r--r-- | gdk/x11/gdkwindow-x11.c | 4 |
2 files changed, 6 insertions, 0 deletions
diff --git a/gdk/x11/gdkdnd-x11.c b/gdk/x11/gdkdnd-x11.c index 7e0961c771..47178f2584 100644 --- a/gdk/x11/gdkdnd-x11.c +++ b/gdk/x11/gdkdnd-x11.c @@ -3754,6 +3754,8 @@ gdk_window_register_dnd (GdkWindow *window) motif_drag_receiver_info_atom = gdk_x11_get_xatom_by_name_for_display (display, "_MOTIF_DRAG_RECEIVER_INFO"); + /* initialize to zero to avoid writing uninitialized data to socket */ + memset(&info, 0, sizeof(info)); info.byte_order = local_byte_order; info.protocol_version = 0; info.protocol_style = XmDRAG_DYNAMIC; diff --git a/gdk/x11/gdkwindow-x11.c b/gdk/x11/gdkwindow-x11.c index 80f5ff3842..2a71b22ada 100644 --- a/gdk/x11/gdkwindow-x11.c +++ b/gdk/x11/gdkwindow-x11.c @@ -5021,6 +5021,8 @@ gdk_window_set_decorations (GdkWindow *window, g_return_if_fail (GDK_IS_WINDOW (window)); + /* initialize to zero to avoid writing uninitialized data to socket */ + memset(&hints, 0, sizeof(hints)); hints.flags = MWM_HINTS_DECORATIONS; hints.decorations = decorations; @@ -5089,6 +5091,8 @@ gdk_window_set_functions (GdkWindow *window, g_return_if_fail (GDK_IS_WINDOW (window)); + /* initialize to zero to avoid writing uninitialized data to socket */ + memset(&hints, 0, sizeof(hints)); hints.flags = MWM_HINTS_FUNCTIONS; hints.functions = functions; |