diff options
| author | Tor Lillqvist <tml@src.gnome.org> | 2000-02-03 01:42:51 +0000 |
|---|---|---|
| committer | Tor Lillqvist <tml@src.gnome.org> | 2000-02-03 01:42:51 +0000 |
| commit | a30c4b9e94943b2fa70e38be197529f84fbe6ad5 (patch) | |
| tree | a540659be70ac66f588ffe7b94cc1b60e6e581e3 /ChangeLog.pre-2-4 | |
| parent | e57b1afa2b4c91bcfecef26e4bff5280bd3563de (diff) | |
| download | gtk+-a30c4b9e94943b2fa70e38be197529f84fbe6ad5.tar.gz | |
Argh, decided not to return a string that must be freed from
gtk_file_selection_get_filename after all, as that would
cause memory leaks in all apps that use it unless they
specifically checked fot the GTk+ version.
gtk_file_selection_get_filename returns the filename in the C
runtime encoding. It calls g_filename_from_utf8, but copies the
returned string to a static buffer, which is returned. I think
this is better than returning the result from g_filename_from_utf8
directly, which would mean all apps that use it would have to free
the return value. Or should this function care about this issue at
all? Maybe a new function with clearly defined semantics.
Diffstat (limited to 'ChangeLog.pre-2-4')
| -rw-r--r-- | ChangeLog.pre-2-4 | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index d557074680..d10f1e62c2 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -27,6 +27,14 @@ Wed Feb 2 11:58:05 2000 Owen Taylor <otaylor@redhat.com> GLib). Some cleanups: Use gbooleans. Use GStrings instead of fixed size buffers. + gtk_file_selection_get_filename returns the filename in the C + runtime encoding. It calls g_filename_from_utf8, but copies the + returned string to a static buffer, which is returned. I think + this is better than returning the result from g_filename_from_utf8 + directly, which would mean all apps that use it would have to free + the return value. Or should this function care about this issue at + all? Maybe a new function with clearly defined semantics. + * gtk/gtkfilesel.h: Add comment about gtk_file_selection_get_filename returning the filename in the C runtime's encoding. |