diff options
author | Timm Bäder <mail@baedert.org> | 2021-07-15 16:52:38 +0200 |
---|---|---|
committer | Timm Bäder <mail@baedert.org> | 2021-07-15 16:52:38 +0200 |
commit | 433233258bf1c04ab3e717dd097e3953f1d3ff84 (patch) | |
tree | 15e3a7149baa497a5e47fb7924a46b69b432b858 | |
parent | 3eed61deba9d5ab488f3b9a0bd22b822d829156d (diff) | |
download | gtk+-433233258bf1c04ab3e717dd097e3953f1d3ff84.tar.gz |
snapshot: Only compute start and end point if we have to
If the linear gradient results in a color node, we don't need the start
and end point. Only declare and compute it if we need to.
-rw-r--r-- | gtk/gtksnapshot.c | 32 |
1 files changed, 18 insertions, 14 deletions
diff --git a/gtk/gtksnapshot.c b/gtk/gtksnapshot.c index 827d4b80e9..af8608b682 100644 --- a/gtk/gtksnapshot.c +++ b/gtk/gtksnapshot.c @@ -2159,12 +2159,9 @@ gtk_snapshot_append_linear_gradient (GtkSnapshot *snapshot, { GskRenderNode *node; graphene_rect_t real_bounds; - graphene_point_t real_start_point; - graphene_point_t real_end_point; float scale_x, scale_y, dx, dy; const GdkRGBA *first_color; gboolean need_gradient = FALSE; - int i; g_return_if_fail (snapshot != NULL); g_return_if_fail (start_point != NULL); @@ -2174,13 +2171,9 @@ gtk_snapshot_append_linear_gradient (GtkSnapshot *snapshot, gtk_snapshot_ensure_affine (snapshot, &scale_x, &scale_y, &dx, &dy); gtk_graphene_rect_scale_affine (bounds, scale_x, scale_y, dx, dy, &real_bounds); - real_start_point.x = scale_x * start_point->x + dx; - real_start_point.y = scale_y * start_point->y + dy; - real_end_point.x = scale_x * end_point->x + dx; - real_end_point.y = scale_y * end_point->y + dy; first_color = &stops[0].color; - for (i = 0; i < n_stops; i ++) + for (gsize i = 0; i < n_stops; i ++) { if (!gdk_rgba_equal (first_color, &stops[i].color)) { @@ -2190,13 +2183,24 @@ gtk_snapshot_append_linear_gradient (GtkSnapshot *snapshot, } if (need_gradient) - node = gsk_linear_gradient_node_new (&real_bounds, - &real_start_point, - &real_end_point, - stops, - n_stops); + { + graphene_point_t real_start_point, real_end_point; + + real_start_point.x = scale_x * start_point->x + dx; + real_start_point.y = scale_y * start_point->y + dy; + real_end_point.x = scale_x * end_point->x + dx; + real_end_point.y = scale_y * end_point->y + dy; + + node = gsk_linear_gradient_node_new (&real_bounds, + &real_start_point, + &real_end_point, + stops, + n_stops); + } else - node = gsk_color_node_new (first_color, &real_bounds); + { + node = gsk_color_node_new (first_color, &real_bounds); + } gtk_snapshot_append_node_internal (snapshot, node); } |