diff options
| author | Manish Singh <yosh@gimp.org> | 2002-09-25 06:54:58 +0000 |
|---|---|---|
| committer | Manish Singh <yosh@src.gnome.org> | 2002-09-25 06:54:58 +0000 |
| commit | de4cf94bc273c379cee8e4d04fdd1bb3628de5f9 (patch) | |
| tree | 346cc1260374e3480a1a47ed0aadbd53ddeb421a | |
| parent | 9cde6b74d563a68026e439d1aa2a834162745a78 (diff) | |
| download | gtk+-de4cf94bc273c379cee8e4d04fdd1bb3628de5f9.tar.gz | |
check if last_selected is valid before doing a strcmp on it, which may
Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org>
* gtk/gtkfilesel.c: check if last_selected is valid before doing
a strcmp on it, which may happen if selections happen programmatically
instead of through the UI (#86566)
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | ChangeLog.pre-2-10 | 6 | ||||
| -rw-r--r-- | ChangeLog.pre-2-2 | 6 | ||||
| -rw-r--r-- | ChangeLog.pre-2-4 | 6 | ||||
| -rw-r--r-- | ChangeLog.pre-2-6 | 6 | ||||
| -rw-r--r-- | ChangeLog.pre-2-8 | 6 | ||||
| -rw-r--r-- | gtk/gtkfilesel.c | 3 |
7 files changed, 38 insertions, 1 deletions
@@ -1,3 +1,9 @@ +Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org> + + * gtk/gtkfilesel.c: check if last_selected is valid before doing + a strcmp on it, which may happen if selections happen programmatically + instead of through the UI (#86566) + Tue Sep 24 23:33:48 2002 Manish Singh <yosh@gimp.org> * gtk/gtkfilesel.c: preserve ordering from gtk_tree_selection_foreach diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index f8276b0b4a..67692edd26 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,9 @@ +Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org> + + * gtk/gtkfilesel.c: check if last_selected is valid before doing + a strcmp on it, which may happen if selections happen programmatically + instead of through the UI (#86566) + Tue Sep 24 23:33:48 2002 Manish Singh <yosh@gimp.org> * gtk/gtkfilesel.c: preserve ordering from gtk_tree_selection_foreach diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index f8276b0b4a..67692edd26 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,9 @@ +Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org> + + * gtk/gtkfilesel.c: check if last_selected is valid before doing + a strcmp on it, which may happen if selections happen programmatically + instead of through the UI (#86566) + Tue Sep 24 23:33:48 2002 Manish Singh <yosh@gimp.org> * gtk/gtkfilesel.c: preserve ordering from gtk_tree_selection_foreach diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index f8276b0b4a..67692edd26 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,9 @@ +Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org> + + * gtk/gtkfilesel.c: check if last_selected is valid before doing + a strcmp on it, which may happen if selections happen programmatically + instead of through the UI (#86566) + Tue Sep 24 23:33:48 2002 Manish Singh <yosh@gimp.org> * gtk/gtkfilesel.c: preserve ordering from gtk_tree_selection_foreach diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index f8276b0b4a..67692edd26 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,9 @@ +Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org> + + * gtk/gtkfilesel.c: check if last_selected is valid before doing + a strcmp on it, which may happen if selections happen programmatically + instead of through the UI (#86566) + Tue Sep 24 23:33:48 2002 Manish Singh <yosh@gimp.org> * gtk/gtkfilesel.c: preserve ordering from gtk_tree_selection_foreach diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index f8276b0b4a..67692edd26 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,9 @@ +Tue Sep 24 23:54:20 2002 Manish Singh <yosh@gimp.org> + + * gtk/gtkfilesel.c: check if last_selected is valid before doing + a strcmp on it, which may happen if selections happen programmatically + instead of through the UI (#86566) + Tue Sep 24 23:33:48 2002 Manish Singh <yosh@gimp.org> * gtk/gtkfilesel.c: preserve ordering from gtk_tree_selection_foreach diff --git a/gtk/gtkfilesel.c b/gtk/gtkfilesel.c index a4e7a9191d..b794222eb5 100644 --- a/gtk/gtkfilesel.c +++ b/gtk/gtkfilesel.c @@ -2301,7 +2301,8 @@ gtk_file_selection_file_changed (GtkTreeSelection *selection, * was selected, which is used for subsequent range selections. * So search up from there. */ - if (compare_filenames (fs->last_selected, + if (fs->last_selected && + compare_filenames (fs->last_selected, g_ptr_array_index (new_names, 0)) == 0) index = new_names->len - 1; else |